Geronimo Maven2 Plugins :: CAR

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
12	0	0	251

Rules

Rules	Violations	Severity
PackageHtml	2	Error
NewlineAtEndOfFile	1	Error
Translation	0	Error
JavadocMethod	72	Error
JavadocType	2	Error
JavadocVariable	29	Error
JavadocStyle	4	Error
ConstantName	1	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	0	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName	0	Error
Header headerFile: `"c:\java\geronimo\server\tags\car-maven-plugin-1.1\target\checkstyle-header.txt"`	10	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	6	Error
FileLength	0	Error
LineLength max: `"120"`	9	Error
MethodLength	0	Error
ParameterNumber	0	Error
EmptyForIteratorPad	0	Error
NoWhitespaceAfter	0	Error
NoWhitespaceBefore	0	Error
OperatorWrap	0	Error
ParenPad	4	Error
TypecastParenPad	0	Error
TabCharacter	0	Error
WhitespaceAfter	5	Error
WhitespaceAround	3	Error
ModifierOrder	0	Error
RedundantModifier	0	Error
AvoidNestedBlocks	0	Error
EmptyBlock	0	Error
LeftCurly	12	Error
NeedBraces	0	Error
RightCurly	25	Error
AvoidInlineConditionals	0	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	6	Error
IllegalInstantiation	0	Error
InnerAssignment	0	Error
MagicNumber	0	Error
MissingSwitchDefault	0	Error
RedundantThrows	0	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
FinalClass	0	Error
HideUtilityClassConstructor	0	Error
InterfaceIsType	0	Error
VisibilityModifier	9	Error
ArrayTypeStyle	0	Error
FinalParameters	29	Error
GenericIllegalRegexp message: `"Line has trailing spaces."` format: `"\s+$"`	19	Error
TodoComment	3	Error
UpperEll	0	Error

Files

Files	I	W	E
org/apache/geronimo/plugin/car/PackageMojo.java	0	0	18
org/apache/geronimo/plugin/car/PlanProcessorMojo.java	0	0	36
org/apache/geronimo/plugin/car/MavenConfigStore.java	0	0	18
org/apache/geronimo/plugin/car/MavenAttributeStore.java	0	0	28
org/apache/geronimo/plugin/car/ArtifactItem.java	0	0	4
org/apache/geronimo/plugin/car/ClasspathElement.java	0	0	3
org/apache/geronimo/plugin/package.html	0	0	1
org/apache/geronimo/plugin/MojoSupport.java	0	0	12
org/apache/geronimo/plugin/car/AbstractCarMojo.java	0	0	29
org/apache/geronimo/plugin/car/InstallConfigMojo.java	0	0	47
org/apache/geronimo/plugin/car/PackageBuilder.java	0	0	54
org/apache/geronimo/plugin/car/package.html	0	0	1

Details

org/apache/geronimo/plugin/car/PackageMojo.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	'{' should be on the previous line.	49
	Line is longer than 120 characters.	53
	Line is longer than 120 characters.	128
	Line has trailing spaces.	154
	Missing a Javadoc comment.	185
	Line has trailing spaces.	205
	'archive' hides a field.	209
	Missing a Javadoc comment.	215
	Missing a Javadoc comment.	229
	Expected an @return tag.	258
	Expected @throws tag for 'MojoExecutionException'.	258
	'}' should be on the same line.	279
	Missing a Javadoc comment.	285
	'=' is not preceded with whitespace.	289
	'=' is not followed by whitespace.	289
	Comment matches to-do format 'TODO:'.	293
	'<' is not preceded with whitespace.	312

org/apache/geronimo/plugin/car/PlanProcessorMojo.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Unused import - java.util.HashMap.	22
	Unused import - java.util.Map.	26
	Comment matches to-do format 'TODO:'.	49
	First sentence should end with a period.	52
	Line has trailing spaces.	54
	'{' should be on the previous line.	61
	Missing a Javadoc comment.	62
	Line is longer than 120 characters.	64
	Missing a Javadoc comment.	64
	Line has trailing spaces.	89
	Line has trailing spaces.	92
	Line has trailing spaces.	93
	Line has trailing spaces.	95
	Missing a Javadoc comment.	96
	Missing a Javadoc comment.	114
	Line has trailing spaces.	120
	Line has trailing spaces.	140
	'}' should be on the same line.	145
	Line has trailing spaces.	153
	'}' should be on the same line.	155
	Missing a Javadoc comment.	161
	Line has trailing spaces.	166
	'}' should be on the same line.	173
	'}' should be on the same line.	190
	Missing a Javadoc comment.	196
	'}' should be on the same line.	215
	Missing a Javadoc comment.	221
	Missing a Javadoc comment.	247
	'}' should be on the same line.	263
	'}' should be on the same line.	266
	'}' should be on the same line.	269
	'}' should be on the same line.	272
	Missing a Javadoc comment.	279
	Missing a Javadoc comment.	288
	Missing a Javadoc comment.	289

org/apache/geronimo/plugin/car/MavenConfigStore.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	44
	Missing a Javadoc comment.	45
	Parameter kernel should be final.	45
	Parameter objectName should be final.	45
	Parameter repository should be final.	45
	Missing a Javadoc comment.	49
	Parameter repository should be final.	49
	Missing a Javadoc comment.	53
	Parameter configId should be final.	53
	'}' should be on the same line.	65
	Missing a Javadoc comment.	72
	Parameter configurationData should be final.	72
	Missing a Javadoc comment.	82
	Parameter configID should be final.	82
	Missing a Javadoc comment.	87
	Missing a Javadoc comment.	91
	Missing a Javadoc comment.	93

org/apache/geronimo/plugin/car/MavenAttributeStore.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	42
	Parameter configurationName should be final.	42
	Parameter datas should be final.	42
	Parameter classLoader should be final.	42
	Missing a Javadoc comment.	46
	Parameter configurationName should be final.	46
	Parameter gbean should be final.	46
	Parameter attribute should be final.	46
	Parameter value should be final.	46
	Line is longer than 120 characters.	49
	Missing a Javadoc comment.	49
	Parameter configurationName should be final.	49
	Parameter gbean should be final.	49
	Parameter reference should be final.	49
	Parameter patterns should be final.	49
	Missing a Javadoc comment.	52
	Parameter configurationName should be final.	52
	Parameter gbean should be final.	52
	Parameter load should be final.	52
	Missing a Javadoc comment.	55
	Parameter configurationName should be final.	55
	Parameter gbeanData should be final.	55
	Missing a Javadoc comment.	58
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	63

org/apache/geronimo/plugin/car/ArtifactItem.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	27
	First sentence should end with a period.	66
	Missing a Javadoc comment.	71

org/apache/geronimo/plugin/car/ClasspathElement.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	26

org/apache/geronimo/plugin/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/plugin/MojoSupport.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	31
	Missing a Javadoc comment.	32
	Variable 'log' must be private and have accessor methods.	32
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	38
	'}' should be on the same line.	43
	'cast' is not followed by whitespace.	46
	'}' should be on the same line.	47
	'cast' is not followed by whitespace.	49
	'}' should be on the same line.	50
	Missing a Javadoc comment.	57

org/apache/geronimo/plugin/car/AbstractCarMojo.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	'{' should be on the previous line.	55
	Variable 'project' must be private and have accessor methods.	63
	Variable 'factory' must be private and have accessor methods.	72
	Variable 'resolver' must be private and have accessor methods.	81
	Variable 'local' must be private and have accessor methods.	90
	Variable 'remoteRepos' must be private and have accessor methods.	99
	Variable 'basedir' must be private and have accessor methods.	108
	Variable 'projectHelper' must be private and have accessor methods.	117
	Variable 'artifactFactory' must be private and have accessor methods.	124
	Missing a Javadoc comment.	126
	'project' hides a field.	126
	Missing a Javadoc comment.	175
	Line has trailing spaces.	178
	Missing a Javadoc comment.	179
	'cast' is not followed by whitespace.	186
	Missing a Javadoc comment.	200
	Parameter classifier should be final.	200
	'}' should be on the same line.	203
	Comment matches to-do format 'TODO:'.	216
	Expected an @return tag.	223
	Expected @param tag for 'item'.	223
	Expected @throws tag for 'MojoExecutionException'.	223
	'}' should be on the same line.	244
	'}' should be on the same line.	256
	'}' should be on the same line.	259
	Expected @param tag for 'item'.	271
	'{' should be on the previous line.	282
	'{' should be on the previous line.	299

org/apache/geronimo/plugin/car/InstallConfigMojo.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Unused import - org.apache.geronimo.kernel.repository.MissingDependencyException.	28
	Unused import - org.apache.geronimo.plugin.MojoSupport.	35
	Unused import - org.apache.maven.project.MavenProject.	38
	Unused import - org.apache.maven.plugin.MojoExecutionException.	39
	Line has trailing spaces.	56
	'{' should be on the previous line.	61
	Missing a Javadoc comment.	62
	Line has trailing spaces.	73
	First sentence should end with a period.	79
	First sentence should end with a period.	88
	Line has trailing spaces.	95
	Missing a Javadoc comment.	104
	Missing a Javadoc comment.	106
	Missing a Javadoc comment.	107
	Missing a Javadoc comment.	109
	Missing a Javadoc comment.	110
	Missing a Javadoc comment.	112
	Line has trailing spaces.	114
	Line has trailing spaces.	122
	'(' is followed by whitespace.	134
	')' is preceded with whitespace.	134
	'}' should be on the same line.	137
	Line is longer than 120 characters.	143
	'(' is followed by whitespace.	159
	')' is preceded with whitespace.	159
	Missing a Javadoc comment.	170
	Parameter configId should be final.	170
	'cast' is not followed by whitespace.	190
	'}' should be on the same line.	191
	'}' should be on the same line.	208
	'}' should be on the same line.	211
	'}' should be on the same line.	215
	Line is longer than 120 characters.	218
	'cast' is not followed by whitespace.	226
	'}' should be on the same line.	227
	Line has trailing spaces.	236
	'artifact' hides a field.	239
	Missing a Javadoc comment.	244
	Missing a Javadoc comment.	245
	Parameter fileDescription should be final.	245
	Parameter fileSize should be final.	245
	Line has trailing spaces.	249
	Missing a Javadoc comment.	253
	Parameter bytes should be final.	253
	Missing a Javadoc comment.	257
	Parameter bytes should be final.	257

org/apache/geronimo/plugin/car/PackageBuilder.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	'{' should be on the previous line.	54
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	73
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	73
	Missing a Javadoc comment.	81
	Missing a Javadoc comment.	83
	Missing a Javadoc comment.	85
	Missing a Javadoc comment.	87
	Missing a Javadoc comment.	89
	Missing a Javadoc comment.	91
	Missing a Javadoc comment.	93
	Missing a Javadoc comment.	95
	Missing a Javadoc comment.	97
	Missing a Javadoc comment.	99
	Missing a Javadoc comment.	101
	Missing a Javadoc comment.	103
	Missing a Javadoc comment.	105
	Missing a Javadoc comment.	107
	Missing a Javadoc comment.	109
	Missing a Javadoc comment.	111
	Missing a Javadoc comment.	115
	Missing a Javadoc comment.	119
	Missing a Javadoc comment.	123
	Missing a Javadoc comment.	127
	Missing a Javadoc comment.	131
	Missing a Javadoc comment.	135
	Missing a Javadoc comment.	139
	Missing a Javadoc comment.	143
	Missing a Javadoc comment.	147
	Missing a Javadoc comment.	151
	Missing a Javadoc comment.	155
	Missing a Javadoc comment.	159
	Missing a Javadoc comment.	172
	Missing a Javadoc comment.	185
	Missing a Javadoc comment.	198
	Missing a Javadoc comment.	211
	Missing a Javadoc comment.	224
	Missing a Javadoc comment.	228
	Missing a Javadoc comment.	232
	'kernel' hides a field.	236
	'}' should be on the same line.	258
	Missing a Javadoc comment.	265
	Expected an @return tag.	280
	Expected @throws tag for 'Exception'.	280
	Expected @throws tag for 'Exception'.	313
	Line is longer than 120 characters.	327
	Line is longer than 120 characters.	334
	Unused @throws tag for 'IllegalStateException'.	378
	'kernel' hides a field.	380
	Line is longer than 120 characters.	394
	Missing a Javadoc comment.	394
	'kernel' hides a field.	394

org/apache/geronimo/plugin/car/package.html

Violation	Message	Line
	Missing package documentation file.	0

Geronimo

Project Documentation

Checkstyle Results

Summary

Rules

Files

Details

org/apache/geronimo/plugin/car/PackageMojo.java

org/apache/geronimo/plugin/car/PlanProcessorMojo.java

org/apache/geronimo/plugin/car/MavenConfigStore.java

org/apache/geronimo/plugin/car/MavenAttributeStore.java

org/apache/geronimo/plugin/car/ArtifactItem.java

org/apache/geronimo/plugin/car/ClasspathElement.java

org/apache/geronimo/plugin/package.html

org/apache/geronimo/plugin/MojoSupport.java

org/apache/geronimo/plugin/car/AbstractCarMojo.java

org/apache/geronimo/plugin/car/InstallConfigMojo.java

org/apache/geronimo/plugin/car/PackageBuilder.java

org/apache/geronimo/plugin/car/package.html