Checkstyle Results

The following document contains the results of Checkstylerss feed

Summary

FilesInfos infoWarnings warningErrors error
1300462

Rules

RulesViolationsSeverity
PackageHtml1error Error
NewlineAtEndOfFile0error Error
Translation0error Error
JavadocMethod89error Error
JavadocType5error Error
JavadocVariable47error Error
JavadocStyle3error Error
ConstantName0error Error
LocalFinalVariableName0error Error
LocalVariableName0error Error
MemberName0error Error
MethodName0error Error
PackageName0error Error
ParameterName6error Error
StaticVariableName0error Error
TypeName0error Error
Header
  • headerFile: "/Users/jason/ws/geronimo/specs/geronimo-j2ee-jacc_1.0_spec/target/checkstyle-header.txt"
12error Error
AvoidStarImport0error Error
IllegalImport0error Error
RedundantImport0error Error
UnusedImports0error Error
FileLength0error Error
LineLength
  • max: "120"
23error Error
MethodLength0error Error
ParameterNumber0error Error
EmptyForIteratorPad0error Error
NoWhitespaceAfter1error Error
NoWhitespaceBefore0error Error
OperatorWrap0error Error
ParenPad0error Error
TypecastParenPad0error Error
TabCharacter0error Error
WhitespaceAfter20error Error
WhitespaceAround23error Error
ModifierOrder13error Error
RedundantModifier17error Error
AvoidNestedBlocks6error Error
EmptyBlock0error Error
LeftCurly1error Error
NeedBraces70error Error
RightCurly0error Error
AvoidInlineConditionals9error Error
DoubleCheckedLocking0error Error
EmptyStatement0error Error
EqualsHashCode0error Error
HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
1error Error
IllegalInstantiation0error Error
InnerAssignment0error Error
MagicNumber4error Error
MissingSwitchDefault2error Error
RedundantThrows0error Error
SimplifyBooleanExpression0error Error
SimplifyBooleanReturn1error Error
FinalClass0error Error
HideUtilityClassConstructor0error Error
InterfaceIsType0error Error
VisibilityModifier6error Error
ArrayTypeStyle0error Error
FinalParameters85error Error
GenericIllegalRegexp
  • message: "Line has trailing spaces."
  • format: "\s+$"
17error Error
TodoComment0error Error
UpperEll0error Error

Details

javax/security/jacc/HTTPMethodSpec.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.32
error'static' modifier out of order with the JLS suggestions.32
errorMissing a Javadoc comment.33
error'static' modifier out of order with the JLS suggestions.33
errorMissing a Javadoc comment.35
error'static' modifier out of order with the JLS suggestions.35
errorMissing a Javadoc comment.36
error'static' modifier out of order with the JLS suggestions.36
errorMissing a Javadoc comment.37
error'static' modifier out of order with the JLS suggestions.37
errorMissing a Javadoc comment.38
error'static' modifier out of order with the JLS suggestions.38
errorMissing a Javadoc comment.40
errorMissing a Javadoc comment.41
errorMissing a Javadoc comment.42
errorMissing a Javadoc comment.44
errorParameter HTTPMethods should be final.44
errorName 'HTTPMethods' must match pattern '^[a-z][a-zA-Z0-9]*$'.44
errorMissing a Javadoc comment.48
errorParameter name should be final.48
errorParameter parseTransportType should be final.48
error'0x7F' is a magic number.75
error'if' construct must use '{}'s.91
errorMissing a Javadoc comment.97
errorParameter HTTPMethods should be final.97
errorName 'HTTPMethods' must match pattern '^[a-z][a-zA-Z0-9]*$'.97
errorParameter transport should be final.97
error'0x7F' is a magic number.101
error'if' construct must use '{}'s.114
errorMissing a Javadoc comment.134
errorParameter singleMethod should be final.134
errorParameter transport should be final.134
error'if' construct must use '{}'s.144
errorMissing a Javadoc comment.149
errorParameter o should be final.149
errorMissing a Javadoc comment.153
errorMissing a Javadoc comment.180
errorMissing a Javadoc comment.184
errorParameter p should be final.184

javax/security/jacc/package.html

ViolationMessageLine
errorMissing package documentation file.0

javax/security/jacc/PolicyContextHandler.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorLine has trailing spaces.35
errorIncomplete HTML tag found: * @param key a <code>String</code< value identifying a context object44
errorRedundant 'public' modifier.54
errorRedundant 'public' modifier.70
errorUnclosed HTML tag found: <code>PolicyContext/<code> class to73
errorRedundant 'public' modifier.95

javax/security/jacc/WebUserDataPermission.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.49
errorMissing a Javadoc comment.50
errorMissing a Javadoc comment.51
errorParameter request should be final.66
errorLine is longer than 120 characters.70
error'?' is not preceded with whitespace.70
errorAvoid inline conditionals.70
error':' is not preceded with whitespace.70
errorMissing a Javadoc comment.73
errorParameter name should be final.73
errorParameter actions should be final.73
errorMissing a Javadoc comment.80
errorParameter urlPattern should be final.80
errorParameter HTTPMethods should be final.80
errorName 'HTTPMethods' must match pattern '^[a-z][a-zA-Z0-9]*$'.80
errorParameter transportType should be final.80
error'?' is not preceded with whitespace.84
errorAvoid inline conditionals.84
error':' is not preceded with whitespace.84
errorMissing a Javadoc comment.87
errorParameter o should be final.87
error'if' construct must use '{}'s.88
errorMissing a Javadoc comment.94
errorMissing a Javadoc comment.98
errorMissing a Javadoc comment.105
errorParameter permission should be final.105
error'if' construct must use '{}'s.106
errorMissing a Javadoc comment.112
errorMissing a Javadoc comment.116
errorParameter in should be final.116
errorMissing a Javadoc comment.121
errorParameter out should be final.121
errorMissing a Javadoc comment.126
errorMissing a Javadoc comment.127
errorUnused @throws tag for 'SecurityException'.134
errorParameter permission should be final.137
error'if' construct must use '{}'s.138
error'if' construct must use '{}'s.140
errorLine is longer than 120 characters.140
error'cast' is not followed by whitespace.142
errorParameter permission should be final.156
error'if' construct must use '{}'s.157
error'cast' is not followed by whitespace.159
error'if' construct must use '{}'s.163
error'cast' is not followed by whitespace.163

javax/security/jacc/URLPatternSpec.java

ViolationMessageLine
errorLine does not match expected header line of ''.1
errorMissing a Javadoc comment.36
errorMissing a Javadoc comment.37
errorMissing a Javadoc comment.38
errorMissing a Javadoc comment.40
errorParameter name should be final.40
error'if' construct must use '{}'s.41
error'if' construct must use '{}'s.42
errorLine is longer than 120 characters.55
errorLine is longer than 120 characters.65
errorLine is longer than 120 characters.69
errorLine is longer than 120 characters.71
errorLine is longer than 120 characters.80
errorLine is longer than 120 characters.82
errorLine is longer than 120 characters.90
errorLine is longer than 120 characters.97
errorMissing a Javadoc comment.104
errorParameter o should be final.104
errorMissing a Javadoc comment.108
errorMissing a Javadoc comment.112
errorMissing a Javadoc comment.116
errorParameter p should be final.116
error'if' construct must use '{}'s.120
error'if' construct must use '{}'s.127
error'if' construct must use '{}'s.149
errorMissing a Javadoc comment.156
errorParameter request should be final.156
errorAvoid inline conditionals.157
error'if' construct must use '{}'s.159
error'if' construct must use '{}'s.160
errorMissing a Javadoc comment.165
errorMissing a Javadoc comment.167
error'static' modifier out of order with the JLS suggestions.167
errorMissing a Javadoc comment.168
error'static' modifier out of order with the JLS suggestions.168
errorMissing a Javadoc comment.169
error'static' modifier out of order with the JLS suggestions.169
errorMissing a Javadoc comment.170
error'static' modifier out of order with the JLS suggestions.170
errorMissing a Javadoc comment.172
errorVariable 'type' must be private and have accessor methods.172
errorMissing a Javadoc comment.173
errorVariable 'pattern' must be private and have accessor methods.173
errorMissing a Javadoc comment.175
errorParameter pat should be final.175
error'if' construct must use '{}'s.176
error'if' construct must use '{}'s.177
errorMissing a Javadoc comment.191
errorParameter p should be final.191
error'if' construct must use '{}'s.196
errorswitch without "default" clause.198
errorAvoid nested blocks.205
error'if' construct must use '{}'s.207
error'if' construct must use '{}'s.210
error'if' construct must use '{}'s.213
error'if' construct must use '{}'s.214
errorAvoid nested blocks.221
errorAvoid nested blocks.228

javax/security/jacc/EJBMethodPermission.java

ViolationMessageLine
errorLine does not match expected header line of ''.1
errorMissing a Javadoc comment.45
error'static' modifier out of order with the JLS suggestions.45
errorMissing a Javadoc comment.46
errorMissing a Javadoc comment.65
errorMissing a Javadoc comment.66
errorMissing a Javadoc comment.68
errorParameter name should be final.68
errorParameter spec should be final.68
errorMissing a Javadoc comment.74
errorParameter EJBName should be final.74
errorName 'EJBName' must match pattern '^[a-z][a-zA-Z0-9]*$'.74
errorParameter methodName should be final.74
errorParameter methodInterface should be final.74
errorParameter methodParams should be final.74
errorMissing a Javadoc comment.80
errorParameter EJBName should be final.80
errorName 'EJBName' must match pattern '^[a-z][a-zA-Z0-9]*$'.80
errorParameter methodInterface should be final.80
errorParameter method should be final.80
error'if' construct must use '{}'s.83
errorMissing a Javadoc comment.88
errorParameter o should be final.88
error'if' construct must use '{}'s.89
errorMissing a Javadoc comment.95
errorMissing a Javadoc comment.99
errorMissing a Javadoc comment.106
errorParameter permission should be final.106
error'if' construct must use '{}'s.107
errorMissing a Javadoc comment.113
errorMissing a Javadoc comment.117
errorParameter in should be final.117
errorMissing a Javadoc comment.121
errorParameter out should be final.121
errorMissing a Javadoc comment.125
errorMissing a Javadoc comment.126
errorVariable 'methodName' must be private and have accessor methods.126
errorMissing a Javadoc comment.127
errorVariable 'methodInterface' must be private and have accessor methods.127
errorMissing a Javadoc comment.128
errorVariable 'methodParams' must be private and have accessor methods.128
errorMissing a Javadoc comment.129
errorVariable 'actions' must be private and have accessor methods.129
errorMissing a Javadoc comment.131
errorParameter actionString should be final.131
error'3' is a magic number.138
errorswitch without "default" clause.140
errorAvoid nested blocks.142
errorAvoid nested blocks.149
error'if' construct must use '{}'s.150
errorLine is longer than 120 characters.150
error'3' is a magic number.158
errorAvoid nested blocks.159
error'if' construct must use '{}'s.164
errorMissing a Javadoc comment.177
errorParameter mthdName should be final.177
errorParameter mthdInterface should be final.177
errorParameter methodParamsArray should be final.177
error'if' construct must use '{}'s.188
errorLine is longer than 120 characters.188
error'if' construct must use '{}'s.192
errorLine is longer than 120 characters.192
errorMissing a Javadoc comment.203
errorParameter mthdInterface should be final.203
errorParameter method should be final.203
errorMissing a Javadoc comment.224
errorParameter spec should be final.224
errorMissing a Javadoc comment.228
errorMissing a Javadoc comment.232
errorMissing a Javadoc comment.236
errorParameter methodSpec should be final.236
errorConditional logic can be removed.239
error'else' construct must use '{}'s.241
error'else' construct must use '{}'s.243
error'else' construct must use '{}'s.245
errorMissing a Javadoc comment.249
errorMissing a Javadoc comment.282
errorParameter methodInterface should be final.282
error'methodInterface' hides a field.282
error'if' construct must use '{}'s.283
error'if' construct must use '{}'s.286
errorParameter name should be final.301
errorMissing a Javadoc comment.310
errorMissing a Javadoc comment.312
errorMissing a Javadoc comment.313
errorMissing a Javadoc comment.314
errorUnused @throws tag for 'SecurityException'.321
errorParameter permission should be final.325
error'if' construct must use '{}'s.327
error'if' construct must use '{}'s.329
errorLine is longer than 120 characters.329
error'if' construct must use '{}'s.331
error'else' construct must use '{}'s.332
error'cast' is not followed by whitespace.334
error'if' construct must use '{}'s.338
error'cast' is not followed by whitespace.345
error'?' is not preceded with whitespace.351
errorAvoid inline conditionals.351
error':' is not preceded with whitespace.351
error':' is not followed by whitespace.351
error'cast' is not followed by whitespace.352
errorLine is longer than 120 characters.358
error'?' is not preceded with whitespace.358
errorAvoid inline conditionals.358
error':' is not preceded with whitespace.358
error':' is not followed by whitespace.358
error'cast' is not followed by whitespace.359
error'?' is not preceded with whitespace.368
errorAvoid inline conditionals.368
error':' is not preceded with whitespace.368
error':' is not followed by whitespace.368
errorParameter permission should be final.386
error'if' construct must use '{}'s.388
error'cast' is not followed by whitespace.390
error'if' construct must use '{}'s.395
error'if' construct must use '{}'s.396
error'cast' is not followed by whitespace.398
error'?' is not preceded with whitespace.400
errorAvoid inline conditionals.400
error':' is not preceded with whitespace.400
error':' is not followed by whitespace.400
error'cast' is not followed by whitespace.401
error'if' construct must use '{}'s.403
error'cast' is not followed by whitespace.405
errorMissing a Javadoc comment.413
errorParameter interfaces should be final.413
errorParameter spec should be final.413
error'if' construct must use '{}'s.415
errorLine is longer than 120 characters.417
error'?' is not preceded with whitespace.417
errorAvoid inline conditionals.417
error':' is not preceded with whitespace.417
error':' is not followed by whitespace.417
error'cast' is not followed by whitespace.418
error'if' construct must use '{}'s.420
error'cast' is not followed by whitespace.422
errorMissing a Javadoc comment.430
errorParameter parameters should be final.430
errorParameter spec should be final.430
error'if' construct must use '{}'s.432
error'?' is not preceded with whitespace.436
errorAvoid inline conditionals.436
error':' is not preceded with whitespace.436
error':' is not followed by whitespace.436
error'if' construct must use '{}'s.439

javax/security/jacc/PolicyConfigurationFactory.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.47
error'static' modifier out of order with the JLS suggestions.47
errorMissing a Javadoc comment.48
errorLine is longer than 120 characters.67
error'if' construct must use '{}'s.69
error'if' construct must use '{}'s.71
error'{' is followed by whitespace.73
error'cast' is not followed by whitespace.75
error'{' should be on the previous line.78
error'if' construct must use '{}'s.81
errorLine is longer than 120 characters.81
error'catch' is not followed by whitespace.87
error'cast' is not followed by whitespace.89
errorLine is longer than 120 characters.140

javax/security/jacc/PolicyContext.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.37
errorMissing a Javadoc comment.38
errorMissing a Javadoc comment.39
errorMissing a Javadoc comment.40
error'static' modifier out of order with the JLS suggestions.40
errorMissing a Javadoc comment.42
errorMissing a Javadoc comment.45
errorParameter contextID should be final.45
error'if' construct must use '{}'s.47
errorMissing a Javadoc comment.52
errorMissing a Javadoc comment.56
errorParameter data should be final.56
error'if' construct must use '{}'s.58
errorLine is longer than 120 characters.63
errorMissing a Javadoc comment.63
errorParameter key should be final.63
errorParameter handler should be final.63
errorParameter replace should be final.63
error'if' construct must use '{}'s.64
error'if' construct must use '{}'s.65
error'if' construct must use '{}'s.66
errorLine is longer than 120 characters.66
error'if' construct must use '{}'s.69
errorMissing a Javadoc comment.74
errorMissing a Javadoc comment.78
errorParameter key should be final.78
error'if' construct must use '{}'s.79
error'if' construct must use '{}'s.83
error'if' construct must use '{}'s.84
errorLine is longer than 120 characters.84
error'if' construct must use '{}'s.87

javax/security/jacc/PolicyContextException.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.32
errorLine has trailing spaces.35
errorMissing a Javadoc comment.36
errorParameter msg should be final.36
errorLine has trailing spaces.39
errorMissing a Javadoc comment.40
errorParameter msg should be final.40
errorParameter cause should be final.40
errorLine has trailing spaces.43
errorMissing a Javadoc comment.44
errorParameter cause should be final.44

javax/security/jacc/EJBRoleRefPermission.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.44
errorMissing a Javadoc comment.45
errorParameter name should be final.56
errorParameter role should be final.56
error'if' construct must use '{}'s.59
errorParameter o should be final.73
error'if' construct must use '{}'s.74
error'cast' is not followed by whitespace.76
errorUnclosed HTML tag found: <ul>113
errorParameter permission should be final.122

javax/security/jacc/PolicyConfiguration.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.35
errorRedundant 'public' modifier.35
errorLine has trailing spaces.36
errorMissing a Javadoc comment.37
errorRedundant 'public' modifier.37
errorLine has trailing spaces.38
errorMissing a Javadoc comment.39
errorRedundant 'public' modifier.39
errorLine has trailing spaces.40
errorMissing a Javadoc comment.41
errorRedundant 'public' modifier.41
errorLine has trailing spaces.42
errorMissing a Javadoc comment.43
errorRedundant 'public' modifier.43
errorLine has trailing spaces.44
errorMissing a Javadoc comment.45
errorRedundant 'public' modifier.45
errorLine has trailing spaces.46
errorMissing a Javadoc comment.47
errorRedundant 'public' modifier.47
errorLine has trailing spaces.48
errorMissing a Javadoc comment.49
errorRedundant 'public' modifier.49
errorLine has trailing spaces.50
errorMissing a Javadoc comment.51
errorRedundant 'public' modifier.51
errorLine has trailing spaces.52
errorMissing a Javadoc comment.53
errorRedundant 'public' modifier.53
errorLine has trailing spaces.54
errorMissing a Javadoc comment.55
errorRedundant 'public' modifier.55
errorLine has trailing spaces.56
errorMissing a Javadoc comment.57
errorRedundant 'public' modifier.57
errorLine has trailing spaces.58
errorMissing a Javadoc comment.59
errorRedundant 'public' modifier.59
errorLine has trailing spaces.60
errorMissing a Javadoc comment.61
errorRedundant 'public' modifier.61

javax/security/jacc/WebResourcePermission.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.40
errorMissing a Javadoc comment.41
errorMissing a Javadoc comment.42
errorMissing a Javadoc comment.44
errorParameter request should be final.44
errorMissing a Javadoc comment.51
errorParameter name should be final.51
errorParameter actions should be final.51
errorMissing a Javadoc comment.58
errorParameter urlPattern should be final.58
errorParameter HTTPMethods should be final.58
errorName 'HTTPMethods' must match pattern '^[a-z][a-zA-Z0-9]*$'.58
errorMissing a Javadoc comment.65
errorParameter o should be final.65
error'if' construct must use '{}'s.66
errorMissing a Javadoc comment.72
errorMissing a Javadoc comment.76
errorMissing a Javadoc comment.83
errorParameter permission should be final.83
error'if' construct must use '{}'s.84
errorMissing a Javadoc comment.90
errorMissing a Javadoc comment.94
errorParameter in should be final.94
errorMissing a Javadoc comment.99
errorParameter out should be final.99
errorMissing a Javadoc comment.104
errorMissing a Javadoc comment.105
errorUnused @throws tag for 'SecurityException'.112
errorParameter permission should be final.115
error'if' construct must use '{}'s.116
error'if' construct must use '{}'s.118
errorLine is longer than 120 characters.118
error'cast' is not followed by whitespace.120
errorParameter permission should be final.134
error'if' construct must use '{}'s.135
error'cast' is not followed by whitespace.137
error'if' construct must use '{}'s.141
error'cast' is not followed by whitespace.141

javax/security/jacc/WebRoleRefPermission.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.34
errorMissing a Javadoc comment.35
errorMissing a Javadoc comment.37
errorParameter name should be final.37
errorParameter role should be final.37
errorMissing a Javadoc comment.43
errorParameter o should be final.43
error'if' construct must use '{}'s.44
error'cast' is not followed by whitespace.46
errorMissing a Javadoc comment.50
errorMissing a Javadoc comment.54
errorMissing a Javadoc comment.61
errorParameter permission should be final.61