PMD Results

The following document contains the results of PMD

Files

org/apache/geronimo/console/apache/jk/WebAppHandler.java

ViolationLine
Avoid unused private fields such as 'log'40

org/apache/geronimo/console/BasePortlet.java

ViolationLine
Avoid unused imports such as 'javax.portlet.PortletRequest'22
Avoid unused imports such as 'org.apache.geronimo.console.util.PortletManager'26
Avoid unused imports such as 'org.apache.geronimo.management.geronimo.WebContainer'27

org/apache/geronimo/console/car/AddRepositoryHandler.java

ViolationLine
These nested if statements could be combined74 - 76

org/apache/geronimo/console/car/DownloadStatusHandler.java

ViolationLine
Avoid unused private fields such as 'log'39

org/apache/geronimo/console/car/ExportConfigHandler.java

ViolationLine
Avoid unused private methods such as 'combine(String)'197

org/apache/geronimo/console/car/ExportHandler.java

ViolationLine
Avoid unused imports such as 'org.apache.geronimo.console.util.ConfigurationData'26
Avoid unused imports such as 'org.apache.geronimo.console.util.PortletManager'27

org/apache/geronimo/console/car/GeronimoAsMavenServlet.java

ViolationLine
Avoid unused imports such as 'org.apache.geronimo.j2ee.j2eeobjectnames.NameFactory'46

org/apache/geronimo/console/car/ListHandler.java

ViolationLine
Avoid unused private fields such as 'log'47
Avoid empty if statements72

org/apache/geronimo/console/car/UpdateListHandler.java

ViolationLine
Avoid unused imports such as 'java.util.List'20
Avoid unused imports such as 'java.util.ArrayList'21
Avoid unused imports such as 'java.util.Arrays'22
Avoid unused imports such as 'org.apache.geronimo.console.util.ConfigurationData'30

org/apache/geronimo/console/car/ViewPluginDownloadHandler.java

ViolationLine
Avoid unused private fields such as 'log'41

org/apache/geronimo/console/certmanager/actions/UploadCertificateFile.java

ViolationLine
Avoid empty catch blocks126 - 127

org/apache/geronimo/console/configmanager/DeploymentPortlet.java

ViolationLine
Avoid empty catch blocks181 - 185

org/apache/geronimo/console/databasemanager/wizard/DatabasePoolPortlet.java

ViolationLine
Avoid empty if statements458
Avoid empty catch blocks865
These nested if statements could be combined1043 - 1045
Avoid empty if statements1231

org/apache/geronimo/console/infomanager/JavaSystemInfoPortlet.java

ViolationLine
Avoid unused imports such as 'java.util.Map'24
Avoid unused imports such as 'java.util.TreeMap'25

org/apache/geronimo/console/internaldb/DBViewerHelper.java

ViolationLine
Avoid unused private fields such as 'SYS_TBL_PREFIX'26
Avoid unused private fields such as 'COUNT_COL'28

org/apache/geronimo/console/internaldb/DBViewerPortlet.java

ViolationLine
Avoid unused private fields such as 'RDBMS_MSSQL'37
Avoid unused private fields such as 'LISTDB_ACTION'49
These nested if statements could be combined113 - 117
These nested if statements could be combined120 - 124

org/apache/geronimo/console/internaldb/DerbyConnectionUtil.java

ViolationLine
Avoid unused private fields such as 'RDBMS_DERBY'51
Avoid unused private fields such as 'RDBMS_MSSQL'53

org/apache/geronimo/console/internaldb/InternalDBHelper.java

ViolationLine
Avoid unused private fields such as 'RDBMS_DERBY'30
Avoid unused private fields such as 'RDBMS_MSSQL'32
Avoid unused private fields such as 'JNDI_DERBY'34
Avoid empty catch blocks158 - 160

org/apache/geronimo/console/internaldb/InternalDBPortlet.java

ViolationLine
Avoid unused private fields such as 'javaSysInfo'45
Avoid unused local variables such as 'rdbms'69

org/apache/geronimo/console/internaldb/RunSQLHelper.java

ViolationLine
These nested if statements could be combined93 - 98
These nested if statements could be combined113 - 120
These nested if statements could be combined114 - 119

org/apache/geronimo/console/jmsmanager/handlers/CreateDestinationHandler.java

ViolationLine
Avoid unused private fields such as 'parentId'49
Avoid unused local variables such as 'destinationApplicationName'74
Avoid unused local variables such as 'destinationModuleName'76
Avoid unused local variables such as 'configurationDir'129

org/apache/geronimo/console/jmsmanager/JMSManagerPortlet.java

ViolationLine
Avoid unused private fields such as 'edit'49
Avoid unused private fields such as 'cf'53

org/apache/geronimo/console/jmsmanager/renderers/StatisticsRenderer.java

ViolationLine
Avoid unused local variables such as 'description'48
Avoid unused local variables such as 'currentDepth'49
Avoid unused local variables such as 'openInputCount'50
Avoid unused local variables such as 'openOutputCount'51
Avoid unused local variables such as 'inhibitGet'52
Avoid unused local variables such as 'inhibitPut'53
Avoid unused local variables such as 'sharable'54
Avoid unused local variables such as 'triggerControl'55
Avoid unused local variables such as 'maximumDepth'56
Avoid unused local variables such as 'maximumMessageLength'57

org/apache/geronimo/console/jmsmanager/renderers/ViewDLQRenderer.java

ViolationLine
Avoid unused imports such as 'javax.management.ObjectName'32
Avoid unused imports such as 'org.apache.geronimo.j2ee.j2eeobjectnames.NameFactory'39
Avoid unused local variables such as 'destinationApplicationName'59
Avoid unused local variables such as 'destinationModuleName'61
Avoid unused local variables such as 'destinationName'63

org/apache/geronimo/console/jmsmanager/renderers/ViewMessagesRenderer.java

ViolationLine
Avoid unused imports such as 'javax.management.ObjectName'38
Avoid unused imports such as 'org.apache.geronimo.j2ee.j2eeobjectnames.NameFactory'44
Avoid unused private fields such as 'topicListener'50
Avoid unused local variables such as 'destinationApplicationName'61
Avoid unused local variables such as 'destinationModuleName'63
Avoid unused local variables such as 'destinationName'65
Avoid empty catch blocks103 - 104
Avoid empty catch blocks109 - 110
Avoid empty catch blocks115 - 116

org/apache/geronimo/console/jmsmanager/server/JMSBrokerPortlet.java

ViolationLine
Avoid empty if statements69
Avoid empty if statements71
Avoid empty if statements73

org/apache/geronimo/console/jmsmanager/wizard/AbstractHandler.java

ViolationLine
Avoid unused private fields such as 'objectName'112

org/apache/geronimo/console/jmsmanager/wizard/DeployHandler.java

ViolationLine
Avoid unused imports such as 'org.apache.geronimo.console.util.PortletManager'25

org/apache/geronimo/console/jmsmanager/wizard/JMSProviderData.java

ViolationLine
Avoid empty catch blocks239 - 240
Avoid empty catch blocks373 - 375

org/apache/geronimo/console/keystores/BaseKeystoreHandler.java

ViolationLine
Avoid unused constructor parameters such as 'request'74 - 75

org/apache/geronimo/console/keystores/CertificateDetailsHandler.java

ViolationLine
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead.67

org/apache/geronimo/console/keystores/ConfirmCertificateHandler.java

ViolationLine
Avoid unused imports such as 'java.io.FileInputStream'31

org/apache/geronimo/console/keystores/CreateKeystoreHandler.java

ViolationLine
Avoid unused imports such as 'java.util.Map'20
Avoid unused imports such as 'java.util.HashMap'21
Avoid unused imports such as 'org.apache.geronimo.gbean.AbstractName'30
Avoid unused imports such as 'org.apache.geronimo.j2ee.j2eeobjectnames.NameFactory'31

org/apache/geronimo/console/keystores/ListHandler.java

ViolationLine
Avoid empty catch blocks74

org/apache/geronimo/console/keystores/UploadCertificateHandler.java

ViolationLine
Avoid unused imports such as 'org.apache.commons.fileupload.FileItem'19
Avoid unused imports such as 'java.io.File'27

org/apache/geronimo/console/logmanager/LogManagerPortlet.java

ViolationLine
Avoid unused local variables such as 'configuration'75

org/apache/geronimo/console/logmanager/WebAccessLogViewerPortlet.java

ViolationLine
These nested if statements could be combined87 - 89
Avoid empty if statements122
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead.185

org/apache/geronimo/console/MultiPageAbstractHandler.java

ViolationLine
Avoid unused imports such as 'org.apache.commons.fileupload.portlet.PortletFileUpload'19

org/apache/geronimo/console/repository/RepositoryViewPortlet.java

ViolationLine
Avoid unused private fields such as 'kernel'57
Avoid unused local variables such as 'list'80
Avoid unused local variables such as 'uploadFile'83
Avoid unused local variables such as 'basename'86

org/apache/geronimo/console/securitymanager/realm/MasterLoginModuleInfo.java

ViolationLine
Avoid empty catch blocks108 - 110
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead.122

org/apache/geronimo/console/threads/AbstractThreadHandler.java

ViolationLine
Avoid unused private fields such as 'log'32

org/apache/geronimo/console/util/CollectionHelper.java

ViolationLine
Avoid empty catch blocks40 - 43

org/apache/geronimo/console/util/KernelHelper.java

ViolationLine
Avoid unused imports such as 'javax.management.ObjectName'20

org/apache/geronimo/console/util/PortletManager.java

ViolationLine
Avoid empty catch blocks83 - 85
Avoid empty if statements138

org/apache/geronimo/console/util/SERealmGroupHelper.java

ViolationLine
Avoid empty catch blocks57 - 58

org/apache/geronimo/console/util/SERealmUserHelper.java

ViolationLine
Avoid empty catch blocks57 - 58

org/apache/geronimo/console/webmanager/ConnectorPortlet.java

ViolationLine
Avoid unused imports such as 'javax.management.MalformedObjectNameException'26
Avoid unused imports such as 'javax.management.ObjectName'27
Avoid empty if statements118
Avoid empty if statements120
Avoid empty if statements169
Avoid empty if statements198
Avoid empty if statements201
Avoid empty if statements231
Avoid empty catch blocks333
Avoid empty if statements339
Avoid empty if statements342
Avoid empty catch blocks385
Avoid empty if statements391
Avoid empty if statements394

org/apache/geronimo/console/webmanager/WebManagerPortlet.java

ViolationLine
Avoid empty if statements71
Avoid empty if statements82

org/apache/geronimo/console/welcome/WelcomePortlet.java

ViolationLine
Avoid unused imports such as 'java.util.ArrayList'21
Avoid unused imports such as 'java.util.List'22
Avoid unused imports such as 'java.util.StringTokenizer'23
Avoid unused imports such as 'java.util.Map'24
Avoid unused imports such as 'java.util.TreeMap'25
Avoid unused imports such as 'org.apache.geronimo.console.util.PortletManager'37