Geronimo :: Core - Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
10	0	0	377

Rules

Rules	Violations	Severity
PackageHtml	2	Error
NewlineAtEndOfFile	0	Error
Translation	0	Error
JavadocMethod	82	Error
JavadocType	10	Error
JavadocVariable	31	Error
JavadocStyle	0	Error
ConstantName	0	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	0	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName	0	Error
Header headerFile: `"/home/anthill/anthill3/agent/var/jobs/projects/Geronimo_Server/modules/geronimo-core/target/checkstyle-header.txt"`	8	Error
AvoidStarImport	1	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	0	Error
FileLength	0	Error
LineLength max: `"120"`	2	Error
MethodLength	0	Error
ParameterNumber	0	Error
EmptyForIteratorPad	0	Error
NoWhitespaceAfter	5	Error
NoWhitespaceBefore	0	Error
OperatorWrap	0	Error
ParenPad	8	Error
TypecastParenPad	0	Error
TabCharacter	111	Error
WhitespaceAfter	3	Error
WhitespaceAround	5	Error
ModifierOrder	4	Error
RedundantModifier	0	Error
AvoidNestedBlocks	0	Error
EmptyBlock	1	Error
LeftCurly	1	Error
NeedBraces	2	Error
RightCurly	1	Error
AvoidInlineConditionals	0	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	0	Error
IllegalInstantiation	0	Error
InnerAssignment	0	Error
MagicNumber	0	Error
MissingSwitchDefault	0	Error
RedundantThrows	1	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
FinalClass	0	Error
HideUtilityClassConstructor	0	Error
InterfaceIsType	0	Error
VisibilityModifier	9	Error
ArrayTypeStyle	0	Error
FinalParameters	80	Error
GenericIllegalRegexp message: `"Line has trailing spaces."` format: `"\s+$"`	10	Error
TodoComment	0	Error
UpperEll	0	Error

Files

Files	I	W	E
org/apache/geronimo/validator/ValidationFailure.java	0	0	6
org/apache/geronimo/pool/ThreadPool.java	0	0	78
org/apache/geronimo/validator/Messages.java	0	0	173
org/apache/geronimo/validator/ValidationException.java	0	0	46
org/apache/geronimo/pool/package.html	0	0	1
org/apache/geronimo/validator/package.html	0	0	1
org/apache/geronimo/validator/ValidationError.java	0	0	6
org/apache/geronimo/validator/ValidationWarning.java	0	0	6
org/apache/geronimo/pool/GeronimoExecutor.java	0	0	2
org/apache/geronimo/validator/ValidationContext.java	0	0	58

Details

org/apache/geronimo/validator/ValidationFailure.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	19
	Missing a Javadoc comment.	21
	Parameter message should be final.	21
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	29

org/apache/geronimo/pool/ThreadPool.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	57
	Line has trailing spaces.	58
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	64
	Parameter poolSize should be final.	64
	Parameter poolName should be final.	64
	Parameter keepAliveTime should be final.	64
	Parameter classLoader should be final.	64
	Parameter objectName should be final.	64
	Line has trailing spaces.	73
	Missing a Javadoc comment.	84
	Missing a Javadoc comment.	88
	Missing a Javadoc comment.	92
	Missing a Javadoc comment.	96
	Missing a Javadoc comment.	100
	Missing a Javadoc comment.	104
	Missing a Javadoc comment.	125
	Line is longer than 120 characters.	126
	Missing a Javadoc comment.	126
	Missing a Javadoc comment.	127
	Missing a Javadoc comment.	129
	Missing a Javadoc comment.	133
	Missing a Javadoc comment.	137
	Parameter consumer should be final.	137
	Missing a Javadoc comment.	141
	Missing a Javadoc comment.	145
	Parameter clients should be final.	145
	Line is longer than 120 characters.	152
	Missing a Javadoc comment.	169
	Missing a Javadoc comment.	173
	Parameter command should be final.	173
	Missing a Javadoc comment.	177
	Missing a Javadoc comment.	205
	Parameter consumerName should be final.	205
	Missing a Javadoc comment.	214
	Parameter consumerName should be final.	214
	Line has trailing spaces.	222
	Missing a Javadoc comment.	223
	'{' should be on the previous line.	225
	Missing a Javadoc comment.	226
	Parameter r should be final.	226
	Parameter executor should be final.	226
	Redundant throws: 'RejectedExecutionException' is unchecked exception.	226
	'}' should be on the same line.	229
	Line has trailing spaces.	235
	Missing a Javadoc comment.	236
	Parameter wait should be final.	236
	'if' is not followed by whitespace.	238
	Missing a Javadoc comment.	245
	Missing a Javadoc comment.	249
	Missing a Javadoc comment.	252
	Missing a Javadoc comment.	264
	Must have at least one statement.	267
	Missing a Javadoc comment.	271
	Missing a Javadoc comment.	272
	Missing a Javadoc comment.	273
	Missing a Javadoc comment.	275
	Missing a Javadoc comment.	277
	Parameter poolName should be final.	277
	Parameter classLoader should be final.	277
	Missing a Javadoc comment.	282
	Parameter arg0 should be final.	282
	Missing a Javadoc comment.	288
	Missing a Javadoc comment.	293
	Missing a Javadoc comment.	294
	Missing a Javadoc comment.	295
	Missing a Javadoc comment.	297
	Parameter task should be final.	297
	Parameter classLoader should be final.	297
	Missing a Javadoc comment.	302
	Missing a Javadoc comment.	322
	Missing a Javadoc comment.	342

org/apache/geronimo/validator/Messages.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line contains a tab character.	32
	Missing a Javadoc comment.	32
	'private' modifier out of order with the JLS suggestions.	32
	Line contains a tab character.	33
	Missing a Javadoc comment.	33
	'private' modifier out of order with the JLS suggestions.	33
	Line contains a tab character.	34
	Missing a Javadoc comment.	34
	'private' modifier out of order with the JLS suggestions.	34
	Line contains a tab character.	36
	Missing a Javadoc comment.	36
	Line contains a tab character.	37
	Missing a Javadoc comment.	37
	Line contains a tab character.	38
	Missing a Javadoc comment.	38
	Line contains a tab character.	39
	Missing a Javadoc comment.	39
	Line contains a tab character.	41
	Missing a Javadoc comment.	41
	Parameter resourceName should be final.	41
	Line contains a tab character.	42
	Line contains a tab character.	43
	Line contains a tab character.	44
	Line contains a tab character.	46
	Line contains a tab character.	47
	Line contains a tab character.	48
	Line contains a tab character.	49
	Line contains a tab character.	50
	Line contains a tab character.	51
	Line contains a tab character.	52
	Line contains a tab character.	53
	Line contains a tab character.	55
	Line contains a tab character.	57
	Missing a Javadoc comment.	57
	Line contains a tab character.	58
	'if' construct must use '{}'s.	59
	Line contains a tab character.	59
	Line contains a tab character.	60
	'else' construct must use '{}'s.	61
	Line contains a tab character.	61
	Line contains a tab character.	62
	Line contains a tab character.	63
	Line contains a tab character.	64
	Line contains a tab character.	65
	Line contains a tab character.	67
	Line contains a tab character.	69
	Line contains a tab character.	70
	Line contains a tab character.	71
	Line contains a tab character.	73
	Missing a Javadoc comment.	73
	Parameter message should be final.	73
	Parameter arg1 should be final.	73
	Line contains a tab character.	74
	'{' is followed by whitespace.	74
	Line contains a tab character.	75
	Line contains a tab character.	77
	Missing a Javadoc comment.	77
	Parameter message should be final.	77
	Parameter arg1 should be final.	77
	Parameter arg2 should be final.	77
	Line contains a tab character.	78
	'{' is followed by whitespace.	78
	Line contains a tab character.	79
	Line contains a tab character.	81
	Missing a Javadoc comment.	81
	Parameter message should be final.	81
	Parameter arg1 should be final.	81
	Parameter arg2 should be final.	81
	Parameter arg3 should be final.	81
	Line contains a tab character.	82
	'{' is followed by whitespace.	82
	Line contains a tab character.	83
	Line contains a tab character.	85
	Missing a Javadoc comment.	85
	Parameter message should be final.	85
	Parameter arg1 should be final.	85
	Parameter arg2 should be final.	85
	Parameter arg3 should be final.	85
	Parameter arg4 should be final.	85
	Line contains a tab character.	86
	'{' is followed by whitespace.	86
	Line contains a tab character.	87
	Line contains a tab character.	89
	Missing a Javadoc comment.	89
	Parameter message should be final.	89
	Parameter arg1 should be final.	89
	Parameter arg2 should be final.	89
	Parameter arg3 should be final.	89
	Parameter arg4 should be final.	89
	Parameter arg5 should be final.	89
	Line contains a tab character.	90
	'{' is followed by whitespace.	90
	Line contains a tab character.	91
	Line contains a tab character.	93
	Missing a Javadoc comment.	93
	Parameter message should be final.	93
	Line contains a tab character.	94
	Line contains a tab character.	95
	Line contains a tab character.	97
	Missing a Javadoc comment.	97
	Parameter message should be final.	97
	Parameter args should be final.	97
	Line contains a tab character.	98
	Line contains a tab character.	99
	Line contains a tab character.	100
	Line contains a tab character.	101
	Line contains a tab character.	102
	Line contains a tab character.	104
	Line contains a tab character.	105
	Line contains a tab character.	107
	Line contains a tab character.	108
	Line contains a tab character.	109
	Line contains a tab character.	110
	Line contains a tab character.	111
	Line contains a tab character.	112
	Line contains a tab character.	113
	Line contains a tab character.	114
	Line contains a tab character.	115
	Line contains a tab character.	116
	Line contains a tab character.	117
	Line contains a tab character.	118
	Line contains a tab character.	119
	Line contains a tab character.	120
	Line contains a tab character.	121
	Line contains a tab character.	122
	Line contains a tab character.	124
	Missing a Javadoc comment.	124
	Parameter message should be final.	124
	Line contains a tab character.	125
	Line contains a tab character.	126
	Line contains a tab character.	127
	Line contains a tab character.	128
	Line contains a tab character.	129
	Line contains a tab character.	131
	Line contains a tab character.	132
	Line contains a tab character.	133
	Line contains a tab character.	134
	Line contains a tab character.	135
	Line contains a tab character.	136
	Line contains a tab character.	138
	Missing a Javadoc comment.	138
	'public' modifier out of order with the JLS suggestions.	138
	Parameter locale should be final.	138
	Line contains a tab character.	139
	Line contains a tab character.	140
	Line contains a tab character.	141
	Line contains a tab character.	142
	Line contains a tab character.	143
	Line contains a tab character.	144
	Line contains a tab character.	146
	Line contains a tab character.	147
	Line contains a tab character.	148
	Missing a Javadoc comment.	150
	Line contains a tab character.	150
	Line contains a tab character.	152
	Missing a Javadoc comment.	152
	Line contains a tab character.	153
	Line contains a tab character.	154
	Line contains a tab character.	156
	Missing a Javadoc comment.	156
	Parameter name should be final.	156
	Line contains a tab character.	157
	Line contains a tab character.	158
	Line contains a tab character.	160
	Missing a Javadoc comment.	160
	Line contains a tab character.	161
	Line contains a tab character.	162
	Line contains a tab character.	164
	Missing a Javadoc comment.	164
	Line contains a tab character.	165
	Line contains a tab character.	166
	Line contains a tab character.	168

org/apache/geronimo/validator/ValidationException.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	20
	Missing a Javadoc comment.	22
	Variable 'messages' must be private and have accessor methods.	22
	Missing a Javadoc comment.	24
	Variable 'details' must be private and have accessor methods.	24
	Missing a Javadoc comment.	25
	Variable 'message' must be private and have accessor methods.	25
	Missing a Javadoc comment.	27
	Variable 'prefix' must be private and have accessor methods.	27
	Missing a Javadoc comment.	30
	Parameter message should be final.	30
	Missing a Javadoc comment.	34
	Parameter arg1 should be final.	34
	Missing a Javadoc comment.	38
	Parameter arg1 should be final.	38
	Parameter arg2 should be final.	38
	Missing a Javadoc comment.	42
	Parameter arg1 should be final.	42
	Parameter arg2 should be final.	42
	Parameter arg3 should be final.	42
	Missing a Javadoc comment.	46
	Parameter arg1 should be final.	46
	Parameter arg2 should be final.	46
	Parameter arg3 should be final.	46
	Parameter arg4 should be final.	46
	Missing a Javadoc comment.	50
	Parameter arg1 should be final.	50
	Parameter arg2 should be final.	50
	Parameter arg3 should be final.	50
	Parameter arg4 should be final.	50
	Parameter arg5 should be final.	50
	Missing a Javadoc comment.	54
	Parameter arg1 should be final.	54
	Parameter arg2 should be final.	54
	Parameter arg3 should be final.	54
	Parameter arg4 should be final.	54
	Parameter arg5 should be final.	54
	Parameter arg6 should be final.	54
	Missing a Javadoc comment.	58
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	66
	Missing a Javadoc comment.	70
	Parameter level should be final.	70
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	78

org/apache/geronimo/pool/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/validator/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/validator/ValidationError.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	19
	Missing a Javadoc comment.	21
	Parameter message should be final.	21
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	29

org/apache/geronimo/validator/ValidationWarning.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	19
	Missing a Javadoc comment.	21
	Parameter message should be final.	21
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	29

org/apache/geronimo/pool/GeronimoExecutor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Expected an @return tag.	32

org/apache/geronimo/validator/ValidationContext.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Using the '.' form of import should be avoided - java.util..	19
	Missing a Javadoc comment.	21
	Line has trailing spaces.	22
	Missing a Javadoc comment.	23
	Variable 'failures' must be private and have accessor methods.	23
	Missing a Javadoc comment.	24
	Variable 'warnings' must be private and have accessor methods.	24
	Missing a Javadoc comment.	25
	Variable 'errors' must be private and have accessor methods.	25
	Missing a Javadoc comment.	27
	Variable 'attributes' must be private and have accessor methods.	27
	Missing a Javadoc comment.	29
	Variable 'jarPath' must be private and have accessor methods.	29
	Line has trailing spaces.	30
	Missing a Javadoc comment.	31
	Parameter name should be final.	31
	'{' is not preceded with whitespace.	31
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	39
	Parameter key should be final.	39
	Missing a Javadoc comment.	43
	Parameter key should be final.	43
	Parameter value should be final.	43
	Missing a Javadoc comment.	47
	Parameter key should be final.	47
	Missing a Javadoc comment.	51
	Parameter key should be final.	51
	Missing a Javadoc comment.	55
	'(' is followed by whitespace.	55
	Parameter warning should be final.	55
	')' is preceded with whitespace.	55
	'(' is followed by whitespace.	56
	')' is preceded with whitespace.	56
	Line has trailing spaces.	58
	Missing a Javadoc comment.	59
	Parameter failure should be final.	59
	'(' is followed by whitespace.	60
	')' is preceded with whitespace.	60
	Missing a Javadoc comment.	63
	Parameter error should be final.	63
	'(' is followed by whitespace.	64
	')' is preceded with whitespace.	64
	Missing a Javadoc comment.	67
	'cast' is not followed by whitespace.	68
	Line has trailing spaces.	70
	Missing a Javadoc comment.	71
	'cast' is not followed by whitespace.	72
	Line has trailing spaces.	74
	Missing a Javadoc comment.	75
	'cast' is not followed by whitespace.	76
	Missing a Javadoc comment.	79
	'{' is not preceded with whitespace.	79
	Missing a Javadoc comment.	83
	'{' is not preceded with whitespace.	83
	Line has trailing spaces.	86
	Missing a Javadoc comment.	87
	'{' is not preceded with whitespace.	87

Parent Project

Project Documentation

Checkstyle Results

Summary

Rules

Files

Details

org/apache/geronimo/validator/ValidationFailure.java

org/apache/geronimo/pool/ThreadPool.java

org/apache/geronimo/validator/Messages.java

org/apache/geronimo/validator/ValidationException.java

org/apache/geronimo/pool/package.html

org/apache/geronimo/validator/package.html

org/apache/geronimo/validator/ValidationError.java

org/apache/geronimo/validator/ValidationWarning.java

org/apache/geronimo/pool/GeronimoExecutor.java

org/apache/geronimo/validator/ValidationContext.java