Geronimo :: Deploy :: JSR-88 - Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
34	0	0	1077

Rules

Rules	Violations	Severity
PackageHtml	7	Error
NewlineAtEndOfFile	1	Error
Translation	0	Error
JavadocMethod	214	Error
JavadocType	4	Error
JavadocVariable	69	Error
JavadocStyle	3	Error
ConstantName	5	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	0	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName	0	Error
Header headerFile: `"/home/anthill/anthill3/agent/var/jobs/projects/Geronimo_Server/modules/geronimo-deploy-jsr88/target/checkstyle-header.txt"`	27	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	4	Error
FileLength	0	Error
LineLength max: `"120"`	70	Error
MethodLength	0	Error
ParameterNumber	0	Error
EmptyForIteratorPad	0	Error
NoWhitespaceAfter	0	Error
NoWhitespaceBefore	0	Error
OperatorWrap	16	Error
ParenPad	0	Error
TypecastParenPad	0	Error
TabCharacter	8	Error
WhitespaceAfter	14	Error
WhitespaceAround	277	Error
ModifierOrder	1	Error
RedundantModifier	1	Error
AvoidNestedBlocks	0	Error
EmptyBlock	11	Error
LeftCurly	0	Error
NeedBraces	14	Error
RightCurly	0	Error
AvoidInlineConditionals	11	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	8	Error
IllegalInstantiation	0	Error
InnerAssignment	2	Error
MagicNumber	8	Error
MissingSwitchDefault	0	Error
RedundantThrows	14	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
FinalClass	0	Error
HideUtilityClassConstructor	2	Error
InterfaceIsType	0	Error
VisibilityModifier	10	Error
ArrayTypeStyle	5	Error
FinalParameters	265	Error
GenericIllegalRegexp message: `"Line has trailing spaces."` format: `"\s+$"`	6	Error
TodoComment	0	Error
UpperEll	0	Error

Files

Files	I	W	E
org/apache/geronimo/deployment/plugin/jmx/JMXDeploymentManager.java	0	0	110
org/apache/geronimo/deployment/plugin/local/DistributeCommand.java	0	0	17
org/apache/geronimo/deployment/plugin/application/EARConfiguration.java	0	0	4
org/apache/geronimo/deployment/plugin/application/EARConfigurer.java	0	0	6
org/apache/geronimo/deployment/plugin/factories/AuthenticationFailedException.java	0	0	4
org/apache/geronimo/deployment/plugin/remote/RedeployCommand.java	0	0	14
org/apache/geronimo/deployment/plugin/ConfigIDExtractor.java	0	0	159
org/apache/geronimo/deployment/plugin/client/ClientConfigBean.java	0	0	6
org/apache/geronimo/deployment/plugin/remote/DistributeCommand.java	0	0	14
org/apache/geronimo/deployment/plugin/local/StartCommand.java	0	0	12
org/apache/geronimo/deployment/plugin/FailedProgressObject.java	0	0	5
org/apache/geronimo/deployment/plugin/TargetModuleIDImpl.java	0	0	40
org/apache/geronimo/deployment/plugin/factories/DeploymentFactoryImpl.java	0	0	80
org/apache/geronimo/deployment/plugin/local/package.html	0	0	1
org/apache/geronimo/deployment/plugin/jmx/RemoteDeploymentManager.java	0	0	90
org/apache/geronimo/deployment/plugin/application/package.html	0	0	1
org/apache/geronimo/deployment/plugin/jmx/CommandContext.java	0	0	30
org/apache/geronimo/deployment/plugin/jmx/LocalDeploymentManager.java	0	0	3
org/apache/geronimo/deployment/plugin/TargetImpl.java	0	0	17
org/apache/geronimo/deployment/plugin/client/package.html	0	0	1
org/apache/geronimo/deployment/plugin/package.html	0	0	1
org/apache/geronimo/deployment/plugin/DeploymentConfigurationImpl.java	0	0	21
org/apache/geronimo/deployment/plugin/local/RedeployCommand.java	0	0	89
org/apache/geronimo/deployment/plugin/local/UndeployCommand.java	0	0	24
org/apache/geronimo/deployment/plugin/jmx/package.html	0	0	1
org/apache/geronimo/deployment/plugin/remote/RemoteDeployUtil.java	0	0	67
org/apache/geronimo/deployment/plugin/remote/package.html	0	0	1
org/apache/geronimo/deployment/plugin/DisconnectedDeploymentManager.java	0	0	79
org/apache/geronimo/deployment/plugin/local/CommandSupport.java	0	0	97
org/apache/geronimo/deployment/plugin/factories/package.html	0	0	1
org/apache/geronimo/deployment/plugin/local/AbstractDeployCommand.java	0	0	63
org/apache/geronimo/deployment/plugin/application/EARConfigBean.java	0	0	4
org/apache/geronimo/deployment/plugin/GeronimoDeploymentManager.java	0	0	4
org/apache/geronimo/deployment/plugin/local/StopCommand.java	0	0	11

Details

org/apache/geronimo/deployment/plugin/jmx/JMXDeploymentManager.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	62
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	62
	Missing a Javadoc comment.	64
	Variable 'kernel' must be private and have accessor methods.	64
	Missing a Javadoc comment.	65
	Missing a Javadoc comment.	66
	Missing a Javadoc comment.	68
	Parameter kernel should be final.	68
	'kernel' hides a field.	68
	Missing a Javadoc comment.	74
	Parameter username should be final.	74
	Parameter password should be final.	74
	Missing a Javadoc comment.	79
	'if' is not followed by whitespace.	80
	Missing a Javadoc comment.	90
	Line is longer than 120 characters.	107
	Missing a Javadoc comment.	107
	Parameter targetList should be final.	107
	Parameter info should be final.	109
	Line is longer than 120 characters.	110
	Line is longer than 120 characters.	116
	Missing a Javadoc comment.	116
	Parameter targetList should be final.	116
	Parameter info should be final.	118
	Line is longer than 120 characters.	119
	Missing a Javadoc comment.	125
	Parameter targetList should be final.	125
	Parameter info should be final.	127
	Line is longer than 120 characters.	128
	Missing a Javadoc comment.	134
	Missing a Javadoc comment.	135
	Missing a Javadoc comment.	138
	Parameter targetList should be final.	138
	Parameter filter should be final.	138
	Line is longer than 120 characters.	153
	'if' is not followed by whitespace.	155
	'if' is not followed by whitespace.	158
	Avoid inline conditionals.	168
	Missing a Javadoc comment.	174
	Parameter targetList should be final.	174
	Parameter moduleArchive should be final.	174
	Parameter deploymentPlan should be final.	174
	Missing a Javadoc comment.	184
	Parameter targetList should be final.	184
	Parameter moduleArchive should be final.	184
	Parameter deploymentPlan should be final.	184
	Missing a Javadoc comment.	194
	Parameter moduleIDList should be final.	194
	Missing a Javadoc comment.	204
	Parameter moduleIDList should be final.	204
	Missing a Javadoc comment.	214
	Parameter moduleIDList should be final.	214
	Missing a Javadoc comment.	224
	Missing a Javadoc comment.	228
	Parameter moduleIDList should be final.	228
	Parameter moduleArchive should be final.	228
	Parameter deploymentPlan should be final.	228
	Line is longer than 120 characters.	238
	Missing a Javadoc comment.	238
	Parameter moduleIDList should be final.	238
	Parameter moduleArchive should be final.	238
	Parameter deploymentPlan should be final.	238
	Missing a Javadoc comment.	248
	Missing a Javadoc comment.	252
	Missing a Javadoc comment.	256
	Missing a Javadoc comment.	260
	Parameter locale should be final.	260
	Missing a Javadoc comment.	264
	Parameter locale should be final.	264
	Missing a Javadoc comment.	268
	Missing a Javadoc comment.	272
	Parameter version should be final.	272
	Missing a Javadoc comment.	276
	Parameter version should be final.	276
	Missing a Javadoc comment.	282
	Parameter dObj should be final.	282
	'if' is not followed by whitespace.	283
	Must have at least one statement.	283
	'if' is not followed by whitespace.	285
	Must have at least one statement.	285
	'if' is not followed by whitespace.	287
	Line is longer than 120 characters.	290
	'cast' is not followed by whitespace.	290
	'if' is not followed by whitespace.	294
	'if' is not followed by whitespace.	296
	Missing a Javadoc comment.	302
	Parameter targetList should be final.	302
	Parameter moduleArchive should be final.	302
	Parameter deploymentPlan should be final.	302
	Line is longer than 120 characters.	306
	Missing a Javadoc comment.	306
	Parameter targetList should be final.	306
	Parameter moduleArchive should be final.	306
	Parameter deploymentPlan should be final.	306
	Line is longer than 120 characters.	310
	Missing a Javadoc comment.	310
	Parameter moduleIDList should be final.	310
	Parameter moduleArchive should be final.	310
	Parameter deploymentPlan should be final.	310
	Line is longer than 120 characters.	314
	Missing a Javadoc comment.	314
	Parameter moduleIDList should be final.	314
	Parameter moduleArchive should be final.	314
	Parameter deploymentPlan should be final.	314
	Missing a Javadoc comment.	318
	Parameter shouldLog should be final.	318
	Parameter verboseStatus should be final.	318
	Missing a Javadoc comment.	323
	Parameter inPlace should be final.	323

org/apache/geronimo/deployment/plugin/local/DistributeCommand.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	32
	Variable 'targetList' must be private and have accessor methods.	32
	Missing a Javadoc comment.	34
	Parameter kernel should be final.	34
	Parameter targetList should be final.	34
	Parameter moduleArchive should be final.	34
	Parameter deploymentPlan should be final.	34
	Line is longer than 120 characters.	39
	Missing a Javadoc comment.	39
	Parameter kernel should be final.	39
	Parameter targetList should be final.	39
	Parameter moduleStream should be final.	39
	Parameter deploymentStream should be final.	39
	Missing a Javadoc comment.	44
	'for' is not followed by whitespace.	59
	Line contains a tab character.	60

org/apache/geronimo/deployment/plugin/application/EARConfiguration.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	'{' is not preceded with whitespace.	29
	Missing a Javadoc comment.	30
	Parameter deployable should be final.	30

org/apache/geronimo/deployment/plugin/application/EARConfigurer.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	35
	Parameter deployable should be final.	35
	Missing a Javadoc comment.	43
	Line is longer than 120 characters.	46
	Missing a Javadoc comment.	51

org/apache/geronimo/deployment/plugin/factories/AuthenticationFailedException.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	25
	Missing a Javadoc comment.	29
	Parameter s should be final.	29

org/apache/geronimo/deployment/plugin/remote/RedeployCommand.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	32
	Parameter kernel should be final.	32
	Parameter moduleIDList should be final.	32
	Parameter moduleArchive should be final.	32
	Parameter deploymentPlan should be final.	32
	Line is longer than 120 characters.	36
	Missing a Javadoc comment.	36
	Parameter kernel should be final.	36
	Parameter moduleIDList should be final.	36
	Parameter moduleArchive should be final.	36
	Parameter deploymentPlan should be final.	36
	Missing a Javadoc comment.	40
	Parameter inputs should be final.	40

org/apache/geronimo/deployment/plugin/ConfigIDExtractor.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	First sentence should end with a period.	47
	Utility classes should not have a public or default constructor.	52
	Missing a Javadoc comment.	54
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	54
	Parameter module should be final.	72
	Expected @throws tag for 'IOException'.	72
	Expected @throws tag for 'DeploymentException'.	72
	'if' is not followed by whitespace.	73
	'+' is not preceded with whitespace.	74
	'+' is not followed by whitespace.	74
	'+' is not preceded with whitespace.	74
	'+' is not followed by whitespace.	74
	'if' is not followed by whitespace.	76
	'if' is not followed by whitespace.	78
	'if' is not followed by whitespace.	80
	'if' is not followed by whitespace.	82
	'if' is not followed by whitespace.	84
	'if' is not followed by whitespace.	86
	'if' is not followed by whitespace.	91
	'if' is not followed by whitespace.	94
	'if' is not followed by whitespace.	96
	Line is longer than 120 characters.	97
	'if' is not followed by whitespace.	103
	'+' is not preceded with whitespace.	104
	'+' is not followed by whitespace.	104
	'if' is not followed by whitespace.	112
	'if' is not followed by whitespace.	114
	'if' is not followed by whitespace.	116
	'if' is not followed by whitespace.	118
	'if' is not followed by whitespace.	120
	'if' is not followed by whitespace.	125
	'if' is not followed by whitespace.	128
	'if' is not followed by whitespace.	130
	Line is longer than 120 characters.	131
	Parameter plan should be final.	150
	Expected @throws tag for 'IOException'.	150
	'if' is not followed by whitespace.	151
	'+' is not preceded with whitespace.	152
	'+' is not followed by whitespace.	152
	Expected an @return tag.	171
	Line is longer than 120 characters.	171
	Parameter allModules should be final.	171
	Parameter name should be final.	171
	Parameter fromPlan should be final.	171
	'if' is not followed by whitespace.	174
	Inner assignments should be avoided.	174
	'+' is not preceded with whitespace.	176
	'+' is not followed by whitespace.	176
	Line is longer than 120 characters.	178
	Avoid inline conditionals.	178
	Avoid inline conditionals.	179
	'cast' is not followed by whitespace.	179
	'for' is not followed by whitespace.	181
	'=' is not preceded with whitespace.	181
	'=' is not followed by whitespace.	181
	'<' is not preceded with whitespace.	181
	'<' is not followed by whitespace.	181
	Line is longer than 120 characters.	182
	'if' is not followed by whitespace.	182
	'if' is not followed by whitespace.	187
	Line is longer than 120 characters.	194
	Avoid inline conditionals.	194
	Avoid inline conditionals.	195
	'cast' is not followed by whitespace.	195
	Avoid inline conditionals.	197
	'cast' is not followed by whitespace.	197
	'for' is not followed by whitespace.	199
	'if' is not followed by whitespace.	200
	'if' is not followed by whitespace.	204
	'+' is not preceded with whitespace.	205
	'+' is not followed by whitespace.	205
	'+' should be on a new line.	205
	'+' should be on a new line.	206
	'+' should be on a new line.	207
	'+' should be on a new line.	208
	Missing a Javadoc comment.	214
	Parameter plan should be final.	214
	'if' is not followed by whitespace.	222
	Line is longer than 120 characters.	223
	'+' is not preceded with whitespace.	227
	'+' is not followed by whitespace.	227
	'+' is not preceded with whitespace.	229
	'+' is not followed by whitespace.	229
	Expected an @return tag.	240
	Parameter file should be final.	240
	Expected @param tag for 'file'.	240
	Expected @throws tag for 'DeploymentException'.	240
	'+' is not preceded with whitespace.	244
	'+' is not followed by whitespace.	244
	Missing a Javadoc comment.	248
	Missing a Javadoc comment.	249
	Missing a Javadoc comment.	250
	Missing a Javadoc comment.	251
	Missing a Javadoc comment.	252
	Missing a Javadoc comment.	253
	Missing a Javadoc comment.	254
	Missing a Javadoc comment.	255
	Line is longer than 120 characters.	257
	Missing a Javadoc comment.	257
	Parameter uri should be final.	257
	Parameter localName should be final.	257
	Parameter qName should be final.	257
	Parameter attributes should be final.	257
	'if' is not followed by whitespace.	258
	'if' is not followed by whitespace.	261
	Line is longer than 120 characters.	262
	'if' is not followed by whitespace.	262
	'if' is not followed by whitespace.	266
	'if' is not followed by whitespace.	269
	Missing a Javadoc comment.	278
	Parameter namespace should be final.	278
	'if' is not followed by whitespace.	279
	'if' is not followed by whitespace.	281
	'if' is not followed by whitespace.	283
	'if' is not followed by whitespace.	285
	'if' is not followed by whitespace.	287
	Missing a Javadoc comment.	294
	Parameter ch should be final.	294
	Array brackets at illegal position.	294
	Parameter start should be final.	294
	Parameter length should be final.	294
	'if' is not followed by whitespace.	295
	'if' construct must use '{}'s.	297
	'if' is not followed by whitespace.	297
	'if' construct must use '{}'s.	298
	'if' is not followed by whitespace.	298
	'if' construct must use '{}'s.	299
	'if' is not followed by whitespace.	299
	'if' construct must use '{}'s.	300
	'if' is not followed by whitespace.	300
	Missing a Javadoc comment.	304
	Parameter uri should be final.	304
	Parameter localName should be final.	304
	Parameter qName should be final.	304
	'if' is not followed by whitespace.	306
	'if' is not followed by whitespace.	309
	'+' is not preceded with whitespace.	312
	'+' is not followed by whitespace.	312
	'+' is not preceded with whitespace.	312
	'+' is not followed by whitespace.	312
	'+' is not preceded with whitespace.	312
	'+' is not followed by whitespace.	312
	Missing a Javadoc comment.	316
	'if' is not followed by whitespace.	317
	'if' is not followed by whitespace.	318
	'+' is not preceded with whitespace.	321
	'+' is not followed by whitespace.	321
	'+' is not preceded with whitespace.	321
	'+' is not followed by whitespace.	321
	'+' is not preceded with whitespace.	321
	'+' is not followed by whitespace.	321
	'+' is not preceded with whitespace.	321
	'+' is not followed by whitespace.	321
	'+' is not preceded with whitespace.	321
	'+' is not followed by whitespace.	321
	'+' is not preceded with whitespace.	321
	'+' is not followed by whitespace.	321
	'if' is not followed by whitespace.	323

org/apache/geronimo/deployment/plugin/client/ClientConfigBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	36
	Parameter ddBean should be final.	36
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	44

org/apache/geronimo/deployment/plugin/remote/DistributeCommand.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	32
	Parameter kernel should be final.	32
	Parameter targetList should be final.	32
	Parameter moduleArchive should be final.	32
	Parameter deploymentPlan should be final.	32
	Line is longer than 120 characters.	36
	Missing a Javadoc comment.	36
	Parameter kernel should be final.	36
	Parameter targetList should be final.	36
	Parameter moduleStream should be final.	36
	Parameter deploymentStream should be final.	36
	Missing a Javadoc comment.	40
	Parameter inputs should be final.	40

org/apache/geronimo/deployment/plugin/local/StartCommand.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Unused import - org.apache.geronimo.kernel.config.Configuration.	27
	Unused import - org.apache.geronimo.gbean.AbstractName.	31
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Parameter kernel should be final.	40
	Parameter modules should be final.	40
	Array brackets at illegal position.	40
	Missing a Javadoc comment.	46
	'100' is a magic number.	57
	'if' is not followed by whitespace.	62

org/apache/geronimo/deployment/plugin/FailedProgressObject.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	30
	Parameter command should be final.	30
	Parameter message should be final.	30
	Missing a Javadoc comment.	35

org/apache/geronimo/deployment/plugin/TargetModuleIDImpl.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	26
	Line has trailing spaces.	27
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Parameter target should be final.	38
	Parameter moduleID should be final.	38
	Missing a Javadoc comment.	45
	Parameter target should be final.	45
	Parameter moduleID should be final.	45
	Parameter childIDs should be final.	45
	'if' is not followed by whitespace.	49
	Missing a Javadoc comment.	60
	Parameter target should be final.	60
	Parameter moduleID should be final.	60
	Parameter parent should be final.	60
	Missing a Javadoc comment.	67
	Missing a Javadoc comment.	71
	Missing a Javadoc comment.	75
	Missing a Javadoc comment.	79
	Missing a Javadoc comment.	83
	Missing a Javadoc comment.	87
	Parameter webURL should be final.	87
	Missing a Javadoc comment.	91
	Missing a Javadoc comment.	95
	Parameter type should be final.	95
	Missing a Javadoc comment.	99
	Missing a Javadoc comment.	103
	Parameter o should be final.	103
	'if' construct must use '{}'s.	104
	'if' construct must use '{}'s.	105
	'if' construct must use '{}'s.	109
	'if' construct must use '{}'s.	110
	Missing a Javadoc comment.	115
	'29' is a magic number.	118

org/apache/geronimo/deployment/plugin/factories/DeploymentFactoryImpl.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	48
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	48
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	61
	Parameter uri should be final.	61
	Missing a Javadoc comment.	65
	Parameter uri should be final.	65
	'if' is not followed by whitespace.	67
	Avoid inline conditionals.	72
	Avoid inline conditionals.	73
	'+' is not preceded with whitespace.	73
	'+' is not followed by whitespace.	73
	'if' is not followed by whitespace.	74
	'if' is not followed by whitespace.	75
	'if' is not followed by whitespace.	80
	Avoid inline conditionals.	81
	'if' is not followed by whitespace.	83
	'+' is not preceded with whitespace.	83
	'+' is not followed by whitespace.	83
	'if' is not followed by whitespace.	86
	'+' is not preceded with whitespace.	86
	'+' is not followed by whitespace.	86
	'+' is not preceded with whitespace.	90
	'+' is not followed by whitespace.	90
	Avoid inline conditionals.	92
	'if' is not followed by whitespace.	96
	'if' is not followed by whitespace.	97
	Line is longer than 120 characters.	102
	Avoid inline conditionals.	102
	'else' construct must use '{}'s.	105
	Missing a Javadoc comment.	108
	Parameter uri should be final.	108
	Line is longer than 120 characters.	116
	Missing a Javadoc comment.	116
	Parameter uri should be final.	116
	Parameter username should be final.	116
	Parameter password should be final.	116
	Line is longer than 120 characters.	128
	'+' is not preceded with whitespace.	128
	'+' is not followed by whitespace.	128
	'+' is not preceded with whitespace.	128
	'+' is not followed by whitespace.	128
	'+' is not preceded with whitespace.	128
	'+' is not followed by whitespace.	128
	'+' is not preceded with whitespace.	128
	'+' is not followed by whitespace.	128
	'if' is not followed by whitespace.	131
	Line is longer than 120 characters.	136
	'cast' is not followed by whitespace.	136
	Line is longer than 120 characters.	138
	'if' is not followed by whitespace.	140
	Missing a Javadoc comment.	161
	'static' modifier out of order with the JLS suggestions.	161
	Missing a Javadoc comment.	162
	Missing a Javadoc comment.	163
	Missing a Javadoc comment.	164
	Missing a Javadoc comment.	166
	Parameter protocol should be final.	166
	Parameter host should be final.	166
	Parameter port should be final.	166
	Missing a Javadoc comment.	172
	Missing a Javadoc comment.	176
	Missing a Javadoc comment.	180
	Missing a Javadoc comment.	184
	'+' is not preceded with whitespace.	185
	'+' is not followed by whitespace.	185
	'+' is not preceded with whitespace.	185
	'+' is not followed by whitespace.	185
	'+' is not preceded with whitespace.	185
	'+' is not followed by whitespace.	185
	'+' is not preceded with whitespace.	185
	'+' is not followed by whitespace.	185
	Missing a Javadoc comment.	189
	Parameter args should be final.	189
	'+' is not preceded with whitespace.	190
	'+' is not followed by whitespace.	190

org/apache/geronimo/deployment/plugin/local/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/deployment/plugin/jmx/RemoteDeploymentManager.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	65
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	65
	Missing a Javadoc comment.	67
	Missing a Javadoc comment.	68
	Missing a Javadoc comment.	70
	Parameter jmxConnector should be final.	70
	Parameter hostname should be final.	70
	Missing a Javadoc comment.	77
	Missing a Javadoc comment.	81
	Parameter hostname should be final.	81
	'if' is not followed by whitespace.	83
	'while' is not followed by whitespace.	90
	'if' is not followed by whitespace.	95
	Line is longer than 120 characters.	101
	'+' is not preceded with whitespace.	101
	'+' is not followed by whitespace.	101
	'+' is not preceded with whitespace.	101
	'+' is not followed by whitespace.	101
	Missing a Javadoc comment.	105
	Missing a Javadoc comment.	115
	Parameter targetList should be final.	115
	Parameter moduleArchive should be final.	115
	Parameter deploymentPlan should be final.	115
	'if' is not followed by whitespace.	116
	Line is longer than 120 characters.	119
	Line is longer than 120 characters.	123
	Missing a Javadoc comment.	123
	Parameter targetList should be final.	123
	Parameter moduleArchive should be final.	123
	Parameter deploymentPlan should be final.	123
	'if' is not followed by whitespace.	124
	Line is longer than 120 characters.	127
	Line is longer than 120 characters.	131
	Missing a Javadoc comment.	131
	Parameter moduleIDList should be final.	131
	Parameter moduleArchive should be final.	131
	Parameter deploymentPlan should be final.	131
	'if' is not followed by whitespace.	132
	Line is longer than 120 characters.	135
	Line is longer than 120 characters.	139
	Missing a Javadoc comment.	139
	Parameter moduleIDList should be final.	139
	Parameter moduleArchive should be final.	139
	Parameter deploymentPlan should be final.	139
	'if' is not followed by whitespace.	140
	Line is longer than 120 characters.	143
	Line is longer than 120 characters.	147
	Missing a Javadoc comment.	147
	Parameter mavenRepository should be final.	147
	Parameter username should be final.	147
	Parameter password should be final.	147
	Line is longer than 120 characters.	151
	Missing a Javadoc comment.	159
	Parameter installList should be final.	159
	Parameter username should be final.	159
	Parameter password should be final.	159
	Line is longer than 120 characters.	163
	Missing a Javadoc comment.	171
	Parameter configsToInstall should be final.	171
	Parameter username should be final.	171
	Parameter password should be final.	171
	Parameter poller should be final.	171
	Line is longer than 120 characters.	175
	Missing a Javadoc comment.	182
	Parameter configsToInstall should be final.	182
	Parameter username should be final.	182
	Parameter password should be final.	182
	Line is longer than 120 characters.	186
	Missing a Javadoc comment.	194
	Parameter carFile should be final.	194
	Parameter username should be final.	194
	Parameter password should be final.	194
	'if' is not followed by whitespace.	196
	Line is longer than 120 characters.	197
	Parameter event should be final.	202
	Line is longer than 120 characters.	211
	Missing a Javadoc comment.	219
	Parameter key should be final.	219
	Line is longer than 120 characters.	223
	Missing a Javadoc comment.	231
	Line is longer than 120 characters.	235
	Missing a Javadoc comment.	243
	Parameter configId should be final.	243
	Line is longer than 120 characters.	247
	Missing a Javadoc comment.	255
	Parameter metadata should be final.	255
	Line is longer than 120 characters.	259
	Missing a Javadoc comment.	266
	Line is longer than 120 characters.	271

org/apache/geronimo/deployment/plugin/application/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/deployment/plugin/jmx/CommandContext.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	27
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	30
	Parameter logErrors should be final.	30
	Parameter verbose should be final.	31
	Parameter username should be final.	32
	Parameter password should be final.	33
	Parameter inPlace should be final.	34
	Missing a Javadoc comment.	42
	Parameter prototype should be final.	42
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	54
	Parameter logErrors should be final.	54
	Missing a Javadoc comment.	58
	Missing a Javadoc comment.	62
	Parameter verbose should be final.	62
	Missing a Javadoc comment.	66
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	74
	Parameter username should be final.	74
	Missing a Javadoc comment.	78
	Parameter password should be final.	78
	Missing a Javadoc comment.	82
	Missing a Javadoc comment.	86
	Parameter inPlace should be final.	86

org/apache/geronimo/deployment/plugin/jmx/LocalDeploymentManager.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	27
	Parameter kernel should be final.	27

org/apache/geronimo/deployment/plugin/TargetImpl.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Unused import - javax.management.ObjectName.	21
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Parameter name should be final.	34
	Parameter description should be final.	34
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	55
	Parameter o should be final.	55
	'if' construct must use '{}'s.	56
	'if' construct must use '{}'s.	57
	'if' construct must use '{}'s.	61
	Missing a Javadoc comment.	66

org/apache/geronimo/deployment/plugin/client/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/deployment/plugin/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/deployment/plugin/DeploymentConfigurationImpl.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	30
	Line has trailing spaces.	31
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37
	Parameter deployable should be final.	37
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	45
	Parameter bean should be final.	45
	Missing a Javadoc comment.	49
	Parameter bean should be final.	49
	Missing a Javadoc comment.	52
	Parameter outputArchive should be final.	52
	Missing a Javadoc comment.	55
	Parameter inputArchive should be final.	55
	Missing a Javadoc comment.	58
	Parameter outputArchive should be final.	58
	Parameter bean should be final.	58
	Missing a Javadoc comment.	61
	Parameter inputArchive should be final.	61
	Parameter bean should be final.	61

org/apache/geronimo/deployment/plugin/local/RedeployCommand.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	47
	Parameter kernel should be final.	47
	Parameter moduleIDList should be final.	47
	Parameter moduleArchive should be final.	47
	Parameter deploymentPlan should be final.	47
	Line is longer than 120 characters.	52
	Missing a Javadoc comment.	52
	Parameter kernel should be final.	52
	Parameter moduleIDList should be final.	52
	Parameter moduleArchive should be final.	52
	Parameter deploymentPlan should be final.	52
	Missing a Javadoc comment.	57
	'if' is not followed by whitespace.	74
	'if' is not followed by whitespace.	76
	'if' is not followed by whitespace.	81
	'if' is not followed by whitespace.	85
	'if' is not followed by whitespace.	95
	'if' is not followed by whitespace.	96
	'&&' should be on a new line.	96
	'&&' should be on a new line.	97
	Line is longer than 120 characters.	126
	Missing a Javadoc comment.	126
	Parameter manager should be final.	126
	Parameter previous should be final.	126
	Parameter target should be final.	126
	Redundant throws: 'NoSuchConfigException' is subclass of 'Exception'.	126
	Line is longer than 120 characters.	133
	'+' is not preceded with whitespace.	144
	'+' is not followed by whitespace.	144
	'+' is not preceded with whitespace.	148
	'+' is not followed by whitespace.	148
	'+' is not preceded with whitespace.	152
	'+' is not followed by whitespace.	152
	'+' is not preceded with whitespace.	156
	'+' is not followed by whitespace.	156
	'if' is not followed by whitespace.	157
	'+' is not preceded with whitespace.	163
	'+' is not followed by whitespace.	163
	'+' is not preceded with whitespace.	163
	'+' is not followed by whitespace.	163
	'+' is not preceded with whitespace.	163
	'+' is not followed by whitespace.	163
	'cast' is not followed by whitespace.	164
	'if' is not followed by whitespace.	166
	Line is longer than 120 characters.	171
	Missing a Javadoc comment.	171
	Parameter configurationManager should be final.	171
	Parameter configID should be final.	171
	Parameter target should be final.	171
	'if' is not followed by whitespace.	172
	Line is longer than 120 characters.	173
	'+' is not preceded with whitespace.	173
	'+' is not followed by whitespace.	173
	'+' is not preceded with whitespace.	173
	'+' is not followed by whitespace.	173
	'+' is not preceded with whitespace.	177
	'+' is not followed by whitespace.	177
	'cast' is not followed by whitespace.	179
	'if' is not followed by whitespace.	180
	Must have at least one statement.	180
	'catch' is not followed by whitespace.	185
	Must have at least one statement.	185
	'+' is not preceded with whitespace.	190
	'+' is not followed by whitespace.	190
	'catch' is not followed by whitespace.	191
	'cast' is not followed by whitespace.	192
	'if' is not followed by whitespace.	193
	Must have at least one statement.	193
	Must have at least one statement.	198
	Line is longer than 120 characters.	206
	'+' is not preceded with whitespace.	211
	'+' is not followed by whitespace.	211
	'catch' is not followed by whitespace.	212
	'cast' is not followed by whitespace.	213
	'if' is not followed by whitespace.	214
	'+' is not preceded with whitespace.	215
	'+' is not followed by whitespace.	215
	'+' is not preceded with whitespace.	215
	'+' is not followed by whitespace.	215
	'+' is not preceded with whitespace.	220
	'+' is not followed by whitespace.	220
	'+' is not preceded with whitespace.	220
	'+' is not followed by whitespace.	220
	'+' is not preceded with whitespace.	224
	'+' is not followed by whitespace.	224

org/apache/geronimo/deployment/plugin/local/UndeployCommand.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Parameter kernel should be final.	40
	Parameter modules should be final.	40
	Array brackets at illegal position.	40
	Missing a Javadoc comment.	46
	Line contains a tab character.	55
	'if' is not followed by whitespace.	55
	Line is longer than 120 characters.	56
	Line contains a tab character.	56
	Line is longer than 120 characters.	57
	Line contains a tab character.	57
	Line contains a tab character.	58
	Line contains a tab character.	59
	Line contains a tab character.	60
	Line has trailing spaces.	61
	Line contains a tab character.	61
	Must have at least one statement.	67
	Must have at least one statement.	69
	Must have at least one statement.	77
	Line is longer than 120 characters.	87

org/apache/geronimo/deployment/plugin/jmx/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/deployment/plugin/remote/RemoteDeployUtil.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	35
	Utility classes should not have a public or default constructor.	40
	Missing a Javadoc comment.	41
	Parameter files should be final.	41
	Parameter progress should be final.	41
	'if' is not followed by whitespace.	42
	'for' is not followed by whitespace.	46
	'=' is not preceded with whitespace.	46
	'=' is not followed by whitespace.	46
	'<' is not preceded with whitespace.	46
	'<' is not followed by whitespace.	46
	'if' is not followed by whitespace.	47
	'if' is not followed by whitespace.	51
	'if' is not followed by whitespace.	56
	'+' is not preceded with whitespace.	57
	'+' is not followed by whitespace.	57
	'+' is not preceded with whitespace.	57
	'+' is not followed by whitespace.	57
	Line is longer than 120 characters.	60
	'1024' is a magic number.	63
	Inner assignments should be avoided.	68
	'cast' is not followed by whitespace.	68
	'100' is a magic number.	69
	'10240' is a magic number.	69
	'while' is not followed by whitespace.	73
	'if' is not followed by whitespace.	76
	'+' is not preceded with whitespace.	77
	'+' is not followed by whitespace.	77
	'+' is not preceded with whitespace.	77
	'+' is not followed by whitespace.	77
	'+' is not preceded with whitespace.	77
	'+' is not followed by whitespace.	77
	'/' is not preceded with whitespace.	77
	'/' is not followed by whitespace.	77
	'1024' is a magic number.	77
	'+' is not preceded with whitespace.	77
	'+' is not followed by whitespace.	77
	'while' construct must use '{}'s.	78
	'while' is not followed by whitespace.	78
	'if' is not followed by whitespace.	86
	'+' is not preceded with whitespace.	87
	'+' is not followed by whitespace.	87
	'+' is not preceded with whitespace.	90
	'+' is not followed by whitespace.	90
	'+' is not preceded with whitespace.	90
	'+' is not followed by whitespace.	90
	'if' is not followed by whitespace.	92
	'+' is not preceded with whitespace.	93
	'+' is not followed by whitespace.	93
	'+' is not preceded with whitespace.	93
	'+' is not followed by whitespace.	93
	'+' is not preceded with whitespace.	93
	'+' is not followed by whitespace.	93
	'+' is not preceded with whitespace.	93
	'+' is not followed by whitespace.	93
	'+' is not preceded with whitespace.	101
	'+' is not followed by whitespace.	101
	Missing a Javadoc comment.	108
	Parameter url should be final.	108
	Parameter username should be final.	108
	Parameter password should be final.	108
	'while' construct must use '{}'s.	113
	'while' is not followed by whitespace.	113
	'4' is a magic number.	113
	'+' is not preceded with whitespace.	114
	'+' is not followed by whitespace.	114

org/apache/geronimo/deployment/plugin/remote/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/deployment/plugin/DisconnectedDeploymentManager.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	47
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	47
	Missing a Javadoc comment.	49
	Parameter dObj should be final.	49
	'if' is not followed by whitespace.	50
	Must have at least one statement.	50
	'if' is not followed by whitespace.	52
	Must have at least one statement.	52
	'if' is not followed by whitespace.	54
	Line is longer than 120 characters.	57
	'cast' is not followed by whitespace.	57
	'if' is not followed by whitespace.	61
	'if' is not followed by whitespace.	63
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	78
	Missing a Javadoc comment.	82
	Parameter locale should be final.	82
	Missing a Javadoc comment.	86
	Parameter locale should be final.	86
	Missing a Javadoc comment.	92
	Missing a Javadoc comment.	96
	Parameter version should be final.	96
	Missing a Javadoc comment.	100
	Parameter version should be final.	100
	Missing a Javadoc comment.	106
	Redundant throws: 'IllegalStateException' is unchecked exception.	106
	Line is longer than 120 characters.	110
	Missing a Javadoc comment.	110
	Parameter moduleType should be final.	110
	Parameter targets should be final.	110
	Redundant throws: 'IllegalStateException' is unchecked exception.	110
	Line is longer than 120 characters.	114
	Missing a Javadoc comment.	114
	Parameter moduleType should be final.	114
	Parameter targets should be final.	114
	Redundant throws: 'IllegalStateException' is unchecked exception.	114
	Line is longer than 120 characters.	118
	Missing a Javadoc comment.	118
	Parameter moduleType should be final.	118
	Parameter targets should be final.	118
	Redundant throws: 'IllegalStateException' is unchecked exception.	118
	Missing a Javadoc comment.	122
	Parameter targets should be final.	122
	Parameter file should be final.	122
	Parameter file1 should be final.	122
	Redundant throws: 'IllegalStateException' is unchecked exception.	122
	Line is longer than 120 characters.	126
	Missing a Javadoc comment.	126
	Parameter targets should be final.	126
	Parameter inputStream should be final.	126
	Parameter inputStream1 should be final.	126
	Redundant throws: 'IllegalStateException' is unchecked exception.	126
	Missing a Javadoc comment.	130
	Parameter targetModuleIDs should be final.	130
	Redundant throws: 'IllegalStateException' is unchecked exception.	130
	Missing a Javadoc comment.	134
	Parameter targetModuleIDs should be final.	134
	Redundant throws: 'IllegalStateException' is unchecked exception.	134
	Missing a Javadoc comment.	138
	Parameter targetModuleIDs should be final.	138
	Redundant throws: 'IllegalStateException' is unchecked exception.	138
	Missing a Javadoc comment.	142
	Line is longer than 120 characters.	146
	Missing a Javadoc comment.	146
	Parameter targetModuleIDs should be final.	146
	Parameter file should be final.	146
	Parameter file1 should be final.	146
	Redundant throws: 'UnsupportedOperationException' is unchecked exception.	146
	Redundant throws: 'IllegalStateException' is unchecked exception.	146
	Line is longer than 120 characters.	150
	Missing a Javadoc comment.	150
	Parameter targetModuleIDs should be final.	150
	Parameter inputStream should be final.	150
	Parameter inputStream1 should be final.	150
	Redundant throws: 'UnsupportedOperationException' is unchecked exception.	150
	Redundant throws: 'IllegalStateException' is unchecked exception.	150
	Missing a Javadoc comment.	154

org/apache/geronimo/deployment/plugin/local/CommandSupport.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	58
	Missing a Javadoc comment.	59
	Variable 'commandContext' must be private and have accessor methods.	59
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	63
	Parameter command should be final.	63
	Missing a Javadoc comment.	70
	Parameter moduleID should be final.	70
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	78
	Missing a Javadoc comment.	82
	Missing a Javadoc comment.	86
	Parameter id should be final.	86
	Missing a Javadoc comment.	90
	Missing a Javadoc comment.	94
	Missing a Javadoc comment.	98
	Missing a Javadoc comment.	102
	Missing a Javadoc comment.	106
	Parameter pol should be final.	106
	'event' hides a field.	107
	'if' is not followed by whitespace.	112
	Missing a Javadoc comment.	117
	Parameter pol should be final.	117
	Missing a Javadoc comment.	121
	Parameter message should be final.	121
	'message' hides a field.	121
	Missing a Javadoc comment.	125
	Parameter message should be final.	125
	'message' hides a field.	125
	Missing a Javadoc comment.	129
	Parameter message should be final.	129
	'message' hides a field.	129
	Missing a Javadoc comment.	133
	Parameter e should be final.	133
	'cast' is not followed by whitespace.	135
	'if' is not followed by whitespace.	136
	Missing a Javadoc comment.	162
	Parameter message should be final.	162
	'message' hides a field.	162
	Parameter state should be final.	162
	'state' hides a field.	162
	Missing a Javadoc comment.	180
	Parameter value should be final.	180
	'if' is not followed by whitespace.	181
	'-' is not preceded with whitespace.	182
	'-' is not followed by whitespace.	182
	Missing a Javadoc comment.	187
	Missing a Javadoc comment.	188
	Missing a Javadoc comment.	189
	Missing a Javadoc comment.	190
	Missing a Javadoc comment.	191
	Missing a Javadoc comment.	193
	Parameter command should be final.	193
	Parameter action should be final.	193
	Parameter state should be final.	193
	Parameter message should be final.	193
	Missing a Javadoc comment.	200
	Missing a Javadoc comment.	204
	Missing a Javadoc comment.	208
	Missing a Javadoc comment.	212
	Missing a Javadoc comment.	216
	Missing a Javadoc comment.	220
	Missing a Javadoc comment.	224
	Missing a Javadoc comment.	228
	Missing a Javadoc comment.	241
	Missing a Javadoc comment.	245
	Parameter commandContext should be final.	245
	Missing a Javadoc comment.	249
	Parameter type should be final.	249
	'if' is not followed by whitespace.	250
	'if' is not followed by whitespace.	253
	'if' is not followed by whitespace.	256
	'if' is not followed by whitespace.	259
	'if' is not followed by whitespace.	262
	Missing a Javadoc comment.	268
	Parameter kernel should be final.	268
	Parameter configName should be final.	268
	Missing a Javadoc comment.	276
	Parameter kernel should be final.	276
	Parameter kernel should be final.	284
	Expected @param tag for 'kernel'.	284
	Parameter moduleIDs should be final.	284
	Expected @param tag for 'moduleIDs'.	284
	'if' is not followed by whitespace.	288
	'if' is not followed by whitespace.	289
	Line is longer than 120 characters.	290
	'if' is not followed by whitespace.	294
	'if' is not followed by whitespace.	303
	Missing a Javadoc comment.	309
	Parameter kernel should be final.	309
	Parameter configName should be final.	309

org/apache/geronimo/deployment/plugin/factories/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/deployment/plugin/local/AbstractDeployCommand.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Unused import - org.apache.geronimo.deployment.Deployer.	33
	Missing a Javadoc comment.	43
	Variable 'kernel' must be private and have accessor methods.	43
	Line is longer than 120 characters.	44
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	45
	Variable 'spool' must be private and have accessor methods.	45
	Missing a Javadoc comment.	46
	Variable 'moduleArchive' must be private and have accessor methods.	46
	Missing a Javadoc comment.	47
	Variable 'deploymentPlan' must be private and have accessor methods.	47
	Missing a Javadoc comment.	48
	Variable 'moduleStream' must be private and have accessor methods.	48
	Missing a Javadoc comment.	49
	Variable 'deploymentStream' must be private and have accessor methods.	49
	Missing a Javadoc comment.	50
	Variable 'deployer' must be private and have accessor methods.	50
	Line is longer than 120 characters.	52
	Missing a Javadoc comment.	52
	Parameter command should be final.	52
	Parameter kernel should be final.	52
	Parameter moduleArchive should be final.	52
	Parameter deploymentPlan should be final.	52
	Parameter moduleStream should be final.	52
	Parameter deploymentStream should be final.	52
	Parameter spool should be final.	52
	Missing a Javadoc comment.	63
	'+' should be on a new line.	66
	'+' should be on a new line.	67
	'+' should be on a new line.	68
	'+' should be on a new line.	69
	'+' should be on a new line.	70
	'+' should be on a new line.	71
	'+' should be on a new line.	72
	'+' should be on a new line.	73
	'+' should be on a new line.	74
	'+' should be on a new line.	75
	'deployer' hides a field.	80
	Missing a Javadoc comment.	89
	Parameter outfile should be final.	89
	Parameter is should be final.	89
	'4096' is a magic number.	90
	Missing a Javadoc comment.	102
	Parameter target should be final.	102
	Parameter finished should be final.	102
	Line is longer than 120 characters.	105
	Array brackets at illegal position.	105
	'-' is not preceded with whitespace.	111
	'-' is not followed by whitespace.	111
	'=' is not preceded with whitespace.	112
	'=' is not followed by whitespace.	112
	'cast' is not followed by whitespace.	113
	'+' is not preceded with whitespace.	113
	'+' is not followed by whitespace.	113
	'if' is not followed by whitespace.	117
	'if' is not followed by whitespace.	120
	'if' is not followed by whitespace.	123
	'if' is not followed by whitespace.	129
	Missing a Javadoc comment.	135
	Parameter inputs should be final.	135
	Missing a Javadoc comment.	138
	'cast' is not followed by whitespace.	139

org/apache/geronimo/deployment/plugin/application/EARConfigBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	31
	Parameter ddBean should be final.	31
	Missing a Javadoc comment.	35

org/apache/geronimo/deployment/plugin/GeronimoDeploymentManager.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	24
	Missing a Javadoc comment.	30
	Redundant 'public' modifier.	30

org/apache/geronimo/deployment/plugin/local/StopCommand.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	35
	Parameter kernel should be final.	35
	Parameter modules should be final.	35
	Array brackets at illegal position.	35
	Missing a Javadoc comment.	41
	'if' is not followed by whitespace.	48
	'if' is not followed by whitespace.	51
	'if' is not followed by whitespace.	59

Parent Project

Project Documentation

Checkstyle Results

Summary

Rules

Files

Details

org/apache/geronimo/deployment/plugin/jmx/JMXDeploymentManager.java

org/apache/geronimo/deployment/plugin/local/DistributeCommand.java

org/apache/geronimo/deployment/plugin/application/EARConfiguration.java

org/apache/geronimo/deployment/plugin/application/EARConfigurer.java

org/apache/geronimo/deployment/plugin/factories/AuthenticationFailedException.java

org/apache/geronimo/deployment/plugin/remote/RedeployCommand.java

org/apache/geronimo/deployment/plugin/ConfigIDExtractor.java

org/apache/geronimo/deployment/plugin/client/ClientConfigBean.java

org/apache/geronimo/deployment/plugin/remote/DistributeCommand.java

org/apache/geronimo/deployment/plugin/local/StartCommand.java

org/apache/geronimo/deployment/plugin/FailedProgressObject.java

org/apache/geronimo/deployment/plugin/TargetModuleIDImpl.java

org/apache/geronimo/deployment/plugin/factories/DeploymentFactoryImpl.java

org/apache/geronimo/deployment/plugin/local/package.html

org/apache/geronimo/deployment/plugin/jmx/RemoteDeploymentManager.java

org/apache/geronimo/deployment/plugin/application/package.html

org/apache/geronimo/deployment/plugin/jmx/CommandContext.java

org/apache/geronimo/deployment/plugin/jmx/LocalDeploymentManager.java

org/apache/geronimo/deployment/plugin/TargetImpl.java

org/apache/geronimo/deployment/plugin/client/package.html

org/apache/geronimo/deployment/plugin/package.html

org/apache/geronimo/deployment/plugin/DeploymentConfigurationImpl.java

org/apache/geronimo/deployment/plugin/local/RedeployCommand.java

org/apache/geronimo/deployment/plugin/local/UndeployCommand.java

org/apache/geronimo/deployment/plugin/jmx/package.html

org/apache/geronimo/deployment/plugin/remote/RemoteDeployUtil.java

org/apache/geronimo/deployment/plugin/remote/package.html

org/apache/geronimo/deployment/plugin/DisconnectedDeploymentManager.java

org/apache/geronimo/deployment/plugin/local/CommandSupport.java

org/apache/geronimo/deployment/plugin/factories/package.html

org/apache/geronimo/deployment/plugin/local/AbstractDeployCommand.java

org/apache/geronimo/deployment/plugin/application/EARConfigBean.java

org/apache/geronimo/deployment/plugin/GeronimoDeploymentManager.java

org/apache/geronimo/deployment/plugin/local/StopCommand.java