Geronimo :: Deployment - Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
27	0	0	1042

Rules

Rules	Violations	Severity
PackageHtml	3	Error
NewlineAtEndOfFile	5	Error
Translation	0	Error
JavadocMethod	315	Error
JavadocType	4	Error
JavadocVariable	76	Error
JavadocStyle	15	Error
ConstantName	4	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	1	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName	0	Error
Header headerFile: `"/home/anthill/anthill3/agent/var/jobs/projects/Geronimo_Server/modules/geronimo-deployment/target/checkstyle-header.txt"`	24	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	1	Error
UnusedImports	3	Error
FileLength	0	Error
LineLength max: `"120"`	65	Error
MethodLength	1	Error
ParameterNumber	2	Error
EmptyForIteratorPad	0	Error
NoWhitespaceAfter	0	Error
NoWhitespaceBefore	0	Error
OperatorWrap	10	Error
ParenPad	5	Error
TypecastParenPad	0	Error
TabCharacter	1	Error
WhitespaceAfter	11	Error
WhitespaceAround	22	Error
ModifierOrder	1	Error
RedundantModifier	1	Error
AvoidNestedBlocks	0	Error
EmptyBlock	13	Error
LeftCurly	0	Error
NeedBraces	29	Error
RightCurly	0	Error
AvoidInlineConditionals	11	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	1	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	9	Error
IllegalInstantiation	0	Error
InnerAssignment	0	Error
MagicNumber	5	Error
MissingSwitchDefault	1	Error
RedundantThrows	3	Error
SimplifyBooleanExpression	2	Error
SimplifyBooleanReturn	0	Error
FinalClass	1	Error
HideUtilityClassConstructor	1	Error
InterfaceIsType	0	Error
VisibilityModifier	1	Error
ArrayTypeStyle	4	Error
FinalParameters	356	Error
GenericIllegalRegexp message: `"Line has trailing spaces."` format: `"\s+$"`	35	Error
TodoComment	0	Error
UpperEll	0	Error

Files

Files	I	W	E
org/apache/geronimo/deployment/util/NestedJarFile.java	0	0	34
org/apache/geronimo/deployment/InPlaceResourceContext.java	0	0	54
org/apache/geronimo/deployment/util/UnpackedJarFile.java	0	0	28
org/apache/geronimo/deployment/ModuleIDBuilder.java	0	0	31
org/apache/geronimo/deployment/NamespaceDrivenBuilder.java	0	0	8
org/apache/geronimo/deployment/ConfigurationBuilder.java	0	0	14
org/apache/geronimo/deployment/util/DeploymentUtil.java	0	0	112
org/apache/geronimo/deployment/util/NestedJarEntry.java	0	0	34
org/apache/geronimo/deployment/DeploymentConfigurationManager.java	0	0	115
org/apache/geronimo/deployment/DeploymentContext.java	0	0	156
org/apache/geronimo/deployment/NamespaceDrivenBuilderCollection.java	0	0	26
org/apache/geronimo/deployment/xml/ParserFactory.java	0	0	2
org/apache/geronimo/deployment/CopyResourceContext.java	0	0	65
org/apache/geronimo/deployment/util/UnclosableOutputStream.java	0	0	17
org/apache/geronimo/deployment/xml/ParserFactoryImpl.java	0	0	18
org/apache/geronimo/deployment/package.html	0	0	1
org/apache/geronimo/deployment/util/package.html	0	0	1
org/apache/geronimo/deployment/util/XMLUtil.java	0	0	16
org/apache/geronimo/deployment/util/URLType.java	0	0	21
org/apache/geronimo/deployment/util/URLInfo.java	0	0	14
org/apache/geronimo/deployment/util/UnpackedJarEntry.java	0	0	29
org/apache/geronimo/deployment/ResourceContext.java	0	0	15
org/apache/geronimo/deployment/SingleFileHotDeployer.java	0	0	76
org/apache/geronimo/deployment/xml/package.html	0	0	1
org/apache/geronimo/deployment/xml/LocalEntityResolver.java	0	0	49
org/apache/geronimo/deployment/Deployer.java	0	0	85
org/apache/geronimo/deployment/util/UnclosableInputStream.java	0	0	20

Details

org/apache/geronimo/deployment/util/NestedJarFile.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	43
	Parameter jarFile should be final.	43
	Parameter path should be final.	43
	Missing a Javadoc comment.	77
	Missing a Javadoc comment.	84
	Missing a Javadoc comment.	91
	Missing a Javadoc comment.	98
	Missing a Javadoc comment.	105
	Must have at least one statement.	122
	Missing a Javadoc comment.	133
	Parameter name should be final.	133
	Missing a Javadoc comment.	145
	Parameter name should be final.	145
	Missing a Javadoc comment.	153
	Parameter name should be final.	153
	Missing a Javadoc comment.	161
	Missing a Javadoc comment.	178
	Parameter zipEntry should be final.	178
	'cast' is not followed by whitespace.	185
	Missing a Javadoc comment.	198
	Missing a Javadoc comment.	213
	Missing a Javadoc comment.	235
	Missing a Javadoc comment.	239
	Parameter name should be final.	239
	Missing a Javadoc comment.	243
	'manifest' hides a field.	244
	Must have at least one statement.	247

org/apache/geronimo/deployment/InPlaceResourceContext.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	37
	Line has trailing spaces.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	41
	Line has trailing spaces.	42
	Line is longer than 120 characters.	43
	Missing a Javadoc comment.	43
	Parameter configuration should be final.	43
	Parameter inPlaceBaseConfigurationDir should be final.	43
	Missing a Javadoc comment.	56
	Parameter targetPath should be final.	56
	Parameter jarFile should be final.	56
	Missing a Javadoc comment.	60
	Parameter targetPath should be final.	60
	Parameter zipFile should be final.	60
	Parameter zipEntry should be final.	60
	Line has trailing spaces.	67
	Missing a Javadoc comment.	71
	Parameter targetPath should be final.	71
	Parameter source should be final.	71
	Missing a Javadoc comment.	75
	Parameter targetPath should be final.	75
	Parameter source should be final.	75
	Missing a Javadoc comment.	79
	Parameter targetPath should be final.	79
	Parameter zipFile should be final.	79
	Parameter zipEntry should be final.	79
	Missing a Javadoc comment.	88
	Parameter targetPath should be final.	88
	Parameter source should be final.	88
	Missing a Javadoc comment.	91
	Parameter targetPath should be final.	91
	Parameter source should be final.	91
	Missing a Javadoc comment.	94
	Parameter targetPath should be final.	94
	Parameter source should be final.	94
	Line has trailing spaces.	96
	Missing a Javadoc comment.	97
	Parameter targetPath should be final.	97
	'if' construct must use '{}'s.	98
	'if' construct must use '{}'s.	99
	'if' construct must use '{}'s.	100
	Line has trailing spaces.	103
	Missing a Javadoc comment.	104
	Line has trailing spaces.	119
	Line has trailing spaces.	123
	'+' should be on a new line.	123
	Line has trailing spaces.	126
	Line has trailing spaces.	130
	Line has trailing spaces.	131

org/apache/geronimo/deployment/util/UnpackedJarFile.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	42
	Parameter baseDir should be final.	42
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	54
	Must have at least one statement.	67
	Missing a Javadoc comment.	78
	Parameter name should be final.	78
	Missing a Javadoc comment.	86
	Parameter name should be final.	86
	Missing a Javadoc comment.	90
	Parameter name should be final.	90
	Missing a Javadoc comment.	94
	'manifest' hides a field.	97
	Missing a Javadoc comment.	109
	Parameter zipEntry should be final.	109
	'cast' is not followed by whitespace.	112
	Missing a Javadoc comment.	125
	Missing a Javadoc comment.	137
	Missing a Javadoc comment.	140
	Missing a Javadoc comment.	143
	Parameter name should be final.	143
	Missing a Javadoc comment.	151
	'manifest' hides a field.	152
	Must have at least one statement.	155

org/apache/geronimo/deployment/ModuleIDBuilder.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	35
	Parameter defaultGroup should be final.	44
	Expected @param tag for 'defaultGroup'.	44
	Parameter defaultVersion should be final.	53
	Expected @param tag for 'defaultVersion'.	53
	Unused @throws tag for 'IllegalArgumentException'.	69
	Parameter argument should be final.	72
	Parameter defaultType should be final.	72
	'if' is not followed by whitespace.	73
	'if' is not followed by whitespace.	76
	'+' is not preceded with whitespace.	77
	'+' is not followed by whitespace.	77
	'+' is not preceded with whitespace.	77
	'+' is not followed by whitespace.	77
	Line is longer than 120 characters.	79
	Avoid inline conditionals.	79
	Avoid inline conditionals.	81
	Avoid inline conditionals.	82
	Expected an @return tag.	91
	Parameter defaultArtifact should be final.	91
	Parameter defaultType should be final.	91
	Parameter environment should be final.	108
	Parameter defaultArtifactId should be final.	108
	Parameter defaultType should be final.	108
	'if' is not followed by whitespace.	109
	Line is longer than 120 characters.	110
	'cast' is not followed by whitespace.	110
	'if' is not followed by whitespace.	111

org/apache/geronimo/deployment/NamespaceDrivenBuilder.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Unused import - java.util.List.	21
	Unused import - org.apache.geronimo.gbean.AbstractName.	25
	Missing a Javadoc comment.	33
	Line has trailing spaces.	34
	Line is longer than 120 characters.	35
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37

org/apache/geronimo/deployment/ConfigurationBuilder.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Unused import - java.util.List.	23
	Redundant import from the same package - org.apache.geronimo.deployment.DeploymentContext.	27
	Missing a Javadoc comment.	36
	Redundant 'static' modifier.	36
	Expected @param tag for 'idBuilder'.	46
	Line is longer than 120 characters.	56
	Expected @param tag for 'idBuilder'.	56
	First sentence should end with a period.	58
	Line is longer than 120 characters.	71
	Expected @param tag for 'configId'.	71
	Expected @param tag for 'configurationStores'.	71
	Expected @param tag for 'artifactResolver'.	71
	Expected @param tag for 'targetConfigurationStore'.	71

org/apache/geronimo/deployment/util/DeploymentUtil.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	59
	Missing a Javadoc comment.	68
	Missing a Javadoc comment.	74
	Parameter source should be final.	74
	Parameter destination should be final.	74
	Expression can be simplified.	76
	Expression can be simplified.	76
	Line has trailing spaces.	79
	Missing a Javadoc comment.	92
	Parameter in should be final.	92
	Parameter out should be final.	92
	'4096' is a magic number.	93
	Missing a Javadoc comment.	100
	Parameter jarFile should be final.	100
	Parameter path should be final.	100
	Missing a Javadoc comment.	104
	Parameter url should be final.	104
	Missing a Javadoc comment.	121
	Parameter url should be final.	121
	'4000' is a magic number.	126
	'for' is not followed by whitespace.	128
	Missing a Javadoc comment.	137
	Parameter jarFile should be final.	137
	Line contains a tab character.	141
	Missing a Javadoc comment.	146
	Parameter jarFile should be final.	146
	Parameter path should be final.	146
	Missing a Javadoc comment.	160
	Parameter jarFile should be final.	160
	Parameter path should be final.	160
	Line has trailing spaces.	173
	Missing a Javadoc comment.	183
	Parameter jarFile should be final.	183
	Missing a Javadoc comment.	191
	Parameter inputJar should be final.	191
	Parameter outputFile should be final.	191
	'cast' is not followed by whitespace.	195
	'cast' is not followed by whitespace.	196
	'cast' is not followed by whitespace.	202
	'4096' is a magic number.	212
	Missing a Javadoc comment.	237
	Parameter sourceDirecotry should be final.	237
	Parameter destinationFile should be final.	237
	Missing a Javadoc comment.	246
	Parameter zipFile should be final.	246
	Parameter destDir should be final.	246
	Line has trailing spaces.	279
	Line has trailing spaces.	280
	Missing a Javadoc comment.	281
	Parameter root should be final.	281
	Parameter unableToDeleteCollection should be final.	281
	Line has trailing spaces.	295
	Line has trailing spaces.	303
	Missing a Javadoc comment.	304
	Parameter root should be final.	304
	',' is not followed by whitespace.	305
	Missing a Javadoc comment.	308
	Parameter file should be final.	308
	Missing a Javadoc comment.	314
	Parameter file should be final.	314
	Parameter collection should be final.	314
	'(' is followed by whitespace.	316
	')' is preceded with whitespace.	316
	Missing a Javadoc comment.	327
	Parameter thing should be final.	327
	'catch' is not followed by whitespace.	331
	Must have at least one statement.	331
	Missing a Javadoc comment.	336
	Parameter thing should be final.	336
	'catch' is not followed by whitespace.	340
	Must have at least one statement.	340
	Missing a Javadoc comment.	345
	Parameter thing should be final.	345
	'catch' is not followed by whitespace.	349
	Must have at least one statement.	349
	Missing a Javadoc comment.	354
	Parameter thing should be final.	354
	'catch' is not followed by whitespace.	358
	Must have at least one statement.	358
	Missing a Javadoc comment.	363
	Parameter thing should be final.	363
	'catch' is not followed by whitespace.	367
	Must have at least one statement.	367
	Missing a Javadoc comment.	372
	Parameter thing should be final.	372
	'catch' is not followed by whitespace.	376
	Must have at least one statement.	376
	Missing a Javadoc comment.	381
	Parameter thing should be final.	381
	'catch' is not followed by whitespace.	385
	Must have at least one statement.	385
	Missing a Javadoc comment.	390
	Missing a Javadoc comment.	391
	Missing a Javadoc comment.	395
	Parameter b should be final.	395
	Array brackets at illegal position.	395
	Missing a Javadoc comment.	399
	Parameter b should be final.	399
	Array brackets at illegal position.	399
	Parameter off should be final.	399
	Parameter len should be final.	399
	Missing a Javadoc comment.	403
	Parameter n should be final.	403
	Missing a Javadoc comment.	407
	Missing a Javadoc comment.	411
	Missing a Javadoc comment.	414
	Parameter readlimit should be final.	414
	Missing a Javadoc comment.	417
	Missing a Javadoc comment.	420

org/apache/geronimo/deployment/util/NestedJarEntry.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	32
	Parameter name should be final.	32
	Parameter baseEntry should be final.	32
	Parameter manifest should be final.	32
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	59
	Missing a Javadoc comment.	63
	Parameter time should be final.	63
	Missing a Javadoc comment.	67
	Missing a Javadoc comment.	71
	Parameter size should be final.	71
	Missing a Javadoc comment.	75
	Missing a Javadoc comment.	79
	Parameter csize should be final.	79
	Missing a Javadoc comment.	83
	Missing a Javadoc comment.	87
	Parameter crc should be final.	87
	Missing a Javadoc comment.	91
	Missing a Javadoc comment.	95
	Parameter method should be final.	95
	Missing a Javadoc comment.	99
	Missing a Javadoc comment.	103
	Parameter extra should be final.	103
	Missing a Javadoc comment.	107
	Missing a Javadoc comment.	111
	Parameter comment should be final.	111
	Missing a Javadoc comment.	115
	Missing a Javadoc comment.	119
	Missing a Javadoc comment.	123
	Missing a Javadoc comment.	127

org/apache/geronimo/deployment/DeploymentConfigurationManager.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	50
	Parameter configurationManager should be final.	50
	Parameter repositories should be final.	50
	Line is longer than 120 characters.	51
	Missing a Javadoc comment.	59
	Parameter configId should be final.	59
	Missing a Javadoc comment.	63
	Parameter configId should be final.	63
	Missing a Javadoc comment.	67
	Parameter configId should be final.	67
	Missing a Javadoc comment.	71
	Parameter artifact should be final.	71
	Missing a Javadoc comment.	75
	Parameter configurationId should be final.	75
	Missing a Javadoc comment.	83
	First sentence should end with a period.	87
	Missing a Javadoc comment.	95
	Parameter online should be final.	95
	Line is longer than 120 characters.	102
	Missing a Javadoc comment.	102
	Parameter configurationId should be final.	102
	Line is longer than 120 characters.	106
	Missing a Javadoc comment.	106
	Parameter configurationId should be final.	106
	Parameter monitor should be final.	106
	Line is longer than 120 characters.	110
	Missing a Javadoc comment.	110
	Parameter configurationData should be final.	110
	Line is longer than 120 characters.	114
	Missing a Javadoc comment.	114
	Parameter configurationData should be final.	114
	Parameter monitor should be final.	114
	Line is longer than 120 characters.	118
	Missing a Javadoc comment.	118
	Parameter configurationData should be final.	118
	Parameter resolvedParentIds should be final.	118
	Parameter loadedConfigurations should be final.	118
	Missing a Javadoc comment.	122
	Parameter configurationId should be final.	122
	Missing a Javadoc comment.	128
	Parameter configuration should be final.	128
	'=' is not preceded with whitespace.	131
	Missing a Javadoc comment.	152
	Parameter id should be final.	152
	Line is longer than 120 characters.	156
	Missing a Javadoc comment.	156
	Parameter id should be final.	156
	Parameter monitor should be final.	156
	Missing a Javadoc comment.	160
	Parameter configuration should be final.	160
	Missing a Javadoc comment.	167
	Parameter configuration should be final.	167
	Missing a Javadoc comment.	176
	Parameter query should be final.	176
	Missing a Javadoc comment.	180
	Parameter query should be final.	180
	Missing a Javadoc comment.	184
	Parameter query should be final.	184
	Missing a Javadoc comment.	188
	Missing a Javadoc comment.	192
	Missing a Javadoc comment.	196
	Missing a Javadoc comment.	200
	Parameter configId should be final.	200
	Missing a Javadoc comment.	204
	Parameter storeName should be final.	204
	Line is longer than 120 characters.	208
	Missing a Javadoc comment.	208
	Parameter id should be final.	208
	Line is longer than 120 characters.	212
	Missing a Javadoc comment.	212
	Parameter id should be final.	212
	Parameter monitor should be final.	212
	Missing a Javadoc comment.	216
	Parameter configuration should be final.	216
	Missing a Javadoc comment.	220
	Parameter id should be final.	220
	Line is longer than 120 characters.	224
	Missing a Javadoc comment.	224
	Parameter id should be final.	224
	Parameter monitor should be final.	224
	Line is longer than 120 characters.	228
	Missing a Javadoc comment.	228
	Parameter id should be final.	228
	Line is longer than 120 characters.	232
	Missing a Javadoc comment.	232
	Parameter id should be final.	232
	Parameter monitor should be final.	232
	Line is longer than 120 characters.	236
	Missing a Javadoc comment.	236
	Parameter id should be final.	236
	Line is longer than 120 characters.	240
	Missing a Javadoc comment.	240
	Parameter id should be final.	240
	Parameter monitor should be final.	240
	Line is longer than 120 characters.	244
	Missing a Javadoc comment.	244
	Parameter id should be final.	244
	Parameter version should be final.	244
	Line is longer than 120 characters.	248
	Missing a Javadoc comment.	248
	Parameter id should be final.	248
	Parameter version should be final.	248
	Parameter monitor should be final.	248
	Line is longer than 120 characters.	252
	Missing a Javadoc comment.	252
	Parameter configurationData should be final.	252
	Line is longer than 120 characters.	256
	Missing a Javadoc comment.	256
	Parameter configurationData should be final.	256
	Parameter monitor should be final.	256
	Line is longer than 120 characters.	260
	Missing a Javadoc comment.	260
	Parameter configurationId should be final.	260

org/apache/geronimo/deployment/DeploymentContext.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	69
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	71
	Missing a Javadoc comment.	72
	'4096' is a magic number.	72
	Missing a Javadoc comment.	73
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	75
	Missing a Javadoc comment.	76
	Missing a Javadoc comment.	77
	Missing a Javadoc comment.	78
	Variable 'moduleName' must be private and have accessor methods.	78
	Line is longer than 120 characters.	80
	Missing a Javadoc comment.	80
	More than 7 parameters.	80
	Parameter baseDir should be final.	80
	Parameter inPlaceConfigurationDir should be final.	80
	Parameter environment should be final.	80
	Parameter moduleName should be final.	80
	Parameter moduleType should be final.	80
	Parameter naming should be final.	80
	Parameter configurationManager should be final.	80
	Parameter repositories should be final.	80
	Line is longer than 120 characters.	81
	Line is longer than 120 characters.	84
	Missing a Javadoc comment.	84
	Parameter baseDir should be final.	84
	Parameter inPlaceConfigurationDir should be final.	84
	Parameter environment should be final.	84
	Parameter moduleName should be final.	84
	Parameter moduleType should be final.	84
	Parameter naming should be final.	84
	Parameter configurationManager should be final.	84
	'if' construct must use '{}'s.	85
	'if' construct must use '{}'s.	86
	'if' construct must use '{}'s.	87
	'if' construct must use '{}'s.	88
	Line is longer than 120 characters.	101
	Line has trailing spaces.	104
	Line is longer than 120 characters.	112
	Missing a Javadoc comment.	112
	Parameter configurationManager should be final.	112
	Parameter repositories should be final.	112
	Line is longer than 120 characters.	116
	Missing a Javadoc comment.	116
	Parameter environment should be final.	116
	Parameter moduleType should be final.	116
	Parameter baseDir should be final.	116
	Parameter inPlaceConfigurationDir should be final.	116
	Parameter configurationManager should be final.	116
	Parameter naming should be final.	116
	Line is longer than 120 characters.	118
	Missing a Javadoc comment.	125
	Missing a Javadoc comment.	129
	Missing a Javadoc comment.	133
	Missing a Javadoc comment.	137
	Missing a Javadoc comment.	141
	Missing a Javadoc comment.	145
	Parameter name should be final.	145
	Parameter gbeanInfo should be final.	145
	'if' construct must use '{}'s.	146
	'if' construct must use '{}'s.	147
	Missing a Javadoc comment.	153
	Parameter gbean should be final.	153
	'if' construct must use '{}'s.	154
	'if' construct must use '{}'s.	155
	Missing a Javadoc comment.	159
	Parameter name should be final.	159
	'if' construct must use '{}'s.	160
	Missing a Javadoc comment.	164
	Expected an @return tag.	171
	Parameter pattern should be final.	171
	Expected @param tag for 'pattern'.	171
	Missing a Javadoc comment.	175
	Parameter pattern should be final.	175
	Missing a Javadoc comment.	179
	Parameter patterns should be final.	179
	Missing a Javadoc comment.	183
	Parameter pattern should be final.	183
	Missing a Javadoc comment.	187
	Parameter patterns should be final.	187
	Missing a Javadoc comment.	191
	Parameter name should be final.	191
	Parameter targetPath should be final.	209
	Parameter jarFile should be final.	209
	Parameter targetPath should be final.	223
	Parameter zipFile should be final.	223
	Parameter zipEntry should be final.	223
	Parameter targetPath should be final.	236
	Parameter source should be final.	236
	Parameter targetPath should be final.	249
	Parameter source should be final.	249
	Parameter moduleFile should be final.	262
	Parameter moduleBaseUri should be final.	262
	Line is longer than 120 characters.	285
	Line is longer than 120 characters.	289
	Line is longer than 120 characters.	292
	'if' construct must use '{}'s.	297
	Line is longer than 120 characters.	297
	Missing a Javadoc comment.	305
	Parameter targetPath should be final.	305
	Parameter fqcn should be final.	305
	Parameter bytes should be final.	305
	'if' construct must use '{}'s.	306
	Line is longer than 120 characters.	306
	Missing a Javadoc comment.	316
	Parameter targetPath should be final.	316
	Parameter zipFile should be final.	316
	Parameter zipEntry should be final.	316
	Missing a Javadoc comment.	320
	Parameter targetPath should be final.	320
	Parameter source should be final.	320
	Missing a Javadoc comment.	324
	Parameter targetPath should be final.	324
	Parameter source should be final.	324
	Missing a Javadoc comment.	328
	Parameter targetPath should be final.	328
	Parameter source should be final.	328
	Missing a Javadoc comment.	332
	Parameter targetFile should be final.	332
	Parameter source should be final.	332
	Missing a Javadoc comment.	346
	Parameter targetPath should be final.	346
	Missing a Javadoc comment.	350
	Missing a Javadoc comment.	354
	Missing a Javadoc comment.	358
	'{' is not preceded with whitespace.	358
	Missing a Javadoc comment.	362
	Must have at least one statement.	366
	Missing a Javadoc comment.	372
	Parameter moduleName should be final.	372
	'moduleName' hides a field.	372
	Parameter configurationData should be final.	372
	Missing a Javadoc comment.	376
	'if' construct must use '{}'s.	382
	Missing a Javadoc comment.	407
	Parameter configurationData should be final.	407
	Missing a Javadoc comment.	411
	Missing a Javadoc comment.	415
	Missing a Javadoc comment.	419
	Missing a Javadoc comment.	448
	Parameter gbean should be final.	448
	Parameter referenceName should be final.	448
	Parameter referencePatterns should be final.	448
	'if' construct must use '{}'s.	452
	'if' construct must use '{}'s.	455
	'+' should be on a new line.	458
	Missing a Javadoc comment.	464
	Parameter name should be final.	464
	Parameter referencePatterns should be final.	464
	'+' should be on a new line.	466
	Missing a Javadoc comment.	473
	Parameter referencePatterns should be final.	473
	'if' construct must use '{}'s.	476
	'if' construct must use '{}'s.	483

org/apache/geronimo/deployment/NamespaceDrivenBuilderCollection.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	43
	Parameter builders should be final.	43
	'?' is not preceded with whitespace.	44
	Avoid inline conditionals.	44
	':' is not preceded with whitespace.	44
	'cast' is not followed by whitespace.	46
	Parameter event should be final.	48
	Parameter event should be final.	52
	'cast' is not followed by whitespace.	54
	Missing a Javadoc comment.	65
	Parameter builder should be final.	65
	'cast' is not followed by whitespace.	66
	Line has trailing spaces.	70
	Missing a Javadoc comment.	73
	Parameter container should be final.	73
	Parameter environment should be final.	73
	Line is longer than 120 characters.	80
	Missing a Javadoc comment.	80
	Parameter container should be final.	80
	Parameter applicationContext should be final.	80
	Parameter moduleContext should be final.	80
	Missing a Javadoc comment.	87
	Parameter loaderList should be final.	87

org/apache/geronimo/deployment/xml/ParserFactory.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	30

org/apache/geronimo/deployment/CopyResourceContext.java

Violation	Message	Line
	File does not end with a newline.	0
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	39
	'4096' is a magic number.	39
	Line has trailing spaces.	40
	Missing a Javadoc comment.	41
	Parameter configuration should be final.	41
	Parameter baseDir should be final.	41
	Line has trailing spaces.	44
	Parameter targetPath should be final.	63
	Parameter jarFile should be final.	63
	'if' construct must use '{}'s.	64
	Line is longer than 120 characters.	64
	'if' construct must use '{}'s.	69
	Parameter targetPath should be final.	83
	Parameter zipFile should be final.	83
	Parameter zipEntry should be final.	83
	Line is longer than 120 characters.	84
	Line is longer than 120 characters.	89
	Parameter targetPath should be final.	102
	Parameter source should be final.	102
	'if' construct must use '{}'s.	103
	Line is longer than 120 characters.	103
	'if' construct must use '{}'s.	108
	Parameter targetPath should be final.	121
	Parameter source should be final.	121
	'if' construct must use '{}'s.	122
	Line is longer than 120 characters.	122
	'if' construct must use '{}'s.	127
	Missing a Javadoc comment.	131
	Parameter targetPath should be final.	131
	Parameter zipFile should be final.	131
	Parameter zipEntry should be final.	131
	Missing a Javadoc comment.	135
	Parameter targetPath should be final.	135
	Parameter source should be final.	135
	Missing a Javadoc comment.	139
	Parameter targetPath should be final.	139
	Parameter source should be final.	139
	Missing a Javadoc comment.	143
	Parameter targetPath should be final.	143
	Parameter source should be final.	143
	Missing a Javadoc comment.	147
	Parameter targetPath should be final.	147
	'if' construct must use '{}'s.	148
	'if' construct must use '{}'s.	149
	'if' construct must use '{}'s.	150
	Missing a Javadoc comment.	154
	Line has trailing spaces.	156
	Missing a Javadoc comment.	157
	Parameter targetFile should be final.	157
	Parameter zipFile should be final.	157
	Parameter zipEntry should be final.	157
	Missing a Javadoc comment.	170
	Parameter targetFile should be final.	170
	Parameter source should be final.	170
	Missing a Javadoc comment.	180
	Parameter targetFile should be final.	180
	Parameter source should be final.	180
	Missing a Javadoc comment.	190
	Parameter targetFile should be final.	190
	Parameter source should be final.	190

org/apache/geronimo/deployment/util/UnclosableOutputStream.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	30
	Parameter delegate should be final.	30
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	37
	Parameter b should be final.	37
	Missing a Javadoc comment.	41
	Parameter b should be final.	41
	Array brackets at illegal position.	41
	Missing a Javadoc comment.	45
	Parameter b should be final.	45
	Array brackets at illegal position.	45
	Parameter off should be final.	45
	Parameter len should be final.	45
	Missing a Javadoc comment.	49

org/apache/geronimo/deployment/xml/ParserFactoryImpl.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	41
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	41
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	46
	Parameter entityResolver should be final.	46
	Missing a Javadoc comment.	60
	Parameter exception should be final.	65
	Parameter exception should be final.	70
	Parameter exception should be final.	75
	Missing a Javadoc comment.	82
	Missing a Javadoc comment.	86
	Parameter entityResolver should be final.	86
	Missing a Javadoc comment.	90
	'static' modifier out of order with the JLS suggestions.	90
	Line is longer than 120 characters.	93
	Missing a Javadoc comment.	104

org/apache/geronimo/deployment/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/deployment/util/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/deployment/util/XMLUtil.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	25
	Line has trailing spaces.	26
	Utility classes should not have a public or default constructor.	29
	Missing a Javadoc comment.	30
	Parameter element should be final.	30
	switch without "default" clause.	35
	Missing a Javadoc comment.	47
	Parameter parent should be final.	47
	Parameter name should be final.	47
	Missing a Javadoc comment.	56
	Parameter parent should be final.	56
	Parameter name should be final.	56
	Parameter missing should be final.	56
	Parameter empty should be final.	56
	Avoid inline conditionals.	62

org/apache/geronimo/deployment/util/URLType.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	34
	Class URLType should be declared as final.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	50
	Parameter file should be final.	50
	First sentence should end with a period.	78
	Line has trailing spaces.	80
	Line has trailing spaces.	81
	Parameter url should be final.	85
	Expected @param tag for 'url'.	85
	Missing a Javadoc comment.	109
	Missing a Javadoc comment.	111
	Definition of 'equals()' without corresponding definition of 'hashCode()'.	115
	Missing a Javadoc comment.	115
	Parameter obj should be final.	115
	Missing a Javadoc comment.	119

org/apache/geronimo/deployment/util/URLInfo.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	32
	Parameter url should be final.	32
	Parameter type should be final.	32
	Missing a Javadoc comment.	39
	Parameter url should be final.	39
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	55
	Parameter obj should be final.	55
	Missing a Javadoc comment.	62

org/apache/geronimo/deployment/util/UnpackedJarEntry.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Parameter name should be final.	34
	Parameter file should be final.	34
	Parameter manifest should be final.	34
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	44
	Parameter time should be final.	66
	Redundant throws: 'UnsupportedOperationException' is unchecked exception.	66
	Missing a Javadoc comment.	70
	Parameter size should be final.	79
	Redundant throws: 'UnsupportedOperationException' is unchecked exception.	79
	Missing a Javadoc comment.	83
	Unused @throws tag for 'UnsupportedOperationException'.	102
	Parameter compressedSize should be final.	104
	Missing a Javadoc comment.	108
	Unused @throws tag for 'UnsupportedOperationException'.	115
	Parameter crc should be final.	117
	Missing a Javadoc comment.	121
	Unused @throws tag for 'UnsupportedOperationException'.	128
	Parameter method should be final.	130
	Unused @throws tag for 'UnsupportedOperationException'.	145
	Parameter extra should be final.	147
	Unused @throws tag for 'UnsupportedOperationException'.	162
	Parameter comment should be final.	164
	Missing a Javadoc comment.	168
	Missing a Javadoc comment.	172

org/apache/geronimo/deployment/ResourceContext.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	27
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	42
	Line has trailing spaces.	43
	Missing a Javadoc comment.	44
	Line has trailing spaces.	45
	Missing a Javadoc comment.	46

org/apache/geronimo/deployment/SingleFileHotDeployer.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	50
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	50
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	52
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	58
	Missing a Javadoc comment.	59
	Line is longer than 120 characters.	61
	Missing a Javadoc comment.	61
	Parameter path should be final.	61
	Parameter serverInfo should be final.	61
	Parameter watchPaths should be final.	61
	Parameter builders should be final.	61
	Parameter store should be final.	61
	Parameter configurationManager should be final.	61
	Parameter forceDeploy should be final.	61
	Line is longer than 120 characters.	65
	Missing a Javadoc comment.	65
	Parameter dir should be final.	65
	Parameter watchPaths should be final.	65
	Parameter builders should be final.	65
	Parameter store should be final.	65
	Parameter configurationManager should be final.	65
	Parameter forceDeploy should be final.	65
	Missing a Javadoc comment.	76
	Parameter dir should be final.	76
	'dir' hides a field.	76
	Line has trailing spaces.	85
	Line has trailing spaces.	86
	Avoid inline conditionals.	101
	Line is longer than 120 characters.	144
	'configurationId' hides a field.	148
	'if' is not followed by whitespace.	165
	Line is longer than 120 characters.	171
	Missing a Javadoc comment.	188
	Parameter created should be final.	188
	Missing a Javadoc comment.	203
	Parameter configID should be final.	203
	Line is longer than 120 characters.	210
	Line is longer than 120 characters.	223
	Missing a Javadoc comment.	223
	Parameter builder should be final.	223
	Parameter store should be final.	223
	'store' hides a field.	223
	Parameter configurationId should be final.	223
	'configurationId' hides a field.	223
	Parameter plan should be final.	223
	Parameter module should be final.	223
	Parameter stores should be final.	223
	Parameter artifactResolver should be final.	223
	Line is longer than 120 characters.	226
	Missing a Javadoc comment.	272
	Parameter configurations should be final.	272
	'dir' hides a field.	276
	',' is not followed by whitespace.	278
	Line has trailing spaces.	280
	'+' should be on a new line.	280
	Line has trailing spaces.	281
	'+' should be on a new line.	282
	'+' is not preceded with whitespace.	283
	'+' should be on a new line.	283
	'(' is followed by whitespace.	284
	Avoid inline conditionals.	284
	')' is preceded with whitespace.	284
	Missing a Javadoc comment.	289
	Missing a Javadoc comment.	293
	Missing a Javadoc comment.	297
	Missing a Javadoc comment.	301
	Missing a Javadoc comment.	305
	Line is longer than 120 characters.	318
	Missing a Javadoc comment.	323

org/apache/geronimo/deployment/xml/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/deployment/xml/LocalEntityResolver.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	First sentence should end with a period.	62
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	65
	First sentence should end with a period.	67
	First sentence should end with a period.	72
	First sentence should end with a period.	77
	First sentence should end with a period.	82
	Missing a Javadoc comment.	95
	Parameter catalogFileURI should be final.	95
	Parameter localRepositoryURI should be final.	95
	Parameter failOnUnresolvable should be final.	95
	Missing a Javadoc comment.	112
	Missing a Javadoc comment.	116
	Missing a Javadoc comment.	121
	Missing a Javadoc comment.	125
	Missing a Javadoc comment.	129
	Parameter string should be final.	129
	Missing a Javadoc comment.	133
	Missing a Javadoc comment.	143
	Expected an @return tag.	166
	Expected @param tag for 'publicId'.	167
	Expected @param tag for 'systemId'.	168
	Expected @throws tag for 'SAXException'.	169
	Expected @throws tag for 'IOException'.	169
	First sentence should end with a period.	201
	Expected @throws tag for 'MalformedURLException'.	213
	Redundant throws: 'MalformedURLException' is subclass of 'IOException'.	213
	Expected @throws tag for 'IOException'.	213
	Line is longer than 120 characters.	224
	Line is longer than 120 characters.	267
	Line is longer than 120 characters.	315
	First sentence should end with a period.	325
	Expected an @return tag.	328
	Expected @param tag for 'string'.	328
	Avoid inline conditionals.	329
	First sentence should end with a period.	332
	First sentence should end with a period.	353
	Expected an @return tag.	356
	Expected @param tag for 'publicId'.	357
	Expected @param tag for 'systemId'.	358
	First sentence should end with a period.	369
	Parameter type should be final.	372
	Expected @param tag for 'type'.	372
	Parameter args should be final.	372
	Expected @param tag for 'args'.	372
	First sentence should end with a period.	381
	Missing a Javadoc comment.	396
	Line is longer than 120 characters.	399
	Missing a Javadoc comment.	414

org/apache/geronimo/deployment/Deployer.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	First sentence should end with a period.	60
	Missing a Javadoc comment.	66
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	66
	Missing a Javadoc comment.	67
	Name 'REAPER_INTERVAL' must match pattern '^[a-z][a-zA-Z0-9]*$'.	67
	Missing a Javadoc comment.	68
	Missing a Javadoc comment.	69
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	71
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	73
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	76
	Parameter builders should be final.	76
	Parameter stores should be final.	76
	Parameter watchers should be final.	76
	Parameter kernel should be final.	76
	Missing a Javadoc comment.	80
	Parameter kernel should be final.	80
	Line is longer than 120 characters.	85
	Missing a Javadoc comment.	85
	Parameter builders should be final.	85
	Parameter stores should be final.	85
	Parameter watchers should be final.	85
	Parameter artifactResolver should be final.	85
	Parameter kernel should be final.	85
	Missing a Javadoc comment.	99
	Parameter inPlace should be final.	99
	Parameter moduleFile should be final.	99
	Parameter planFile should be final.	99
	Line is longer than 120 characters.	103
	Missing a Javadoc comment.	103
	Parameter inPlace should be final.	103
	Parameter moduleFile should be final.	103
	Parameter planFile should be final.	103
	Parameter targetConfigStore should be final.	103
	Line is longer than 120 characters.	124
	Method length is 194 lines (max allowed is 150).	187
	Missing a Javadoc comment.	187
	More than 7 parameters.	187
	Parameter inPlace should be final.	187
	Parameter planFile should be final.	188
	Parameter moduleFile should be final.	189
	Parameter targetFile should be final.	190
	Parameter install should be final.	191
	Parameter mainClass should be final.	192
	Parameter mainGBean should be final.	193
	Parameter mainMethod should be final.	193
	Parameter manifestConfigurations should be final.	193
	Parameter classPath should be final.	193
	Parameter endorsedDirs should be final.	194
	Parameter extensionDirs should be final.	195
	Parameter targetConfigurationStore should be final.	196
	Line is longer than 120 characters.	239
	'+' should be on a new line.	239
	Line is longer than 120 characters.	240
	'+' should be on a new line.	240
	'+' should be on a new line.	241
	Avoid inline conditionals.	242
	'+' should be on a new line.	242
	Line is longer than 120 characters.	243
	Avoid inline conditionals.	243
	Avoid inline conditionals.	243
	Line is longer than 120 characters.	254
	Must have at least one statement.	255
	Line is longer than 120 characters.	302
	Line has trailing spaces.	313
	Line has trailing spaces.	314
	'(' is followed by whitespace.	319
	Missing a Javadoc comment.	391
	Parameter list should be final.	391
	Missing a Javadoc comment.	406
	Parameter configurations should be final.	406
	Missing a Javadoc comment.	423
	Missing a Javadoc comment.	424
	Missing a Javadoc comment.	426
	Parameter reaperInterval should be final.	426
	Missing a Javadoc comment.	430
	Missing a Javadoc comment.	434
	'if' construct must use '{}'s.	452
	Missing a Javadoc comment.	468
	Missing a Javadoc comment.	470
	Line is longer than 120 characters.	479
	Missing a Javadoc comment.	490

org/apache/geronimo/deployment/util/UnclosableInputStream.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Parameter delegate should be final.	34
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	45
	Parameter readLimit should be final.	45
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	57
	Parameter buffer should be final.	57
	Missing a Javadoc comment.	61
	Parameter buffer should be final.	61
	Parameter offset should be final.	61
	Parameter length should be final.	61
	Missing a Javadoc comment.	65
	Missing a Javadoc comment.	69
	Parameter n should be final.	69

Parent Project

Project Documentation

Checkstyle Results

Summary

Rules

Files

Details

org/apache/geronimo/deployment/util/NestedJarFile.java

org/apache/geronimo/deployment/InPlaceResourceContext.java

org/apache/geronimo/deployment/util/UnpackedJarFile.java

org/apache/geronimo/deployment/ModuleIDBuilder.java

org/apache/geronimo/deployment/NamespaceDrivenBuilder.java

org/apache/geronimo/deployment/ConfigurationBuilder.java

org/apache/geronimo/deployment/util/DeploymentUtil.java

org/apache/geronimo/deployment/util/NestedJarEntry.java

org/apache/geronimo/deployment/DeploymentConfigurationManager.java

org/apache/geronimo/deployment/DeploymentContext.java

org/apache/geronimo/deployment/NamespaceDrivenBuilderCollection.java

org/apache/geronimo/deployment/xml/ParserFactory.java

org/apache/geronimo/deployment/CopyResourceContext.java

org/apache/geronimo/deployment/util/UnclosableOutputStream.java

org/apache/geronimo/deployment/xml/ParserFactoryImpl.java

org/apache/geronimo/deployment/package.html

org/apache/geronimo/deployment/util/package.html

org/apache/geronimo/deployment/util/XMLUtil.java

org/apache/geronimo/deployment/util/URLType.java

org/apache/geronimo/deployment/util/URLInfo.java

org/apache/geronimo/deployment/util/UnpackedJarEntry.java

org/apache/geronimo/deployment/ResourceContext.java

org/apache/geronimo/deployment/SingleFileHotDeployer.java

org/apache/geronimo/deployment/xml/package.html

org/apache/geronimo/deployment/xml/LocalEntityResolver.java

org/apache/geronimo/deployment/Deployer.java

org/apache/geronimo/deployment/util/UnclosableInputStream.java