PMD Results

The following document contains the results of PMD 3.7.

Files

org/apache/geronimo/tomcat/ConnectorGBean.java

ViolationLine
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.325
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.334
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.404
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.408

org/apache/geronimo/tomcat/EngineGBean.java

ViolationLine
These nested if statements could be combined106 - 112

org/apache/geronimo/tomcat/valve/GeronimoBeforeAfterValve.java

ViolationLine
Avoid unused imports such as 'org.apache.catalina.Valve'7

org/apache/geronimo/tomcat/cluster/FarmWarDeployerGBean.java

ViolationLine
Avoid unused private fields such as 'log'29
Avoid unused private fields such as 'serverInfo'32

org/apache/geronimo/tomcat/TomcatLogManagerImpl.java

ViolationLine
Avoid unused private fields such as 'GROUP_FILENAME_YEAR'50
Avoid unused private fields such as 'GROUP_FILENAME_MONTH'51
Avoid unused private fields such as 'GROUP_FILENAME_DAY'52
Avoid unused private fields such as 'GROUP_RESPONSE_CODE'67
Avoid unused private fields such as 'GROUP_RESPONSE_LENGTH'68
Avoid unused local variables such as 'logFileDate'190
Avoid empty catch blocks236 - 238

org/apache/geronimo/tomcat/TomcatWebAppContext.java

ViolationLine
Avoid unused constructor parameters such as 'application'130 - 244
These nested if statements could be combined355 - 357

org/apache/geronimo/tomcat/TomcatContainer.java

ViolationLine
Avoid unused imports such as 'javax.management.ObjectName'26
Avoid unused imports such as 'org.apache.geronimo.kernel.ObjectNameUtil'40
Avoid empty catch blocks165 - 166
These nested if statements could be combined279 - 281

org/apache/geronimo/tomcat/GeronimoStandardContext.java

ViolationLine
These nested if statements could be combined113 - 129
These nested if statements could be combined222 - 240

org/apache/geronimo/tomcat/HostGBean.java

ViolationLine
These nested if statements could be combined100 - 106

org/apache/geronimo/tomcat/ManagerGBean.java

ViolationLine
Avoid unused private fields such as 'log'30

org/apache/geronimo/tomcat/TomcatEJBWebServiceContext.java

ViolationLine
Avoid unused imports such as 'org.apache.geronimo.tomcat.realm.TomcatJAASRealm'41
Avoid unused imports such as 'org.apache.geronimo.tomcat.realm.TomcatGeronimoRealm'42
Avoid unused private fields such as 'contextPath'50
These nested if statements could be combined149 - 152

org/apache/geronimo/tomcat/HttpsConnectorGBean.java

ViolationLine
Avoid unused imports such as 'org.apache.geronimo.management.geronimo.SecureConnector'6
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.179
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.191

org/apache/geronimo/tomcat/realm/TomcatJAASRealm.java

ViolationLine
Avoid unused local variables such as 'password'165
These nested if statements could be combined204 - 206
Overriding method merely calls super219 - 221

org/apache/geronimo/tomcat/realm/TomcatGeronimoRealm.java

ViolationLine
Avoid unused imports such as 'org.apache.catalina.Wrapper'21
Avoid unused imports such as 'javax.servlet.ServletRequest'47
Overriding method merely calls super393 - 398
Overriding method merely calls super406 - 411