Activation 1.0.2 - Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
18	0	0	380

Rules

Rules	Violations	Severity
PackageHtml	1	Error
NewlineAtEndOfFile	9	Error
Translation	0	Error
JavadocMethod	137	Error
JavadocType	1	Error
JavadocVariable	31	Error
JavadocStyle	11	Error
ConstantName	0	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	0	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	2	Error
StaticVariableName	0	Error
TypeName	0	Error
Header headerFile: `"/Users/jason/ws/geronimo/specs/geronimo-activation_1.0.2_spec/target/checkstyle-header.txt"`	17	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	1	Error
FileLength	0	Error
LineLength max: `"120"`	1	Error
MethodLength	0	Error
ParameterNumber	0	Error
EmptyForIteratorPad	0	Error
NoWhitespaceAfter	0	Error
NoWhitespaceBefore	0	Error
OperatorWrap	0	Error
ParenPad	0	Error
TypecastParenPad	0	Error
TabCharacter	0	Error
WhitespaceAfter	3	Error
WhitespaceAround	10	Error
ModifierOrder	2	Error
RedundantModifier	10	Error
AvoidNestedBlocks	0	Error
EmptyBlock	21	Error
LeftCurly	0	Error
NeedBraces	3	Error
RightCurly	2	Error
AvoidInlineConditionals	5	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	1	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	10	Error
IllegalInstantiation	0	Error
InnerAssignment	0	Error
MagicNumber	4	Error
MissingSwitchDefault	0	Error
RedundantThrows	0	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
FinalClass	1	Error
HideUtilityClassConstructor	0	Error
InterfaceIsType	0	Error
VisibilityModifier	0	Error
ArrayTypeStyle	0	Error
FinalParameters	96	Error
GenericIllegalRegexp message: `"Line has trailing spaces."` format: `"\s+$"`	1	Error
TodoComment	0	Error
UpperEll	0	Error

Files

Files	I	W	E
javax/activation/MimeTypeParseException.java	0	0	4
javax/activation/ActivationDataFlavor.java	0	0	33
javax/activation/URLDataSource.java	0	0	13
javax/activation/package.html	0	0	1
javax/activation/FileDataSource.java	0	0	25
javax/activation/DataSource.java	0	0	9
javax/activation/CommandObject.java	0	0	4
javax/activation/FileTypeMap.java	0	0	10
javax/activation/DataHandler.java	0	0	58
javax/activation/CommandInfo.java	0	0	9
javax/activation/DataContentHandlerFactory.java	0	0	3
javax/activation/MimetypesFileTypeMap.java	0	0	31
javax/activation/CommandMap.java	0	0	12
javax/activation/UnsupportedDataTypeException.java	0	0	4
javax/activation/MimeType.java	0	0	52
javax/activation/MimeTypeParameterList.java	0	0	35
javax/activation/MailcapCommandMap.java	0	0	67
javax/activation/DataContentHandler.java	0	0	10

Details

javax/activation/MimeTypeParseException.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	28
	Parameter s should be final.	28

javax/activation/ActivationDataFlavor.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	27
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	31
	Parameter representationClass should be final.	31
	Parameter mimeType should be final.	31
	Parameter humanPresentableName should be final.	31
	Missing a Javadoc comment.	37
	Parameter representationClass should be final.	37
	Parameter humanPresentableName should be final.	37
	Missing a Javadoc comment.	43
	Parameter mimeType should be final.	43
	Parameter humanPresentableName should be final.	43
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	61
	Parameter humanPresentableName should be final.	61
	Definition of 'equals()' without corresponding definition of 'hashCode()'.	65
	Missing a Javadoc comment.	65
	Parameter dataFlavor should be final.	65
	Line is longer than 120 characters.	66
	Missing a Javadoc comment.	69
	Parameter mimeType should be final.	69
	'mimeType' hides a field.	69
	Missing a Javadoc comment.	79
	Parameter parameterName should be final.	79
	Parameter parameterValue should be final.	79
	Missing a Javadoc comment.	83
	Parameter mimeType should be final.	83
	'mimeType' hides a field.	83

javax/activation/URLDataSource.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	30
	'static' modifier out of order with the JLS suggestions.	30
	Missing a Javadoc comment.	32
	Parameter url should be final.	37
	Expected @param tag for 'url'.	37
	Expected an @return tag.	48
	Avoid inline conditionals.	52
	Expected @throws tag for 'IOException'.	70
	Expected an @return tag.	77
	Expected @throws tag for 'IOException'.	77
	Expected an @return tag.	86

javax/activation/package.html

Violation	Message	Line
	Missing package documentation file.	0

javax/activation/FileDataSource.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	First sentence should end with a period.	34
	Parameter file should be final.	37
	Expected @param tag for 'file'.	37
	First sentence should end with a period.	41
	Parameter name should be final.	44
	Expected @param tag for 'name'.	44
	First sentence should end with a period.	48
	Expected an @return tag.	51
	Expected @throws tag for 'IOException'.	51
	First sentence should end with a period.	55
	Expected an @return tag.	58
	Expected @throws tag for 'IOException'.	58
	First sentence should end with a period.	62
	Expected an @return tag.	65
	First sentence should end with a period.	73
	Expected an @return tag.	76
	First sentence should end with a period.	80
	Expected an @return tag.	83
	First sentence should end with a period.	87
	Parameter map should be final.	90
	Expected @param tag for 'map'.	90

javax/activation/DataSource.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	28
	Redundant 'public' modifier.	28
	Missing a Javadoc comment.	30
	Redundant 'public' modifier.	30
	Missing a Javadoc comment.	32
	Redundant 'public' modifier.	32
	Missing a Javadoc comment.	34
	Redundant 'public' modifier.	34

javax/activation/CommandObject.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	26
	Redundant 'public' modifier.	26

javax/activation/FileTypeMap.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	30
	Unused @throws tag for 'SecurityException'.	35
	Parameter fileMap should be final.	37
	First sentence should end with a period.	45
	'static' modifier out of order with the JLS suggestions.	49
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	59
	Missing a Javadoc comment.	61

javax/activation/DataHandler.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Parameter ds should be final.	40
	Missing a Javadoc comment.	45
	Parameter data should be final.	45
	Parameter type should be final.	45
	Missing a Javadoc comment.	50
	Parameter url should be final.	50
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	59
	Missing a Javadoc comment.	63
	Missing a Javadoc comment.	67
	Missing a Javadoc comment.	71
	Parameter os should be final.	71
	'dch' hides a field.	74
	'1024' is a magic number.	80
	Missing a Javadoc comment.	93
	Missing a Javadoc comment.	97
	Missing a Javadoc comment.	101
	Parameter flavor should be final.	101
	'flavor' hides a field.	101
	Missing a Javadoc comment.	112
	Parameter flavor should be final.	112
	'flavor' hides a field.	112
	'dch' hides a field.	113
	Missing a Javadoc comment.	127
	Missing a Javadoc comment.	131
	Missing a Javadoc comment.	135
	Parameter cmdName should be final.	135
	Missing a Javadoc comment.	139
	'dch' hides a field.	143
	Missing a Javadoc comment.	152
	Parameter cmdinfo should be final.	152
	Missing a Javadoc comment.	166
	Missing a Javadoc comment.	167
	Missing a Javadoc comment.	169
	Parameter data should be final.	169
	Parameter mimeType should be final.	169
	Missing a Javadoc comment.	174
	Missing a Javadoc comment.	178
	Missing a Javadoc comment.	182
	'dch' hides a field.	183
	Must have at least one statement.	197
	Missing a Javadoc comment.	206
	Missing a Javadoc comment.	211
	Parameter commandMap should be final.	211
	Missing a Javadoc comment.	216
	Avoid inline conditionals.	217
	Expected an @return tag.	233
	Parameter contentType should be final.	270
	Must have at least one statement.	274
	Missing a Javadoc comment.	291
	Unused @throws tag for 'SecurityException'.	298
	Parameter newFactory should be final.	300

javax/activation/CommandInfo.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	30
	First sentence should end with a period.	32
	Parameter commandName should be final.	38
	Parameter commandClass should be final.	38
	Parameter dh should be final.	76
	Parameter loader should be final.	76

javax/activation/DataContentHandlerFactory.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	24
	Redundant 'public' modifier.	24

javax/activation/MimetypesFileTypeMap.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	42
	Must have at least one statement.	53
	Must have at least one statement.	74
	Must have at least one statement.	76
	Must have at least one statement.	89
	Must have at least one statement.	91
	Must have at least one statement.	93
	Must have at least one statement.	106
	Must have at least one statement.	108
	Must have at least one statement.	110
	Missing a Javadoc comment.	115
	Parameter mimeTypeFileName should be final.	115
	Must have at least one statement.	127
	Missing a Javadoc comment.	134
	Parameter is should be final.	134
	Must have at least one statement.	138
	Missing a Javadoc comment.	143
	Parameter is should be final.	143
	Missing a Javadoc comment.	151
	Parameter mime_types should be final.	151
	Name 'mime_types' must match pattern '^[a-z][a-zA-Z0-9]*$'.	151
	Missing a Javadoc comment.	167
	Parameter f should be final.	167
	Missing a Javadoc comment.	171
	Parameter filename should be final.	171
	'-' is not preceded with whitespace.	173
	'-' is not followed by whitespace.	173
	Avoid inline conditionals.	178

javax/activation/CommandMap.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	24
	Line has trailing spaces.	38
	Unused @throws tag for 'SecurityException'.	39
	Parameter commandMap should be final.	41
	Avoid inline conditionals.	46
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	52
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	58

javax/activation/UnsupportedDataTypeException.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	30
	Parameter s should be final.	30

javax/activation/MimeType.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	32
	Parameter c should be final.	32
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	43
	Parameter rawdata should be final.	43
	Missing a Javadoc comment.	47
	Parameter primary should be final.	47
	Parameter sub should be final.	47
	Missing a Javadoc comment.	52
	Missing a Javadoc comment.	56
	Parameter primary should be final.	56
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	64
	Parameter sub should be final.	64
	Missing a Javadoc comment.	68
	Missing a Javadoc comment.	72
	Parameter name should be final.	72
	Missing a Javadoc comment.	76
	Parameter name should be final.	76
	Parameter value should be final.	76
	Missing a Javadoc comment.	80
	Parameter name should be final.	80
	Missing a Javadoc comment.	84
	Missing a Javadoc comment.	88
	Missing a Javadoc comment.	92
	Parameter type should be final.	92
	'if' construct must use '{}'s.	93
	'if' construct must use '{}'s.	94
	'if' construct must use '{}'s.	95
	Missing a Javadoc comment.	99
	Parameter rawdata should be final.	99
	Missing a Javadoc comment.	103
	Parameter out should be final.	103
	Missing a Javadoc comment.	108
	Parameter in should be final.	108
	Missing a Javadoc comment.	116
	Parameter rawData should be final.	116
	'+' is not preceded with whitespace.	122
	'+' is not followed by whitespace.	122
	'+' is not preceded with whitespace.	124
	'+' is not followed by whitespace.	124
	'+' is not preceded with whitespace.	126
	'+' is not followed by whitespace.	126
	Missing a Javadoc comment.	131
	Parameter tokenString should be final.	131
	'=' is not preceded with whitespace.	133
	'=' is not followed by whitespace.	133

javax/activation/MimeTypeParameterList.java

Violation	Message	Line
	File does not end with a newline.	0
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	37
	Parameter parameterList should be final.	37
	Missing a Javadoc comment.	41
	Parameter parameterList should be final.	41
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	59
	Missing a Javadoc comment.	63
	Parameter name should be final.	63
	Missing a Javadoc comment.	67
	Parameter name should be final.	67
	Parameter value should be final.	67
	Missing a Javadoc comment.	71
	Parameter name should be final.	71
	Missing a Javadoc comment.	75
	Expected an @return tag.	84
	'4' is a magic number.	85
	Missing a Javadoc comment.	94
	Parameter buf should be final.	94
	Parameter value should be final.	94
	Class RFC2045Parser should be declared as final.	118
	Missing a Javadoc comment.	118
	Missing a Javadoc comment.	119
	Missing a Javadoc comment.	120
	Missing a Javadoc comment.	122
	Parameter text should be final.	122
	First sentence should end with a period.	126
	Expected an @return tag.	131
	Expected @throws tag for 'MimeTypeParseException'.	131
	Missing a Javadoc comment.	145
	Missing a Javadoc comment.	160
	Missing a Javadoc comment.	173

javax/activation/MailcapCommandMap.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Unused import - java.security.Security.	29
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	48
	Must have at least one statement.	60
	Must have at least one statement.	80
	Must have at least one statement.	82
	Must have at least one statement.	95
	Must have at least one statement.	97
	Must have at least one statement.	110
	Must have at least one statement.	112
	Missing a Javadoc comment.	117
	Parameter fileName should be final.	117
	Missing a Javadoc comment.	127
	Parameter is should be final.	127
	Missing a Javadoc comment.	132
	Parameter is should be final.	132
	Must have at least one statement.	135
	Missing a Javadoc comment.	140
	Parameter reader should be final.	140
	Missing a Javadoc comment.	148
	Parameter mail_cap should be final.	148
	Name 'mail_cap' must match pattern '^[a-z][a-zA-Z0-9]*$'.	148
	'7' is a magic number.	216
	'7' is a magic number.	217
	'}' should be on the same line.	223
	Parameter mimeType should be final.	242
	Parameter commands should be final.	242
	Parameter fallback should be final.	242
	Avoid inline conditionals.	244
	'cast' is not followed by whitespace.	248
	Parameter commandList should be final.	271
	Parameter mimeType should be final.	271
	Parameter command should be final.	271
	Missing a Javadoc comment.	282
	Parameter s should be final.	282
	Parameter index should be final.	282
	Missing a Javadoc comment.	289
	Parameter s should be final.	289
	Parameter index should be final.	289
	Missing a Javadoc comment.	296
	Parameter s should be final.	296
	Parameter index should be final.	296
	Missing a Javadoc comment.	313
	Parameter mimeType should be final.	313
	'fallbackCommands' hides a field.	322
	'}' should be on the same line.	329
	Missing a Javadoc comment.	343
	Parameter mimeType should be final.	343
	'cast' is not followed by whitespace.	348
	Missing a Javadoc comment.	358
	Parameter main should be final.	358
	Parameter fallback should be final.	358
	Missing a Javadoc comment.	367
	Parameter mimeType should be final.	367
	'fallbackCommands' hides a field.	378
	'cast' is not followed by whitespace.	394
	Missing a Javadoc comment.	399
	Parameter mimeType should be final.	399
	Parameter cmdName should be final.	399
	Missing a Javadoc comment.	426
	Parameter mimeType should be final.	426
	Missing a Javadoc comment.	435
	Parameter mimeType should be final.	435

javax/activation/DataContentHandler.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	29
	Redundant 'public' modifier.	29
	Missing a Javadoc comment.	31
	Redundant 'public' modifier.	31
	Missing a Javadoc comment.	33
	Redundant 'public' modifier.	33
	Missing a Javadoc comment.	35
	Redundant 'public' modifier.	35

Parent Project

Project Documentation

Checkstyle Results

Summary

Rules

Files

Details

javax/activation/MimeTypeParseException.java

javax/activation/ActivationDataFlavor.java

javax/activation/URLDataSource.java

javax/activation/package.html

javax/activation/FileDataSource.java

javax/activation/DataSource.java

javax/activation/CommandObject.java

javax/activation/FileTypeMap.java

javax/activation/DataHandler.java

javax/activation/CommandInfo.java

javax/activation/DataContentHandlerFactory.java

javax/activation/MimetypesFileTypeMap.java

javax/activation/CommandMap.java

javax/activation/UnsupportedDataTypeException.java

javax/activation/MimeType.java

javax/activation/MimeTypeParameterList.java

javax/activation/MailcapCommandMap.java

javax/activation/DataContentHandler.java