Servlet 2.4 - Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
42	0	0	810

Rules

Rules	Violations	Severity
PackageHtml	2	Error
NewlineAtEndOfFile	1	Error
Translation	0	Error
JavadocMethod	263	Error
JavadocType	0	Error
JavadocVariable	42	Error
JavadocStyle	6	Error
ConstantName	1	Error
LocalFinalVariableName	0	Error
LocalVariableName	8	Error
MemberName	0	Error
MethodName	2	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName	0	Error
Header headerFile: `"/Users/jason/ws/geronimo/specs/geronimo-servlet_2.4_spec/target/checkstyle-header.txt"`	40	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	0	Error
FileLength	0	Error
LineLength max: `"120"`	4	Error
MethodLength	0	Error
ParameterNumber	0	Error
EmptyForIteratorPad	0	Error
NoWhitespaceAfter	0	Error
NoWhitespaceBefore	0	Error
OperatorWrap	2	Error
ParenPad	0	Error
TypecastParenPad	0	Error
TabCharacter	0	Error
WhitespaceAfter	0	Error
WhitespaceAround	0	Error
ModifierOrder	3	Error
RedundantModifier	212	Error
AvoidNestedBlocks	0	Error
EmptyBlock	0	Error
LeftCurly	0	Error
NeedBraces	30	Error
RightCurly	0	Error
AvoidInlineConditionals	2	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	2	Error
IllegalInstantiation	0	Error
InnerAssignment	0	Error
MagicNumber	9	Error
MissingSwitchDefault	0	Error
RedundantThrows	3	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
FinalClass	0	Error
HideUtilityClassConstructor	1	Error
InterfaceIsType	0	Error
VisibilityModifier	0	Error
ArrayTypeStyle	3	Error
FinalParameters	174	Error
GenericIllegalRegexp message: `"Line has trailing spaces."` format: `"\s+$"`	0	Error
TodoComment	0	Error
UpperEll	0	Error

Files

Files	I	W	E
javax/servlet/SingleThreadModel.java	0	0	1
javax/servlet/http/HttpSessionListener.java	0	0	3
javax/servlet/UnavailableException.java	0	0	11
javax/servlet/GenericServlet.java	0	0	8
javax/servlet/ServletException.java	0	0	6
javax/servlet/http/HttpServletRequestWrapper.java	0	0	43
javax/servlet/http/HttpUtils.java	0	0	26
javax/servlet/http/HttpSessionContext.java	0	0	6
javax/servlet/ServletInputStream.java	0	0	5
javax/servlet/http/HttpServletResponseWrapper.java	0	0	64
javax/servlet/http/HttpSession.java	0	0	33
javax/servlet/ServletContextAttributeListener.java	0	0	7
javax/servlet/http/HttpSessionActivationListener.java	0	0	5
javax/servlet/ServletRequestWrapper.java	0	0	56
javax/servlet/ServletContextListener.java	0	0	5
javax/servlet/http/Cookie.java	0	0	29
javax/servlet/ServletRequest.java	0	0	36
javax/servlet/ServletConfig.java	0	0	5
javax/servlet/http/HttpServletResponse.java	0	0	62
javax/servlet/ServletResponseWrapper.java	0	0	29
javax/servlet/http/HttpSessionAttributeListener.java	0	0	7
javax/servlet/ServletOutputStream.java	0	0	21
javax/servlet/FilterChain.java	0	0	4
javax/servlet/Servlet.java	0	0	6
javax/servlet/http/HttpSessionBindingEvent.java	0	0	11
javax/servlet/ServletContextEvent.java	0	0	2
javax/servlet/FilterConfig.java	0	0	6
javax/servlet/ServletContextAttributeEvent.java	0	0	11
javax/servlet/RequestDispatcher.java	0	0	4
javax/servlet/ServletResponse.java	0	0	23
javax/servlet/ServletRequestEvent.java	0	0	4
javax/servlet/package.html	0	0	1
javax/servlet/http/HttpSessionEvent.java	0	0	4
javax/servlet/http/HttpSessionBindingListener.java	0	0	3
javax/servlet/http/HttpServlet.java	0	0	162
javax/servlet/ServletContext.java	0	0	33
javax/servlet/ServletRequestAttributeListener.java	0	0	7
javax/servlet/http/package.html	0	0	1
javax/servlet/ServletRequestListener.java	0	0	5
javax/servlet/Filter.java	0	0	15
javax/servlet/ServletRequestAttributeEvent.java	0	0	7
javax/servlet/http/HttpServletRequest.java	0	0	33

Details

javax/servlet/SingleThreadModel.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1

javax/servlet/http/HttpSessionListener.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Redundant 'public' modifier.	45
	Redundant 'public' modifier.	51

javax/servlet/UnavailableException.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	53
	Parameter servlet should be final.	74
	Parameter msg should be final.	74
	Parameter seconds should be final.	94
	Parameter servlet should be final.	94
	Parameter msg should be final.	94
	Parameter msg should be final.	112
	Parameter msg should be final.	137
	Parameter seconds should be final.	137
	Avoid inline conditionals.	190

javax/servlet/GenericServlet.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	53
	Parameter name should be final.	84
	Parameter config should be final.	166
	'config' hides a field.	166
	Parameter msg should be final.	195
	Parameter message should be final.	211
	Parameter t should be final.	211

javax/servlet/ServletException.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	33
	Parameter message should be final.	51
	Parameter message should be final.	68
	Parameter rootCause should be final.	68
	Parameter rootCause should be final.	90

javax/servlet/http/HttpServletRequestWrapper.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Unused @throws tag for 'java.lang.IllegalArgumentException'.	44
	Parameter request should be final.	46
	Expected @param tag for 'request'.	46
	Missing a Javadoc comment.	50
	Name '_getHttpServletRequest' must match pattern '^[a-z][a-zA-Z0-9]*$'.	50
	Expected an @return tag.	58
	Expected an @return tag.	66
	Expected an @return tag.	74
	Parameter name should be final.	74
	Expected @param tag for 'name'.	74
	Expected an @return tag.	82
	Parameter name should be final.	82
	Expected @param tag for 'name'.	82
	Expected an @return tag.	90
	Parameter name should be final.	90
	Expected @param tag for 'name'.	90
	Expected an @return tag.	98
	Expected an @return tag.	106
	Parameter name should be final.	106
	Expected @param tag for 'name'.	106
	Expected an @return tag.	114
	Expected an @return tag.	122
	Expected an @return tag.	130
	Expected an @return tag.	138
	Expected an @return tag.	146
	Expected an @return tag.	154
	Expected an @return tag.	162
	Parameter role should be final.	162
	Expected @param tag for 'role'.	162
	Expected an @return tag.	170
	Expected an @return tag.	178
	Expected an @return tag.	186
	Expected an @return tag.	194
	Expected an @return tag.	202
	Expected an @return tag.	210
	Parameter create should be final.	210
	Expected @param tag for 'create'.	210
	Expected an @return tag.	218
	Expected an @return tag.	226
	Expected an @return tag.	234
	Expected an @return tag.	242
	Expected an @return tag.	250

javax/servlet/http/HttpUtils.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Utility classes should not have a public or default constructor.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	40
	Unused @throws tag for 'IllegalArgumentException'.	70
	'public' modifier out of order with the JLS suggestions.	72
	Parameter s should be final.	72
	Array brackets at illegal position.	74
	Array brackets at illegal position.	93
	'for' construct must use '{}'s.	95
	Unused @throws tag for 'IllegalArgumentException'.	132
	'public' modifier out of order with the JLS suggestions.	135
	Parameter len should be final.	135
	Parameter in should be final.	135
	Expected an @return tag.	185
	'private' modifier out of order with the JLS suggestions.	185
	Parameter s should be final.	185
	Expected @param tag for 's'.	185
	Parameter sb should be final.	185
	Expected @param tag for 'sb'.	185
	'3' is a magic number.	195
	'16' is a magic number.	196
	'if' construct must use '{}'s.	205
	Parameter req should be final.	237
	'80' is a magic number.	249
	'443' is a magic number.	250

javax/servlet/http/HttpSessionContext.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Expected an @return tag.	44
	Redundant 'public' modifier.	44
	Expected @param tag for 'sessionId'.	44
	Expected an @return tag.	51
	Redundant 'public' modifier.	51

javax/servlet/ServletInputStream.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Parameter b should be final.	77
	Parameter off should be final.	77
	Parameter len should be final.	77
	Avoid inline conditionals.	90

javax/servlet/http/HttpServletResponseWrapper.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Unused @throws tag for 'java.lang.IllegalArgumentException'.	44
	Parameter response should be final.	46
	Expected @param tag for 'response'.	46
	Missing a Javadoc comment.	50
	Name '_getHttpServletResponse' must match pattern '^[a-z][a-zA-Z0-9]*$'.	50
	Parameter cookie should be final.	58
	Expected @param tag for 'cookie'.	58
	Expected an @return tag.	66
	Parameter name should be final.	66
	Expected @param tag for 'name'.	66
	Expected an @return tag.	74
	Parameter url should be final.	74
	Expected @param tag for 'url'.	74
	Expected an @return tag.	82
	Parameter url should be final.	82
	Expected @param tag for 'url'.	82
	Expected an @return tag.	90
	Parameter url should be final.	90
	Expected @param tag for 'url'.	90
	Expected an @return tag.	98
	Parameter url should be final.	98
	Expected @param tag for 'url'.	98
	Parameter sc should be final.	106
	Expected @param tag for 'sc'.	106
	Parameter msg should be final.	106
	Expected @param tag for 'msg'.	106
	Expected @throws tag for 'IOException'.	106
	Parameter sc should be final.	114
	Expected @param tag for 'sc'.	114
	Expected @throws tag for 'IOException'.	114
	Parameter location should be final.	122
	Expected @param tag for 'location'.	122
	Expected @throws tag for 'IOException'.	122
	Parameter name should be final.	130
	Expected @param tag for 'name'.	130
	Parameter date should be final.	130
	Expected @param tag for 'date'.	130
	Parameter name should be final.	138
	Expected @param tag for 'name'.	138
	Parameter date should be final.	138
	Expected @param tag for 'date'.	138
	Parameter name should be final.	146
	Expected @param tag for 'name'.	146
	Parameter value should be final.	146
	Expected @param tag for 'value'.	146
	Parameter name should be final.	154
	Expected @param tag for 'name'.	154
	Parameter value should be final.	154
	Expected @param tag for 'value'.	154
	Parameter name should be final.	162
	Expected @param tag for 'name'.	162
	Parameter value should be final.	162
	Expected @param tag for 'value'.	162
	Parameter name should be final.	170
	Expected @param tag for 'name'.	170
	Parameter value should be final.	170
	Expected @param tag for 'value'.	170
	Parameter sc should be final.	178
	Expected @param tag for 'sc'.	178
	Parameter sc should be final.	186
	Expected @param tag for 'sc'.	186
	Parameter sm should be final.	186
	Expected @param tag for 'sm'.	186

javax/servlet/http/HttpSession.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Unused @throws tag for 'IllegalStateException'.	86
	Redundant 'public' modifier.	89
	Unused @throws tag for 'IllegalStateException'.	98
	Redundant 'public' modifier.	101
	Unused @throws tag for 'IllegalStateException'.	116
	Redundant 'public' modifier.	119
	Redundant 'public' modifier.	127
	Redundant 'public' modifier.	136
	Redundant 'public' modifier.	151
	Expected an @return tag.	158
	Redundant 'public' modifier.	158
	Unused @throws tag for 'IllegalStateException'.	168
	Redundant 'public' modifier.	171
	Unused @throws tag for 'IllegalStateException'.	181
	Redundant 'public' modifier.	184
	Unused @throws tag for 'IllegalStateException'.	193
	Redundant 'public' modifier.	196
	Unused @throws tag for 'IllegalStateException'.	205
	Redundant 'public' modifier.	208
	Unclosed HTML tag found: <code>removeAttribute()<code>.	226
	Unused @throws tag for 'IllegalStateException'.	232
	Redundant 'public' modifier.	235
	Unused @throws tag for 'IllegalStateException'.	245
	Redundant 'public' modifier.	248
	Unused @throws tag for 'IllegalStateException'.	263
	Redundant 'public' modifier.	266
	Unused @throws tag for 'IllegalStateException'.	274
	Redundant 'public' modifier.	277
	Unused @throws tag for 'IllegalStateException'.	282
	Redundant 'public' modifier.	285
	Unused @throws tag for 'IllegalStateException'.	297
	Redundant 'public' modifier.	300

javax/servlet/ServletContextAttributeListener.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Redundant 'public' modifier.	45
	Expected @param tag for 'scab'.	45
	Redundant 'public' modifier.	51
	Expected @param tag for 'scab'.	51
	Redundant 'public' modifier.	57
	Expected @param tag for 'scab'.	57

javax/servlet/http/HttpSessionActivationListener.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Redundant 'public' modifier.	43
	Expected @param tag for 'se'.	43
	Redundant 'public' modifier.	48
	Expected @param tag for 'se'.	48

javax/servlet/ServletRequestWrapper.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	45
	Unused @throws tag for 'java.lang.IllegalArgumentException'.	49
	Parameter request should be final.	51
	Expected @param tag for 'request'.	51
	Expected an @return tag.	61
	Unused @throws tag for 'java.lang.IllegalArgumentException'.	67
	Parameter request should be final.	69
	Expected @param tag for 'request'.	69
	Expected an @return tag.	80
	Parameter name should be final.	80
	Expected @param tag for 'name'.	80
	Expected an @return tag.	88
	Expected an @return tag.	96
	Parameter enc should be final.	104
	Expected @param tag for 'enc'.	104
	Expected @throws tag for 'java.io.UnsupportedEncodingException'.	104
	Expected an @return tag.	112
	Expected an @return tag.	120
	Expected an @return tag.	129
	Expected @throws tag for 'IOException'.	129
	Expected an @return tag.	137
	Parameter name should be final.	137
	Expected @param tag for 'name'.	137
	Expected an @return tag.	145
	Expected an @return tag.	153
	Expected an @return tag.	161
	Parameter name should be final.	161
	Expected @param tag for 'name'.	161
	Expected an @return tag.	169
	Expected an @return tag.	177
	Expected an @return tag.	185
	Expected an @return tag.	193
	Expected an @return tag.	201
	Expected @throws tag for 'IOException'.	201
	Expected an @return tag.	209
	Expected an @return tag.	217
	Parameter name should be final.	225
	Expected @param tag for 'name'.	225
	Parameter o should be final.	225
	Expected @param tag for 'o'.	225
	Parameter name should be final.	233
	Expected @param tag for 'name'.	233
	Expected an @return tag.	241
	Expected an @return tag.	249
	Expected an @return tag.	257
	Expected an @return tag.	265
	Parameter path should be final.	265
	Expected @param tag for 'path'.	265
	Expected an @return tag.	273
	Parameter path should be final.	273
	Expected @param tag for 'path'.	273
	Expected an @return tag.	283
	Expected an @return tag.	293
	Expected an @return tag.	303
	Expected an @return tag.	313

javax/servlet/ServletContextListener.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Redundant 'public' modifier.	48
	Expected @param tag for 'sce'.	48
	Redundant 'public' modifier.	55
	Expected @param tag for 'sce'.	55

javax/servlet/http/Cookie.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	71
	Missing a Javadoc comment.	77
	Missing a Javadoc comment.	78
	Missing a Javadoc comment.	84
	Missing a Javadoc comment.	86
	Missing a Javadoc comment.	87
	Missing a Javadoc comment.	88
	Missing a Javadoc comment.	89
	Missing a Javadoc comment.	90
	Unused @throws tag for 'IllegalArgumentException'.	115
	Parameter name should be final.	122
	Parameter value should be final.	122
	Parameter purpose should be final.	156
	Parameter pattern should be final.	188
	Parameter expiry should be final.	223
	Parameter uri should be final.	259
	Parameter flag should be final.	289
	Parameter newValue should be final.	332
	Parameter v should be final.	378
	Missing a Javadoc comment.	387
	Name 'tspecials' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	387
	Parameter value should be final.	398
	'value' hides a field.	398
	'if' construct must use '{}'s.	404
	'0x20' is a magic number.	404
	'0x7f' is a magic number.	404
	Expected an @return tag.	414

javax/servlet/ServletRequest.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Redundant 'public' modifier.	72
	Redundant 'public' modifier.	84
	Redundant 'public' modifier.	95
	Redundant 'public' modifier.	107
	Redundant 'public' modifier.	118
	Redundant 'public' modifier.	128
	Unused @throws tag for 'IllegalStateException'.	138
	Redundant 'public' modifier.	143
	Redundant 'public' modifier.	172
	Redundant 'public' modifier.	187
	Redundant 'public' modifier.	205
	Redundant 'public' modifier.	218
	Redundant 'public' modifier.	230
	Redundant 'public' modifier.	242
	Redundant 'public' modifier.	252
	Redundant 'public' modifier.	262
	Unused @throws tag for 'UnsupportedEncodingException'.	273
	Unused @throws tag for 'IllegalStateException'.	276
	Redundant 'public' modifier.	283
	Redundant 'public' modifier.	294
	Redundant 'public' modifier.	307
	Redundant 'public' modifier.	325
	Redundant 'public' modifier.	340
	Redundant 'public' modifier.	350
	Redundant 'public' modifier.	364
	Redundant 'public' modifier.	373
	Redundant 'public' modifier.	404
	Expected an @return tag.	410
	Redundant 'public' modifier.	410
	Expected @param tag for 'path'.	410
	Expected an @return tag.	418
	Redundant 'public' modifier.	418
	Redundant 'public' modifier.	429
	Redundant 'public' modifier.	440
	Redundant 'public' modifier.	450

javax/servlet/ServletConfig.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Redundant 'public' modifier.	43
	Redundant 'public' modifier.	53
	Redundant 'public' modifier.	66
	Redundant 'public' modifier.	77

javax/servlet/http/HttpServletResponse.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Redundant 'public' modifier.	49
	Redundant 'public' modifier.	59
	Redundant 'public' modifier.	78
	Redundant 'public' modifier.	102
	Redundant 'public' modifier.	111
	Redundant 'public' modifier.	120
	Unused @throws tag for 'IllegalStateException'.	141
	Redundant 'public' modifier.	143
	Unused @throws tag for 'IllegalStateException'.	155
	Redundant 'public' modifier.	158
	Unused @throws tag for 'IllegalStateException'.	176
	Redundant 'public' modifier.	179
	Redundant 'public' modifier.	195
	Redundant 'public' modifier.	208
	Redundant 'public' modifier.	225
	Redundant 'public' modifier.	238
	Redundant 'public' modifier.	253
	Redundant 'public' modifier.	265
	Redundant 'public' modifier.	281
	Redundant 'public' modifier.	294
	Redundant 'public' modifier.	303
	Redundant 'public' modifier.	309
	Redundant 'public' modifier.	314
	Redundant 'public' modifier.	320
	Redundant 'public' modifier.	326
	Redundant 'public' modifier.	332
	Redundant 'public' modifier.	338
	Redundant 'public' modifier.	344
	Redundant 'public' modifier.	350
	Redundant 'public' modifier.	357
	Redundant 'public' modifier.	364
	Redundant 'public' modifier.	374
	Redundant 'public' modifier.	383
	Redundant 'public' modifier.	389
	Redundant 'public' modifier.	395
	Redundant 'public' modifier.	402
	Redundant 'public' modifier.	410
	Redundant 'public' modifier.	416
	Redundant 'public' modifier.	422
	Redundant 'public' modifier.	427
	Redundant 'public' modifier.	433
	Redundant 'public' modifier.	439
	Redundant 'public' modifier.	446
	Redundant 'public' modifier.	454
	Redundant 'public' modifier.	460
	Redundant 'public' modifier.	466
	Redundant 'public' modifier.	473
	Redundant 'public' modifier.	480
	Redundant 'public' modifier.	486
	Redundant 'public' modifier.	493
	Redundant 'public' modifier.	500
	Redundant 'public' modifier.	507
	Redundant 'public' modifier.	514
	Redundant 'public' modifier.	520
	Redundant 'public' modifier.	526
	Redundant 'public' modifier.	532
	Redundant 'public' modifier.	538
	Redundant 'public' modifier.	545
	Redundant 'public' modifier.	551
	Redundant 'public' modifier.	558
	Redundant 'public' modifier.	565

javax/servlet/ServletResponseWrapper.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	43
	Unused @throws tag for 'java.lang.IllegalArgumentException'.	47
	Parameter response should be final.	49
	Expected @param tag for 'response'.	49
	Expected an @return tag.	59
	Unused @throws tag for 'java.lang.IllegalArgumentException'.	65
	Parameter response should be final.	67
	Expected @param tag for 'response'.	67
	Parameter charset should be final.	80
	Expected @param tag for 'charset'.	80
	Expected an @return tag.	88
	Expected an @return tag.	96
	Expected @throws tag for 'IOException'.	96
	Expected an @return tag.	104
	Expected @throws tag for 'IOException'.	104
	Parameter len should be final.	112
	Expected @param tag for 'len'.	112
	Parameter type should be final.	120
	Expected @param tag for 'type'.	120
	Expected an @return tag.	130
	Parameter size should be final.	138
	Expected @param tag for 'size'.	138
	Expected an @return tag.	146
	Expected @throws tag for 'IOException'.	155
	Expected an @return tag.	163
	Parameter loc should be final.	187
	Expected @param tag for 'loc'.	187
	Expected an @return tag.	195

javax/servlet/http/HttpSessionAttributeListener.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Redundant 'public' modifier.	41
	Expected @param tag for 'se'.	41
	Redundant 'public' modifier.	46
	Expected @param tag for 'se'.	46
	Redundant 'public' modifier.	51
	Expected @param tag for 'se'.	51

javax/servlet/ServletOutputStream.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	48
	Parameter s should be final.	65
	'if' construct must use '{}'s.	66
	'0xff00' is a magic number.	77
	Parameter b should be final.	99
	Parameter c should be final.	118
	Parameter i should be final.	131
	Parameter l should be final.	145
	Parameter f should be final.	158
	Parameter d should be final.	171
	Extra HTML tag found: </code>String</code> to write to the client	189
	Extra HTML tag found: </code> to write to the client	189
	Parameter s should be final.	193
	Parameter b should be final.	208
	Parameter c should be final.	221
	Parameter i should be final.	234
	Parameter l should be final.	247
	Parameter f should be final.	260
	Parameter d should be final.	274

javax/servlet/FilterChain.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Redundant 'public' modifier.	49
	Expected @throws tag for 'IOException'.	49
	Expected @throws tag for 'ServletException'.	49

javax/servlet/Servlet.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Redundant 'public' modifier.	89
	Redundant 'public' modifier.	107
	Redundant 'public' modifier.	140
	Redundant 'public' modifier.	153
	Redundant 'public' modifier.	169

javax/servlet/http/HttpSessionBindingEvent.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	44
	First sentence should end with a period.	49
	Parameter session should be final.	67
	Parameter name should be final.	67
	Parameter session should be final.	85
	Parameter name should be final.	85
	Parameter value should be final.	85
	Expected @param tag for 'value'.	85
	Expected an @return tag.	94
	Expected an @return tag.	118

javax/servlet/ServletContextEvent.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Parameter source should be final.	42

javax/servlet/FilterConfig.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Expected an @return tag.	41
	Redundant 'public' modifier.	41
	Redundant 'public' modifier.	53
	Redundant 'public' modifier.	66
	Redundant 'public' modifier.	78

javax/servlet/ServletContextAttributeEvent.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	36
	Parameter source should be final.	42
	Expected @param tag for 'source'.	42
	Parameter name should be final.	42
	Expected @param tag for 'name'.	42
	Parameter value should be final.	42
	Expected @param tag for 'value'.	42
	Expected an @return tag.	51
	Expected an @return tag.	61

javax/servlet/RequestDispatcher.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Unused @throws tag for 'IllegalStateException'.	83
	Redundant 'public' modifier.	85
	Redundant 'public' modifier.	113

javax/servlet/ServletResponse.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Redundant 'public' modifier.	84
	Redundant 'public' modifier.	106
	Unused @throws tag for 'IllegalStateException'.	120
	Redundant 'public' modifier.	127
	Unused @throws tag for 'UnsupportedEncodingException'.	147
	Unused @throws tag for 'IllegalStateException'.	150
	Redundant 'public' modifier.	158
	Redundant 'public' modifier.	196
	Redundant 'public' modifier.	206
	Redundant 'public' modifier.	235
	Unused @throws tag for 'IllegalStateException'.	256
	Redundant 'public' modifier.	264
	Redundant 'public' modifier.	277
	Redundant 'public' modifier.	289
	Expected @throws tag for 'IOException'.	289
	Redundant 'public' modifier.	304
	Redundant 'public' modifier.	318
	Unused @throws tag for 'IllegalStateException'.	325
	Redundant 'public' modifier.	333
	Redundant 'public' modifier.	371
	Expected an @return tag.	382
	Redundant 'public' modifier.	382

javax/servlet/ServletRequestEvent.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	38
	Parameter sc should be final.	46
	Parameter request should be final.	46

javax/servlet/package.html

Violation	Message	Line
	Missing package documentation file.	0

javax/servlet/http/HttpSessionEvent.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Parameter source should be final.	37
	Expected @param tag for 'source'.	37
	Expected an @return tag.	44

javax/servlet/http/HttpSessionBindingListener.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Redundant 'public' modifier.	49
	Redundant 'public' modifier.	59

javax/servlet/http/HttpServlet.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	84
	Missing a Javadoc comment.	85
	Missing a Javadoc comment.	86
	Missing a Javadoc comment.	87
	Missing a Javadoc comment.	88
	Missing a Javadoc comment.	89
	Missing a Javadoc comment.	90
	Missing a Javadoc comment.	92
	Missing a Javadoc comment.	93
	Missing a Javadoc comment.	95
	Missing a Javadoc comment.	97
	Parameter req should be final.	168
	Parameter resp should be final.	168
	Parameter req should be final.	199
	Parameter req should be final.	235
	Parameter resp should be final.	235
	Parameter req should be final.	296
	Parameter resp should be final.	296
	Parameter req should be final.	346
	Parameter resp should be final.	346
	Parameter req should be final.	387
	Parameter resp should be final.	388
	Missing a Javadoc comment.	399
	Parameter c should be final.	399
	'if' construct must use '{}'s.	400
	Parameter req should be final.	451
	Parameter resp should be final.	451
	Name 'ALLOW_GET' must match pattern '^[a-z][a-zA-Z0-9]*$'.	455
	Name 'ALLOW_HEAD' must match pattern '^[a-z][a-zA-Z0-9]*$'.	456
	Name 'ALLOW_POST' must match pattern '^[a-z][a-zA-Z0-9]*$'.	457
	Name 'ALLOW_PUT' must match pattern '^[a-z][a-zA-Z0-9]*$'.	458
	Name 'ALLOW_DELETE' must match pattern '^[a-z][a-zA-Z0-9]*$'.	459
	Name 'ALLOW_TRACE' must match pattern '^[a-z][a-zA-Z0-9]*$'.	460
	Name 'ALLOW_OPTIONS' must match pattern '^[a-z][a-zA-Z0-9]*$'.	461
	'if' construct must use '{}'s.	470
	'if' construct must use '{}'s.	472
	'if' construct must use '{}'s.	474
	'if' construct must use '{}'s.	479
	'if' construct must use '{}'s.	480
	'if' construct must use '{}'s.	481
	'if' construct must use '{}'s.	482
	'else' construct must use '{}'s.	484
	'if' construct must use '{}'s.	486
	'if' construct must use '{}'s.	487
	'else' construct must use '{}'s.	489
	'if' construct must use '{}'s.	491
	'if' construct must use '{}'s.	492
	'else' construct must use '{}'s.	494
	'if' construct must use '{}'s.	496
	'if' construct must use '{}'s.	497
	'else' construct must use '{}'s.	499
	'if' construct must use '{}'s.	501
	'if' construct must use '{}'s.	502
	'else' construct must use '{}'s.	504
	'if' construct must use '{}'s.	506
	'if' construct must use '{}'s.	507
	'else' construct must use '{}'s.	509
	Parameter req should be final.	535
	Parameter resp should be final.	535
	Name 'CRLF' must match pattern '^[a-z][a-zA-Z0-9]*$'.	540
	'+' should be on a new line.	541
	'+' should be on a new line.	548
	Parameter req should be final.	586
	Parameter resp should be final.	586
	'1000' is a magic number.	598
	'1000' is a magic number.	598
	Parameter resp should be final.	651
	Expected @param tag for 'resp'.	651
	Parameter lastModified should be final.	651
	Expected @param tag for 'lastModified'.	651
	'if' construct must use '{}'s.	652
	'if' construct must use '{}'s.	654
	Parameter req should be final.	677
	Parameter res should be final.	677
	Missing a Javadoc comment.	699
	Missing a Javadoc comment.	700
	Missing a Javadoc comment.	701
	Missing a Javadoc comment.	702
	Missing a Javadoc comment.	704
	Parameter r should be final.	704
	Missing a Javadoc comment.	709
	Missing a Javadoc comment.	719
	Parameter len should be final.	719
	Missing a Javadoc comment.	724
	Parameter charset should be final.	724
	Missing a Javadoc comment.	728
	Parameter type should be final.	728
	Missing a Javadoc comment.	732
	Missing a Javadoc comment.	736
	Missing a Javadoc comment.	740
	Missing a Javadoc comment.	744
	Missing a Javadoc comment.	754
	Parameter size should be final.	754
	Redundant throws: 'IllegalStateException' is unchecked exception.	754
	Missing a Javadoc comment.	758
	Missing a Javadoc comment.	762
	Redundant throws: 'IllegalStateException' is unchecked exception.	762
	Missing a Javadoc comment.	766
	Redundant throws: 'IllegalStateException' is unchecked exception.	766
	Missing a Javadoc comment.	770
	Missing a Javadoc comment.	774
	Missing a Javadoc comment.	778
	Parameter loc should be final.	778
	Missing a Javadoc comment.	782
	Missing a Javadoc comment.	790
	Parameter cookie should be final.	790
	Missing a Javadoc comment.	794
	Parameter name should be final.	794
	Parameter sc should be final.	801
	Expected @param tag for 'sc'.	801
	Parameter sm should be final.	801
	Expected @param tag for 'sm'.	801
	Missing a Javadoc comment.	805
	Parameter sc should be final.	805
	Missing a Javadoc comment.	809
	Parameter name should be final.	809
	Parameter value should be final.	809
	Missing a Javadoc comment.	813
	Parameter name should be final.	813
	Parameter value should be final.	813
	Missing a Javadoc comment.	817
	Parameter name should be final.	817
	Parameter date should be final.	817
	Missing a Javadoc comment.	821
	Parameter sc should be final.	821
	Parameter msg should be final.	821
	Missing a Javadoc comment.	825
	Parameter sc should be final.	825
	Missing a Javadoc comment.	829
	Parameter location should be final.	829
	Missing a Javadoc comment.	833
	Parameter url should be final.	833
	Missing a Javadoc comment.	837
	Parameter url should be final.	837
	Missing a Javadoc comment.	841
	Parameter name should be final.	841
	Parameter value should be final.	841
	Missing a Javadoc comment.	845
	Parameter name should be final.	845
	Parameter value should be final.	845
	Missing a Javadoc comment.	849
	Parameter name should be final.	849
	Parameter value should be final.	849
	Expected an @return tag.	857
	Parameter url should be final.	857
	Expected @param tag for 'url'.	857
	Expected an @return tag.	865
	Parameter url should be final.	865
	Expected @param tag for 'url'.	865
	Missing a Javadoc comment.	875
	Missing a Javadoc comment.	877
	Missing a Javadoc comment.	880
	Missing a Javadoc comment.	882
	Missing a Javadoc comment.	885
	Missing a Javadoc comment.	889
	Parameter b should be final.	889
	Missing a Javadoc comment.	893
	Parameter buf should be final.	893
	Array brackets at illegal position.	893
	Parameter offset should be final.	893
	Parameter len should be final.	893

javax/servlet/ServletContext.java

Violation	Message	Line
	File does not end with a newline.	0
	Line does not match expected header line of ''.	1
	Redundant 'public' modifier.	81
	Redundant 'public' modifier.	91
	Redundant 'public' modifier.	101
	Redundant 'public' modifier.	115
	Redundant 'public' modifier.	143
	Redundant 'public' modifier.	183
	Redundant 'public' modifier.	216
	Redundant 'public' modifier.	241
	Redundant 'public' modifier.	268
	Expected an @return tag.	283
	Redundant 'public' modifier.	283
	Expected @param tag for 'name'.	283
	Expected @throws tag for 'ServletException'.	283
	Expected an @return tag.	295
	Redundant 'public' modifier.	295
	Expected an @return tag.	307
	Redundant 'public' modifier.	307
	Redundant 'public' modifier.	317
	Redundant 'public' modifier.	328
	Expected @param tag for 'exception'.	328
	Expected @param tag for 'msg'.	328
	Redundant 'public' modifier.	342
	Redundant 'public' modifier.	364
	Redundant 'public' modifier.	382
	Redundant 'public' modifier.	402
	Redundant 'public' modifier.	415
	Redundant 'public' modifier.	444
	Redundant 'public' modifier.	457
	Redundant 'public' modifier.	480
	Redundant 'public' modifier.	494
	Redundant 'public' modifier.	503

javax/servlet/ServletRequestAttributeListener.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Redundant 'public' modifier.	46
	Expected @param tag for 'srae'.	46
	Redundant 'public' modifier.	52
	Expected @param tag for 'srae'.	52
	Redundant 'public' modifier.	58
	Expected @param tag for 'srae'.	58

javax/servlet/http/package.html

Violation	Message	Line
	Missing package documentation file.	0

javax/servlet/ServletRequestListener.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Redundant 'public' modifier.	45
	Expected @param tag for 'sre'.	45
	Redundant 'public' modifier.	50
	Expected @param tag for 'sre'.	50

javax/servlet/Filter.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line is longer than 120 characters.	29
	Redundant 'public' modifier.	63
	Expected @param tag for 'filterConfig'.	63
	Expected @throws tag for 'ServletException'.	63
	Line is longer than 120 characters.	78
	Line is longer than 120 characters.	79
	Line is longer than 120 characters.	82
	Redundant 'public' modifier.	82
	Expected @param tag for 'request'.	82
	Expected @param tag for 'response'.	82
	Expected @param tag for 'chain'.	82
	Expected @throws tag for 'IOException'.	82
	Expected @throws tag for 'ServletException'.	82
	Redundant 'public' modifier.	94

javax/servlet/ServletRequestAttributeEvent.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Parameter sc should be final.	49
	Parameter request should be final.	49
	Parameter name should be final.	49
	Parameter value should be final.	49

javax/servlet/http/HttpServletRequest.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Redundant 'public' modifier.	44
	Redundant 'public' modifier.	49
	Redundant 'public' modifier.	54
	Redundant 'public' modifier.	59
	Redundant 'public' modifier.	75
	Redundant 'public' modifier.	86
	Unused @throws tag for 'IllegalArgumentException'.	112
	Redundant 'public' modifier.	115
	Redundant 'public' modifier.	132
	Redundant 'public' modifier.	156
	Redundant 'public' modifier.	171
	Unused @throws tag for 'NumberFormatException'.	188
	Redundant 'public' modifier.	191
	Redundant 'public' modifier.	201
	Redundant 'public' modifier.	219
	Redundant 'public' modifier.	236
	Redundant 'public' modifier.	248
	Redundant 'public' modifier.	259
	Redundant 'public' modifier.	271
	Redundant 'public' modifier.	285
	Redundant 'public' modifier.	296
	Redundant 'public' modifier.	309
	Redundant 'public' modifier.	334
	Redundant 'public' modifier.	349
	Redundant 'public' modifier.	366
	Redundant 'public' modifier.	391
	Redundant 'public' modifier.	401
	Redundant 'public' modifier.	413
	Redundant 'public' modifier.	423
	Redundant 'public' modifier.	434
	Expected an @return tag.	440
	Redundant 'public' modifier.	440

Parent Project

Project Documentation

Checkstyle Results

Summary

Rules

Files

Details

javax/servlet/SingleThreadModel.java

javax/servlet/http/HttpSessionListener.java

javax/servlet/UnavailableException.java

javax/servlet/GenericServlet.java

javax/servlet/ServletException.java

javax/servlet/http/HttpServletRequestWrapper.java

javax/servlet/http/HttpUtils.java

javax/servlet/http/HttpSessionContext.java

javax/servlet/ServletInputStream.java

javax/servlet/http/HttpServletResponseWrapper.java

javax/servlet/http/HttpSession.java

javax/servlet/ServletContextAttributeListener.java

javax/servlet/http/HttpSessionActivationListener.java

javax/servlet/ServletRequestWrapper.java

javax/servlet/ServletContextListener.java

javax/servlet/http/Cookie.java

javax/servlet/ServletRequest.java

javax/servlet/ServletConfig.java

javax/servlet/http/HttpServletResponse.java

javax/servlet/ServletResponseWrapper.java

javax/servlet/http/HttpSessionAttributeListener.java

javax/servlet/ServletOutputStream.java

javax/servlet/FilterChain.java

javax/servlet/Servlet.java

javax/servlet/http/HttpSessionBindingEvent.java

javax/servlet/ServletContextEvent.java

javax/servlet/FilterConfig.java

javax/servlet/ServletContextAttributeEvent.java

javax/servlet/RequestDispatcher.java

javax/servlet/ServletResponse.java

javax/servlet/ServletRequestEvent.java

javax/servlet/package.html

javax/servlet/http/HttpSessionEvent.java

javax/servlet/http/HttpSessionBindingListener.java

javax/servlet/http/HttpServlet.java

javax/servlet/ServletContext.java

javax/servlet/ServletRequestAttributeListener.java

javax/servlet/http/package.html

javax/servlet/ServletRequestListener.java

javax/servlet/Filter.java

javax/servlet/ServletRequestAttributeEvent.java

javax/servlet/http/HttpServletRequest.java